From: Stefano Garzarella <sgarzare@redhat.com>
To: "Eugenio Pérez" <eperezma@redhat.com>
Cc: netdev <netdev@vger.kernel.org>, Jason Wang <jasowang@redhat.com>,
kernel list <linux-kernel@vger.kernel.org>,
Linux Virtualization <virtualization@lists.linux-foundation.org>,
kvm <kvm@vger.kernel.org>, "Michael S. Tsirkin" <mst@redhat.com>,
Parav Pandit <parav@nvidia.com>,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Cindy Lu <lulu@redhat.com>, "Kamde, Tanuj" <tanuj.kamde@amd.com>,
Si-Wei Liu <si-wei.liu@oracle.com>,
Piotr.Uminski@intel.com, habetsm.xilinx@gmail.com, "Dawar,
Gautam" <gautam.dawar@amd.com>,
Pablo Cascon Katchadourian <pabloc@xilinx.com>,
Zhu Lingshan <lingshan.zhu@intel.com>,
Laurent Vivier <lvivier@redhat.com>,
Longpeng <longpeng2@huawei.com>,
Dinan Gunawardena <dinang@xilinx.com>,
Martin Petrus Hubertus Habets <martinh@xilinx.com>,
Martin Porter <martinpo@xilinx.com>, Eli Cohen <elic@nvidia.com>,
ecree.xilinx@gmail.com,
Wu Zongyong <wuzongyong@linux.alibaba.com>,
Dan Carpenter <dan.carpenter@oracle.com>,
Harpreet Singh Anand <hanand@xilinx.com>,
Xie Yongji <xieyongji@bytedance.com>,
Zhang Min <zhang.min9@zte.com.cn>
Subject: Re: [PATCH v6 3/4] vhost-vdpa: uAPI to suspend the device
Date: Tue, 28 Jun 2022 15:44:46 +0200 [thread overview]
Message-ID: <CAGxU2F43+5zsQOR4ReTtQtEF47s6y-XKcevosMOzUdEqpLhAsg@mail.gmail.com> (raw)
In-Reply-To: <20220623160738.632852-4-eperezma@redhat.com>
On Thu, Jun 23, 2022 at 06:07:37PM +0200, Eugenio Pérez wrote:
>The ioctl adds support for suspending the device from userspace.
>
>This is a must before getting virtqueue indexes (base) for live migration,
>since the device could modify them after userland gets them. There are
>individual ways to perform that action for some devices
>(VHOST_NET_SET_BACKEND, VHOST_VSOCK_SET_RUNNING, ...) but there was no
>way to perform it for any vhost device (and, in particular, vhost-vdpa).
>
>After a successful return of the ioctl call the device must not process
>more virtqueue descriptors. The device can answer to read or writes of
>config fields as if it were not suspended. In particular, writing to
>"queue_enable" with a value of 1 will not make the device start
>processing buffers of the virtqueue.
>
>Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
>---
> drivers/vhost/vdpa.c | 19 +++++++++++++++++++
> include/uapi/linux/vhost.h | 14 ++++++++++++++
> 2 files changed, 33 insertions(+)
>
>diff --git a/drivers/vhost/vdpa.c b/drivers/vhost/vdpa.c
>index 3d636e192061..7fa671ac4bdf 100644
>--- a/drivers/vhost/vdpa.c
>+++ b/drivers/vhost/vdpa.c
>@@ -478,6 +478,22 @@ static long vhost_vdpa_get_vqs_count(struct vhost_vdpa *v, u32 __user *argp)
> return 0;
> }
>
>+/* After a successful return of ioctl the device must not process more
>+ * virtqueue descriptors. The device can answer to read or writes of config
>+ * fields as if it were not suspended. In particular, writing to "queue_enable"
>+ * with a value of 1 will not make the device start processing buffers.
>+ */
>+static long vhost_vdpa_suspend(struct vhost_vdpa *v)
>+{
>+ struct vdpa_device *vdpa = v->vdpa;
>+ const struct vdpa_config_ops *ops = vdpa->config;
>+
>+ if (!ops->suspend)
>+ return -EOPNOTSUPP;
>+
>+ return ops->suspend(vdpa);
>+}
>+
> static long vhost_vdpa_vring_ioctl(struct vhost_vdpa *v, unsigned int cmd,
> void __user *argp)
> {
>@@ -654,6 +670,9 @@ static long vhost_vdpa_unlocked_ioctl(struct file *filep,
> case VHOST_VDPA_GET_VQS_COUNT:
> r = vhost_vdpa_get_vqs_count(v, argp);
> break;
>+ case VHOST_VDPA_SUSPEND:
>+ r = vhost_vdpa_suspend(v);
>+ break;
> default:
> r = vhost_dev_ioctl(&v->vdev, cmd, argp);
> if (r == -ENOIOCTLCMD)
>diff --git a/include/uapi/linux/vhost.h b/include/uapi/linux/vhost.h
>index cab645d4a645..6d9f45163155 100644
>--- a/include/uapi/linux/vhost.h
>+++ b/include/uapi/linux/vhost.h
>@@ -171,4 +171,18 @@
> #define VHOST_VDPA_SET_GROUP_ASID _IOW(VHOST_VIRTIO, 0x7C, \
> struct vhost_vring_state)
>
>+/* Suspend or resume a device so it does not process virtqueue requests anymore
>+ *
>+ * After the return of ioctl with suspend != 0, the device must finish any
>+ * pending operations like in flight requests. It must also preserve all the
>+ * necessary state (the virtqueue vring base plus the possible device specific
>+ * states) that is required for restoring in the future. The device must not
>+ * change its configuration after that point.
>+ *
>+ * After the return of ioctl with suspend == 0, the device can continue
>+ * processing buffers as long as typical conditions are met (vq is enabled,
>+ * DRIVER_OK status bit is enabled, etc).
>+ */
>+#define VHOST_VDPA_SUSPEND _IOW(VHOST_VIRTIO, 0x7D, int)
^
IIUC we are not using the argument anymore, so this should be changed in
_IO(VHOST_VIRTIO, 0x7D).
And we should update a bit the documentation.
Thanks,
Stefano
next prev parent reply other threads:[~2022-06-28 13:45 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-23 16:07 [PATCH v6 0/4] Implement vdpasim suspend operation Eugenio Pérez
2022-06-23 16:07 ` [PATCH v6 1/4] vdpa: Add " Eugenio Pérez
2022-06-28 13:39 ` Stefano Garzarella
2022-07-08 11:28 ` Eugenio Perez Martin
2022-06-29 4:10 ` Jason Wang
2022-07-08 11:30 ` Eugenio Perez Martin
2022-07-12 8:04 ` Jason Wang
2022-06-23 16:07 ` [PATCH v6 2/4] vhost-vdpa: introduce SUSPEND backend feature bit Eugenio Pérez
2022-06-28 13:43 ` Stefano Garzarella
2022-07-08 11:38 ` Eugenio Perez Martin
2022-07-08 13:51 ` Stefano Garzarella
2022-06-29 4:12 ` Jason Wang
2022-07-08 11:44 ` Eugenio Perez Martin
2022-06-23 16:07 ` [PATCH v6 3/4] vhost-vdpa: uAPI to suspend the device Eugenio Pérez
2022-06-28 13:44 ` Stefano Garzarella [this message]
2022-07-08 11:47 ` Eugenio Perez Martin
2022-06-29 4:15 ` Jason Wang
2022-07-08 11:53 ` Eugenio Perez Martin
2022-07-12 8:08 ` Jason Wang
2022-06-23 16:07 ` [PATCH v6 4/4] vdpa_sim: Implement suspend vdpa op Eugenio Pérez
2022-06-29 4:18 ` Jason Wang
2022-07-08 12:20 ` Eugenio Perez Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAGxU2F43+5zsQOR4ReTtQtEF47s6y-XKcevosMOzUdEqpLhAsg@mail.gmail.com \
--to=sgarzare@redhat.com \
--cc=Piotr.Uminski@intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=dan.carpenter@oracle.com \
--cc=dinang@xilinx.com \
--cc=ecree.xilinx@gmail.com \
--cc=elic@nvidia.com \
--cc=eperezma@redhat.com \
--cc=gautam.dawar@amd.com \
--cc=habetsm.xilinx@gmail.com \
--cc=hanand@xilinx.com \
--cc=jasowang@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=lingshan.zhu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=longpeng2@huawei.com \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=martinh@xilinx.com \
--cc=martinpo@xilinx.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pabloc@xilinx.com \
--cc=parav@nvidia.com \
--cc=si-wei.liu@oracle.com \
--cc=tanuj.kamde@amd.com \
--cc=virtualization@lists.linux-foundation.org \
--cc=wuzongyong@linux.alibaba.com \
--cc=xieyongji@bytedance.com \
--cc=zhang.min9@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).