From: Ammar Faizi <ammar.faizi@students.amikom.ac.id>
To: Willy Tarreau <w@1wt.eu>
Cc: Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andy Lutomirski <luto@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
x86@kernel.org, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] tools/nolibc: x86: Remove `r8`, `r9` and `r10` from the clobber list
Date: Wed, 13 Oct 2021 10:34:39 +0700 [thread overview]
Message-ID: <CAGzmLMXhez2Vvw8+iuBiEe-XRc+vNn8jDww9=aWe=mNk1rHgzA@mail.gmail.com> (raw)
In-Reply-To: <CAGzmLMVaKdBSQrpQFsqEw=Vs240vZANa+1-OLC-nNcKDDevnFQ@mail.gmail.com>
On Wed, Oct 13, 2021 at 10:32 AM Ammar Faizi
<ammar.faizi@students.amikom.ac.id> wrote:
>
> On Wed, Oct 13, 2021 at 10:01 AM Willy Tarreau <w@1wt.eu> wrote:
> >
> > On Wed, Oct 13, 2021 at 05:23:11AM +0700, Ammar Faizi wrote:
> > > According to x86-64 ABI about syscall section A.2 AMD64 Linux Kernel
> > > Conventions, A.2.1 Calling Conventions [1]:
> > >
> > > 1) User-level applications use as integer registers for passing the
> > > sequence %rdi, %rsi, %rdx, %rcx, %r8 and %r9. The kernel interface
> > > uses %rdi, %rsi, %rdx, %r10, %r8 and %r9.
> > >
> > > 2) A system-call is done via the syscall instruction. The kernel
> > > destroys registers %rcx and %r11.
> > >
> > > 3) The number of the syscall has to be passed in register %rax.
> > >
> > > 4) System-calls are limited to six arguments, no argument is passed
> > > directly on the stack.
> > >
> > > 5) Returning from the syscall, register %rax contains the result of
> > > the system-call. A value in the range between -4095 and -1
> > > indicates an error, it is -errno.
> > >
> > > 6) Only values of class INTEGER or class MEMORY are passed to the
> > > kernel.
> > >
> > > From (2), (5) and (6), we can conclude that Linux x86-64 syscall only
> > > clobbers rax, rcx and r11 (and "memory").
> > >
> > > - rax for the return value.
> > > - rcx to save the return address.
> > > - r11 to save the rflags.
> > >
> > > Other registers are preserved. Right?
> >
> > I totally agree, and this doc is perfectly clear on this. I think it
> > would be worth updating the comments in calling.h to reference this
> > document and remind these rules, given that they're not trivial to
> > figure from the code itself.
> >
>
> Alright, I will wire up patch v2 for this :-)
>
Not for calling.h, nolibc.h I mean.
next prev parent reply other threads:[~2021-10-13 3:34 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-11 4:03 [PATCH] tools/nolibc: x86: Remove `r8`, `r9` and `r10` from the clobber list Ammar Faizi
2021-10-12 5:28 ` Willy Tarreau
2021-10-12 8:36 ` Ammar Faizi
2021-10-12 9:06 ` Willy Tarreau
2021-10-12 20:29 ` Borislav Petkov
2021-10-12 21:51 ` Borislav Petkov
2021-10-12 22:23 ` Ammar Faizi
2021-10-13 3:01 ` Willy Tarreau
2021-10-13 3:32 ` Ammar Faizi
2021-10-13 3:34 ` Ammar Faizi [this message]
2021-10-13 3:37 ` Ammar Faizi
2021-10-13 12:43 ` Borislav Petkov
2021-10-13 12:51 ` Willy Tarreau
2021-10-13 13:06 ` Borislav Petkov
2021-10-13 14:07 ` Willy Tarreau
2021-10-13 14:20 ` Borislav Petkov
2021-10-13 14:24 ` Willy Tarreau
2021-10-13 16:24 ` Michael Matz
2021-10-13 16:30 ` Willy Tarreau
2021-10-13 16:51 ` Andy Lutomirski
2021-10-13 16:52 ` Borislav Petkov
2021-10-14 8:44 ` Ammar Faizi
2021-10-14 12:44 ` Michael Matz
2021-10-14 14:31 ` Borislav Petkov
2021-10-19 9:06 ` David Laight
2021-10-23 20:40 ` H. Peter Anvin
2021-10-12 21:21 ` David Laight
2021-10-12 23:02 ` Subject: " Ammar Faizi
2021-10-13 9:03 ` [PATCH v2] " Ammar Faizi
2021-10-15 8:25 ` [PATCH 0/2] Fix clobber list and startup code bug Ammar Faizi
2021-10-15 8:25 ` [PATCH 1/2] tools/nolibc: x86: Remove `r8`, `r9` and `r10` from the clobber list Ammar Faizi
2021-10-18 5:52 ` Willy Tarreau
2021-10-15 8:25 ` [PATCH 2/2] tools/nolibc: x86-64: Fix startup code bug Ammar Faizi
2021-10-15 8:57 ` Ammar Faizi
2021-10-15 9:26 ` Bedirhan KURT
2021-10-15 9:58 ` Ammar Faizi
2021-10-15 9:41 ` Louvian Lyndal
2021-10-18 4:58 ` Willy Tarreau
2021-10-18 6:53 ` Ammar Faizi
2021-10-23 13:27 ` Ammar Faizi
2021-10-23 13:43 ` Willy Tarreau
2021-10-24 2:11 ` [PATCHSET v2 0/2] tools/nolibc: Fix startup code bug and small improvement Ammar Faizi
2021-10-24 2:11 ` [PATCH 1/2] tools/nolibc: x86-64: Fix startup code bug Ammar Faizi
2021-10-24 2:11 ` [PATCH 2/2] tools/nolibc: x86-64: Use `mov $60,%eax` instead of `mov $60,%rax` Ammar Faizi
2021-10-24 11:41 ` [PATCHSET v2 0/2] tools/nolibc: Fix startup code bug and small improvement Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAGzmLMXhez2Vvw8+iuBiEe-XRc+vNn8jDww9=aWe=mNk1rHgzA@mail.gmail.com' \
--to=ammar.faizi@students.amikom.ac.id \
--cc=aou@eecs.berkeley.edu \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=tglx@linutronix.de \
--cc=w@1wt.eu \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).