From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759642AbdACQ4f (ORCPT ); Tue, 3 Jan 2017 11:56:35 -0500 Received: from mail-oi0-f65.google.com ([209.85.218.65]:36789 "EHLO mail-oi0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759509AbdACQ4M (ORCPT ); Tue, 3 Jan 2017 11:56:12 -0500 MIME-Version: 1.0 In-Reply-To: References: <20170102104141.5634-1-fernetmenta@kodi.tv> <20170102140534.GW31595@intel.com> From: Rainer Hochecker Date: Tue, 3 Jan 2017 17:56:10 +0100 Message-ID: Subject: Re: [PATCH] drm: add fourcc codes for 16bit R and GR To: =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= , Ben Widawsky , intel-gfx@lists.freedesktop.org, Daniel Vetter Cc: David Herrmann , "dri-devel@lists.freedesktop.org" , Rainer Hochecker , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v03Gw86s032039 On Mon, Jan 2, 2017 at 3:31 PM, Rainer Hochecker wrote: > > I chose GR16 because that matches with Mesa texture formats. Unfortunately > RG16 is already taken by DRM_FORMAT_RGB565 > So GR32 / RG32 might be better. All other codes in fourcc.h seem to sum up > all planes. > > (sorry, gmail included some html links on last attempt) > > On Mon, Jan 2, 2017 at 3:05 PM, Ville Syrjälä wrote: >> >> On Mon, Jan 02, 2017 at 01:23:23PM +0100, David Herrmann wrote: >> > Hi >> > >> > On Mon, Jan 2, 2017 at 11:41 AM, Rainer Hochecker wrote: >> > > From: Rainer Hochecker >> > > >> > > Add fourcc codes for 16bit planes. Required by mesa for >> > > eglCreateImageKHR to access P010 surfaces created by vaapi. >> > > >> > > Signed-off-by: Rainer Hochecker >> > > --- >> > > include/uapi/drm/drm_fourcc.h | 6 ++++++ >> > > 1 file changed, 6 insertions(+) >> > > >> > > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h >> > > index a5890bf..e6ab638 100644 >> > > --- a/include/uapi/drm/drm_fourcc.h >> > > +++ b/include/uapi/drm/drm_fourcc.h >> > > @@ -41,10 +41,16 @@ extern "C" { >> > > /* 8 bpp Red */ >> > > #define DRM_FORMAT_R8 fourcc_code('R', '8', ' ', ' ') /* [7:0] R */ >> > > >> > > +/* 16 bpp Red */ >> > > +#define DRM_FORMAT_R16 fourcc_code('R', '1', '6', ' ') /* [15:0] R */ >> > > + >> > > /* 16 bpp RG */ >> > > #define DRM_FORMAT_RG88 fourcc_code('R', 'G', '8', '8') /* [15:0] R:G 8:8 little endian */ >> > > #define DRM_FORMAT_GR88 fourcc_code('G', 'R', '8', '8') /* [15:0] G:R 8:8 little endian */ >> > > >> > > +/* 32 bpp GR */ >> > > +#define DRM_FORMAT_GR16 fourcc_code('G', 'R', '1', '6') /* [31:0] G:R 16:16 little endian */ >> > > + >> > >> > Shouldn't it be 'G', 'R', '3', '2'? >> >> The name should be _GR1616. Using GR16 for the fourcc seems OK to me >> since we can't fit in the full GR1616 in there. Althogh GR32 could work >> too I suppose. >> >> And what about RG16? >> >> > >> > Also, please put dri-devel on CC. >> > >> > Thanks >> > David >> > >> > > /* 8 bpp RGB */ >> > > #define DRM_FORMAT_RGB332 fourcc_code('R', 'G', 'B', '8') /* [7:0] R:G:B 3:3:2 */ >> > > #define DRM_FORMAT_BGR233 fourcc_code('B', 'G', 'R', '8') /* [7:0] B:G:R 2:3:3 */ >> > > -- >> > > 2.9.3 >> > > >> > _______________________________________________ >> > dri-devel mailing list >> > dri-devel@lists.freedesktop.org >> > https://lists.freedesktop.org/mailman/listinfo/dri-devel >> >> -- >> Ville Syrjälä >> Intel OTC > > Updated patch as suggested by Ville Syrjälä >>From 29e74ff96e0b7c7a11d1b4131891b83adde621c1 Mon Sep 17 00:00:00 2001 From: Rainer Hochecker Date: Mon, 2 Jan 2017 11:25:18 +0100 Subject: [PATCH] drm: add fourcc codes for 16bit R and GR Signed-off-by: Rainer Hochecker --- include/uapi/drm/drm_fourcc.h | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h index a5890bf..f1ef9cb 100644 --- a/include/uapi/drm/drm_fourcc.h +++ b/include/uapi/drm/drm_fourcc.h @@ -41,10 +41,17 @@ extern "C" { /* 8 bpp Red */ #define DRM_FORMAT_R8 fourcc_code('R', '8', ' ', ' ') /* [7:0] R */ +/* 16 bpp Red */ +#define DRM_FORMAT_R16 fourcc_code('R', '1', '6', ' ') /* [15:0] R */ + /* 16 bpp RG */ #define DRM_FORMAT_RG88 fourcc_code('R', 'G', '8', '8') /* [15:0] R:G 8:8 little endian */ #define DRM_FORMAT_GR88 fourcc_code('G', 'R', '8', '8') /* [15:0] G:R 8:8 little endian */ +/* 32 bpp GR */ +#define DRM_FORMAT_RG32 fourcc_code('R', 'G', '3', '2') /* [31:0] G:R 16:16 little endian */ +#define DRM_FORMAT_GR32 fourcc_code('G', 'R', '3', '2') /* [31:0] G:R 16:16 little endian */ + /* 8 bpp RGB */ #define DRM_FORMAT_RGB332 fourcc_code('R', 'G', 'B', '8') /* [7:0] R:G:B 3:3:2 */ #define DRM_FORMAT_BGR233 fourcc_code('B', 'G', 'R', '8') /* [7:0] B:G:R 2:3:3 */ -- 2.9.3