From: Marcos Souza <marcos.souza.org@gmail.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: linux-kernel@vger.kernel.org,
Mauro Carvalho Chehab <mchehab@infradead.org>,
Huang Shijie <shijie8@gmail.com>,
Kang Yong <kangyong@telegent.com>,
Zhang Xiaobing <xbzhang@telegent.com>,
linux-media@vger.kernel.org
Subject: Re: [PATCH 06/12] drivers: media: video: tlg2300: pd-video.c: Include version.h header
Date: Thu, 19 Apr 2012 16:46:37 -0300 [thread overview]
Message-ID: <CAH0vN5LoFoCh0f1L01FHmSwBEq+_0RjBVPgmH48MM=FGM=djYg@mail.gmail.com> (raw)
In-Reply-To: <4F9069F2.8020201@redhat.com>
Em 19 de abril de 2012 16:39, Mauro Carvalho Chehab
<mchehab@redhat.com> escreveu:
> Em 18-04-2012 01:30, Marcos Paulo de Souza escreveu:
>> The output of "make versioncheck" told us that:
>>
>> drivers/media/video/tlg2300/pd-video.c: 1669: need linux/version.h
>>
>> If we take a look at the code, we can see that this file uses the macro
>> KERNEL_VERSION. So, we need this include.
>
> Nack. The right fix here is just the opposite: to remove the KERNEL_VERSION()
> call. The V4L2 core now fills it automatically, so drivers shouldn't touch on
> cap->version anymore. See the enclosed patch.
>
>>
>> Cc: Mauro Carvalho Chehab <mchehab@infradead.org>
>> Cc: Huang Shijie <shijie8@gmail.com>
>> Cc: Kang Yong <kangyong@telegent.com>
>> Cc: Zhang Xiaobing <xbzhang@telegent.com>
>> Cc: <linux-media@vger.kernel.org>
>> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
>> ---
>> drivers/media/video/tlg2300/pd-video.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/media/video/tlg2300/pd-video.c b/drivers/media/video/tlg2300/pd-video.c
>> index a794ae6..069db9a 100644
>> --- a/drivers/media/video/tlg2300/pd-video.c
>> +++ b/drivers/media/video/tlg2300/pd-video.c
>> @@ -5,6 +5,7 @@
>> #include <linux/mm.h>
>> #include <linux/sched.h>
>> #include <linux/slab.h>
>> +#include <linux/version.h>
>>
>> #include <media/v4l2-ioctl.h>
>> #include <media/v4l2-dev.h>
>
> commit f8bf305b7103857708cd22b504a70ea4a08022fc
> Author: Mauro Carvalho Chehab <mchehab@redhat.com>
> Date: Thu Apr 19 16:35:27 2012 -0300
>
> tlg2300: Remove usage of KERNEL_VERSION()
>
> As reported by Marcos:
>
> On 04-18-2012 01:30, Marcos Paulo de Souza wrote:
> > The output of "make versioncheck" told us that:
> >
> > drivers/media/video/tlg2300/pd-video.c: 1669: need linux/version.h
> >
> > If we take a look at the code, we can see that this file uses the macro
> > KERNEL_VERSION.
>
> The V4L2 core now fills it automatically, so drivers shouldn't touch on
> cap->version anymore.
>
> Reported by: Marcos Paulo de Souza <marcos.souza.org@gmail.com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>
> diff --git a/drivers/media/video/tlg2300/pd-video.c b/drivers/media/video/tlg2300/pd-video.c
> index a794ae6..bfbf9e5 100644
> --- a/drivers/media/video/tlg2300/pd-video.c
> +++ b/drivers/media/video/tlg2300/pd-video.c
> @@ -150,7 +150,6 @@ static int vidioc_querycap(struct file *file, void *fh,
> strcpy(cap->driver, "tele-video");
> strcpy(cap->card, "Telegent Poseidon");
> usb_make_path(p->udev, cap->bus_info, sizeof(cap->bus_info));
> - cap->version = KERNEL_VERSION(0, 0, 1);
> cap->capabilities = V4L2_CAP_VIDEO_CAPTURE | V4L2_CAP_TUNER |
> V4L2_CAP_AUDIO | V4L2_CAP_STREAMING |
> V4L2_CAP_READWRITE | V4L2_CAP_VBI_CAPTURE;
Better yet :)
Thanks for the feedback Mauro!
--
Att,
Marcos Paulo de Souza
Acadêmico de Ciencia da Computação - FURB - SC
"Uma vida sem desafios é uma vida sem razão"
"A life without challenges, is a non reason life"
next prev parent reply other threads:[~2012-04-19 19:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-18 4:30 [PATCH 00/12] Fix use of version.h Marcos Paulo de Souza
2012-04-18 4:30 ` [PATCH 01/12] drivers: block: mtip32xx: mtip32xx.h: Remove unnneeded include " Marcos Paulo de Souza
2012-04-18 4:30 ` [PATCH 02/12] drivers: gpu: drm: gma500: mdfld_dsi_output.h: Remove not unneeded " Marcos Paulo de Souza
2012-04-18 4:30 ` [PATCH 03/12] drivers: media: dvb: ddbridge: ddbridge-code: Remove " Marcos Paulo de Souza
2012-04-18 4:30 ` [PATCH 04/12] drivers: media: radio: radio-keene.c: " Marcos Paulo de Souza
2012-04-18 4:30 ` [PATCH 05/12] drivers: media: video: adp1653.c: " Marcos Paulo de Souza
2012-04-18 4:30 ` [PATCH 06/12] drivers: media: video: tlg2300: pd-video.c: Include version.h header Marcos Paulo de Souza
2012-04-19 19:39 ` Mauro Carvalho Chehab
2012-04-19 19:46 ` Marcos Souza [this message]
2012-04-20 2:14 ` Huang Shijie
2012-04-18 4:30 ` [PATCH 07/12] drivers: media: video: tm6000: tm6000.h: " Marcos Paulo de Souza
2012-04-19 19:48 ` Mauro Carvalho Chehab
2012-04-18 4:30 ` [PATCH 08/12] drivers: staging: media: as102: as102fe.c: Remove include of version.h Marcos Paulo de Souza
2012-04-18 4:30 ` [PATCH 09/12] drivers: staging: media: as102: as102_usb_drv.h: " Marcos Paulo de Souza
2012-04-18 4:30 ` [PATCH 10/12] drivers: staging: media: easycap: easycap_ioctl: Include version.h header Marcos Paulo de Souza
2012-04-18 4:30 ` [PATCH 11/12] drivers: staging: rtl8172: Remove unneeded include of version.h Marcos Paulo de Souza
2012-04-18 21:09 ` Larry Finger
2012-04-18 4:30 ` [PATCH 12/12] drivers: staging: vme: devices: Remove unneeded include version.h Marcos Paulo de Souza
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH0vN5LoFoCh0f1L01FHmSwBEq+_0RjBVPgmH48MM=FGM=djYg@mail.gmail.com' \
--to=marcos.souza.org@gmail.com \
--cc=kangyong@telegent.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mchehab@redhat.com \
--cc=shijie8@gmail.com \
--cc=xbzhang@telegent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).