From: xiang xiao <xiaoxiang781216@gmail.com>
To: "Enrico Weigelt, metux IT consult" <lkml@metux.net>
Cc: Arnaud Pouliquen <arnaud.pouliquen@st.com>,
Fabien Dessenne <fabien.dessenne@st.com>,
Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
linux-kernel@vger.kernel.org, linux-remoteproc@vger.kernel.org,
Benjamin Gaignard <benjamin.gaignard@st.com>
Subject: Re: [PATCH 2/2] tty: add rpmsg driver
Date: Mon, 15 Apr 2019 21:50:54 +0800 [thread overview]
Message-ID: <CAH2Cfb-FHAQQcxOfvmD5VYxd6vKK1iCqN2oW5YLr80tCtCx=xQ@mail.gmail.com> (raw)
In-Reply-To: <0c1d34df-7aeb-648b-b118-cf608e6ba636@metux.net>
On Mon, Apr 15, 2019 at 9:14 PM Enrico Weigelt, metux IT consult
<lkml@metux.net> wrote:
>
> On 12.04.19 18:00, Arnaud Pouliquen wrote:
>
> Hi folks,
>
> <snip>
>
> Haven't followed the whole thread, but I've got the impression that the
> device is emulating an uart - if that's the case wouldn't it be better
> to implement a serial driver, instead of tty directly (which IMHO should
> make it also usable for serbus-based devices) ?
It's more natural to implement rpmsg uart on top of tty core instead
of serial layer, since:
1.Serial layer model the hardware which can just send the data one by one
2.But rpmsg could send a buffer(max 512B) in one packet
On the other hand, it's very easy to support serbus by replace
tty_port_register_device_attr to tty_port_register_device_attr_serdev.
>
>
> --mtx
>
> --
> Enrico Weigelt, metux IT consult
> Free software and Linux embedded engineering
> info@metux.net -- +49-151-27565287
prev parent reply other threads:[~2019-04-15 13:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 15:47 [PATCH 0/2] TTY: add rpmsg tty driver Fabien Dessenne
2019-03-21 15:47 ` [PATCH 1/2] rpmsg: core: add possibility to get message payload length Fabien Dessenne
2019-03-21 15:47 ` [PATCH 2/2] tty: add rpmsg driver Fabien Dessenne
2019-04-03 8:44 ` Johan Hovold
2019-04-05 12:50 ` Fabien DESSENNE
2019-04-03 12:47 ` xiang xiao
2019-04-04 16:14 ` Arnaud Pouliquen
2019-04-05 10:12 ` xiang xiao
2019-04-05 12:33 ` Arnaud Pouliquen
2019-04-05 14:03 ` xiang xiao
2019-04-05 16:08 ` Arnaud Pouliquen
2019-04-06 7:56 ` xiang xiao
2019-04-08 12:05 ` Arnaud Pouliquen
2019-04-08 13:29 ` xiang xiao
2019-04-09 7:28 ` Arnaud Pouliquen
2019-04-09 10:14 ` xiang xiao
2019-04-12 16:00 ` Arnaud Pouliquen
2019-04-15 13:14 ` Enrico Weigelt, metux IT consult
2019-04-15 13:50 ` xiang xiao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH2Cfb-FHAQQcxOfvmD5VYxd6vKK1iCqN2oW5YLr80tCtCx=xQ@mail.gmail.com' \
--to=xiaoxiang781216@gmail.com \
--cc=arnaud.pouliquen@st.com \
--cc=benjamin.gaignard@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=fabien.dessenne@st.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=lkml@metux.net \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).