From: Steve French <smfrench@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Kent Overstreet <kent.overstreet@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Steve French <sfrench@samba.org>,
CIFS <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH 1/2] cifs: convert to add_to_page_cache()
Date: Tue, 20 Oct 2020 12:08:36 -0500 [thread overview]
Message-ID: <CAH2r5msRkzeCQTQTvP9uNSgobVO86S+O76fw=7-kkihXFF+-2A@mail.gmail.com> (raw)
In-Reply-To: <20201020075813.GA18793@infradead.org>
Other than the unnecessary split line which Christoph pointed out, looks fine.
You can add my Reviewed--by: Steve French <stfrench@microsoft.com>
On Tue, Oct 20, 2020 at 5:10 AM Christoph Hellwig <hch@infradead.org> wrote:
>
> > + rc = add_to_page_cache(page, mapping,
> > + page->index, gfp);
>
> This trivially fits onto a single line.
--
Thanks,
Steve
prev parent reply other threads:[~2020-10-20 17:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-19 18:59 [PATCH 1/2] cifs: convert to add_to_page_cache() Kent Overstreet
2020-10-19 18:59 ` [PATCH 2/2] fs: kill add_to_page_cache_locked() Kent Overstreet
2020-10-19 19:12 ` Matthew Wilcox
2020-10-21 9:24 ` [fs] 8e602a0a70: kernel_BUG_at_mm/filemap.c kernel test robot
2020-10-20 7:58 ` [PATCH 1/2] cifs: convert to add_to_page_cache() Christoph Hellwig
2020-10-20 17:08 ` Steve French [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH2r5msRkzeCQTQTvP9uNSgobVO86S+O76fw=7-kkihXFF+-2A@mail.gmail.com' \
--to=smfrench@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=kent.overstreet@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).