From: Steve French <smfrench@gmail.com>
To: Colin Ian King <colin.king@canonical.com>
Cc: "Aurélien Aptel" <aaptel@suse.com>,
"Dan Carpenter" <dan.carpenter@oracle.com>,
samba-technical <samba-technical@lists.samba.org>,
"Steve French" <sfrench@samba.org>,
kernel-janitors <kernel-janitors@vger.kernel.org>,
CIFS <linux-cifs@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] cifs: remove redundant assignment to variable rc
Date: Thu, 1 Aug 2019 12:00:37 -0500 [thread overview]
Message-ID: <CAH2r5msukKuhEcbpBfXOrwFEA=fyXQKSL+hDwdOFYX7DNLe8TQ@mail.gmail.com> (raw)
In-Reply-To: <2f562159-8118-f4a5-9e00-c82cf0841fd5@canonical.com>
merged into cifs-2.6.git for-next
On Wed, Jul 31, 2019 at 10:54 AM Colin Ian King
<colin.king@canonical.com> wrote:
>
> On 31/07/2019 16:34, Aurélien Aptel wrote:
> > "Dan Carpenter" <dan.carpenter@oracle.com> writes:
> >> You're just turning off GCC's static analysis (and introducing false
> >> positives) when you do that. We have seen bugs caused by this and never
> >> seen any bugs prevented by this style.
> >
> > You've never seen bugs prevented by initializing uninitialized
> > variables? Code can change overtime and I don't think coverity is
> > checked as often as it could be, meaning the var could end up being used
> > while uninitialized in the future.
>
> gcc/clang should pick up uninitialized vars at compile time. also I run
> coverity daily on linux-next.
>
> Colin
>
> >
> > Anyway I won't die on this hill, merge this if you prefer.
> >
> > Cheers,
> >
>
--
Thanks,
Steve
next prev parent reply other threads:[~2019-08-01 17:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 9:05 Colin King
2019-07-31 10:09 ` Aurélien Aptel
2019-07-31 12:28 ` Dan Carpenter
2019-07-31 15:34 ` Aurélien Aptel
2019-07-31 15:54 ` Colin Ian King
2019-08-01 17:00 ` Steve French [this message]
2019-08-01 8:03 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH2r5msukKuhEcbpBfXOrwFEA=fyXQKSL+hDwdOFYX7DNLe8TQ@mail.gmail.com' \
--to=smfrench@gmail.com \
--cc=aaptel@suse.com \
--cc=colin.king@canonical.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
--subject='Re: [PATCH] cifs: remove redundant assignment to variable rc' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).