From: Steve French <smfrench@gmail.com>
To: Andrzej Hajda <a.hajda@samsung.com>
Cc: Steve French <sfrench@samba.org>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
Marek Szyprowski <m.szyprowski@samsung.com>,
LKML <linux-kernel@vger.kernel.org>,
"linux-cifs@vger.kernel.org" <linux-cifs@vger.kernel.org>
Subject: Re: [PATCH 20/31] fs/cifs: use kmemdup rather than duplicating its implementation
Date: Thu, 17 Sep 2015 00:00:18 -0500 [thread overview]
Message-ID: <CAH2r5mua5sqEuD38y+q_3eM_EDBMjWNpWyCzBcWu5OofELXfQw@mail.gmail.com> (raw)
In-Reply-To: <1438934377-4922-21-git-send-email-a.hajda@samsung.com>
loooks reasonable to me - isn't this part of a larger patch series
though? Did you want it merged distinctly into cifs-2.6.git?
On Fri, Aug 7, 2015 at 2:59 AM, Andrzej Hajda <a.hajda@samsung.com> wrote:
> The patch was generated using fixed coccinelle semantic patch
> scripts/coccinelle/api/memdup.cocci [1].
>
> [1]: http://permalink.gmane.org/gmane.linux.kernel/2014320
>
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> ---
> fs/cifs/smb2pdu.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/fs/cifs/smb2pdu.c b/fs/cifs/smb2pdu.c
> index 070fb2a..2d6b72f 100644
> --- a/fs/cifs/smb2pdu.c
> +++ b/fs/cifs/smb2pdu.c
> @@ -1394,14 +1394,13 @@ SMB2_ioctl(const unsigned int xid, struct cifs_tcon *tcon, u64 persistent_fid,
> goto ioctl_exit;
> }
>
> - *out_data = kmalloc(*plen, GFP_KERNEL);
> + *out_data = kmemdup(rsp->hdr.ProtocolId + le32_to_cpu(rsp->OutputOffset),
> + *plen, GFP_KERNEL);
> if (*out_data == NULL) {
> rc = -ENOMEM;
> goto ioctl_exit;
> }
>
> - memcpy(*out_data, rsp->hdr.ProtocolId + le32_to_cpu(rsp->OutputOffset),
> - *plen);
> ioctl_exit:
> free_rsp_buf(resp_buftype, rsp);
> return rc;
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Thanks,
Steve
next prev parent reply other threads:[~2015-09-17 5:00 UTC|newest]
Thread overview: 76+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-07 7:59 [PATCH 00/31] use kmemdup rather than duplicating its implementation Andrzej Hajda
2015-08-07 7:59 ` [PATCH 01/31] arch/arm/mach-lpc32xx: " Andrzej Hajda
2015-09-16 9:52 ` Andrzej Hajda
2015-09-16 10:06 ` Arnd Bergmann
2015-08-07 7:59 ` [PATCH 02/31] arch/ia64/tioce: " Andrzej Hajda
2015-09-16 9:53 ` Andrzej Hajda
2015-08-07 7:59 ` [PATCH 03/31] arch/m68k/bootinfo: " Andrzej Hajda
2015-08-07 10:23 ` Geert Uytterhoeven
2015-08-07 7:59 ` [PATCH 04/31] arch/mips/bcm47xx: " Andrzej Hajda
2015-08-09 20:14 ` Hauke Mehrtens
2015-08-07 7:59 ` [PATCH 05/31] arch/powerpc/nvram: " Andrzej Hajda
2015-08-07 19:46 ` Nathan Fontenot
2015-08-19 23:14 ` [05/31] " Michael Ellerman
2015-08-07 7:59 ` [PATCH 06/31] arch/powerpc/pseries: " Andrzej Hajda
2015-08-07 19:46 ` Nathan Fontenot
2015-08-19 23:14 ` [06/31] " Michael Ellerman
2015-08-07 7:59 ` [PATCH 07/31] arch/x86/microcode: " Andrzej Hajda
2015-08-07 16:30 ` Borislav Petkov
2015-08-07 7:59 ` [PATCH 08/31] arch/x86/intel-mid: " Andrzej Hajda
2015-09-16 9:54 ` Andrzej Hajda
2015-09-17 21:42 ` [tip:x86/platform] arch/x86/intel-mid: Use " tip-bot for Andrzej Hajda
2015-08-07 7:59 ` [PATCH 09/31] crypto: use " Andrzej Hajda
2015-08-07 8:05 ` Herbert Xu
2015-08-07 7:59 ` [PATCH 10/31] clk/mmp: " Andrzej Hajda
2015-08-07 22:17 ` Stephen Boyd
2015-08-07 7:59 ` [PATCH 11/31] cpufreq/sfi: " Andrzej Hajda
2015-08-07 8:58 ` Viresh Kumar
2015-08-07 7:59 ` [PATCH 12/31] drm/amdgpu: " Andrzej Hajda
2015-09-16 9:56 ` Andrzej Hajda
2015-09-16 16:21 ` Christian König
2015-09-21 21:36 ` Alex Deucher
2015-08-07 7:59 ` [PATCH 13/31] memstick: " Andrzej Hajda
2015-09-16 9:57 ` Andrzej Hajda
2015-08-07 7:59 ` [PATCH 14/31] message/fusion: " Andrzej Hajda
2015-09-16 10:01 ` Andrzej Hajda
2015-08-07 7:59 ` [PATCH 15/31] misc/vmw_vmci: " Andrzej Hajda
2015-09-16 10:01 ` Andrzej Hajda
2015-08-07 7:59 ` [PATCH 16/31] net/cavium/liquidio: " Andrzej Hajda
2015-09-16 10:02 ` Andrzej Hajda
2015-08-07 7:59 ` [PATCH 17/31] scsi/aacraid: " Andrzej Hajda
2015-09-16 10:02 ` Andrzej Hajda
2015-08-07 7:59 ` [PATCH 18/31] scsi/aic7xxx: " Andrzej Hajda
2015-09-16 10:02 ` Andrzej Hajda
2015-08-07 7:59 ` [PATCH 19/31] staging/lustre: " Andrzej Hajda
2015-08-07 7:59 ` [PATCH 20/31] fs/cifs: " Andrzej Hajda
2015-09-16 10:03 ` Andrzej Hajda
2015-09-17 5:00 ` Steve French [this message]
2015-08-07 7:59 ` [PATCH 21/31] fs/dlm: " Andrzej Hajda
2015-09-16 10:03 ` Andrzej Hajda
2015-08-07 7:59 ` [PATCH 22/31] fs/ntfs: " Andrzej Hajda
2015-09-16 10:04 ` Andrzej Hajda
2015-09-23 10:21 ` Anton Altaparmakov
2015-09-24 8:34 ` Andrzej Hajda
[not found] ` <fc4b273eb58a4c33b4e80270a7fd06b1@nebula-exfe-01.nebula.local>
2015-09-24 9:20 ` Anton Altaparmakov
2015-09-24 9:22 ` Anton Altaparmakov
2015-08-07 7:59 ` [PATCH 23/31] fs/ocfs2: " Andrzej Hajda
2015-09-16 10:04 ` Andrzej Hajda
2015-08-07 7:59 ` [PATCH 24/31] fs/omfs: " Andrzej Hajda
2015-08-07 12:22 ` Bob Copeland
2015-09-16 10:05 ` Andrzej Hajda
2015-08-07 7:59 ` [PATCH 25/31] fs/ubifs: " Andrzej Hajda
2015-08-08 9:12 ` Richard Weinberger
2015-08-10 8:16 ` Artem Bityutskiy
2015-08-07 7:59 ` [PATCH 26/31] net/sched: " Andrzej Hajda
2015-08-07 10:35 ` Daniel Borkmann
2015-08-07 7:59 ` [PATCH 27/31] net/tipc: " Andrzej Hajda
2015-09-16 10:07 ` Andrzej Hajda
2015-09-17 9:58 ` Jon Maloy
2015-09-17 1:19 ` Ying Xue
2015-08-07 7:59 ` [PATCH 28/31] net/xfrm: " Andrzej Hajda
2015-08-12 10:25 ` Steffen Klassert
2015-08-07 7:59 ` [PATCH 29/31] sound/oxfw: " Andrzej Hajda
2015-08-07 12:52 ` [alsa-devel] " Takashi Iwai
2015-08-07 7:59 ` [PATCH 30/31] sound/atom: " Andrzej Hajda
2015-08-07 12:29 ` Mark Brown
2015-08-07 7:59 ` [PATCH 31/31] sound/soc: " Andrzej Hajda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH2r5mua5sqEuD38y+q_3eM_EDBMjWNpWyCzBcWu5OofELXfQw@mail.gmail.com \
--to=smfrench@gmail.com \
--cc=a.hajda@samsung.com \
--cc=b.zolnierkie@samsung.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).