* [PATCH] cifs: use %16phN for formatting md5 sum
@ 2016-11-30 22:40 Rasmus Villemoes
2016-12-14 19:46 ` Pavel Shilovsky
2016-12-15 6:37 ` Steve French
0 siblings, 2 replies; 3+ messages in thread
From: Rasmus Villemoes @ 2016-11-30 22:40 UTC (permalink / raw)
To: Steve French; +Cc: Rasmus Villemoes, linux-cifs, samba-technical, linux-kernel
Passing a gazillion arguments takes a lot of code:
add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-253 (-253)
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
fs/cifs/link.c | 9 ++-------
1 file changed, 2 insertions(+), 7 deletions(-)
diff --git a/fs/cifs/link.c b/fs/cifs/link.c
index d031af8d3d4d..c4d996f78e1c 100644
--- a/fs/cifs/link.c
+++ b/fs/cifs/link.c
@@ -45,13 +45,8 @@
(CIFS_MF_SYMLINK_LINK_OFFSET + CIFS_MF_SYMLINK_LINK_MAXLEN)
#define CIFS_MF_SYMLINK_LEN_FORMAT "XSym\n%04u\n"
-#define CIFS_MF_SYMLINK_MD5_FORMAT \
- "%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x\n"
-#define CIFS_MF_SYMLINK_MD5_ARGS(md5_hash) \
- md5_hash[0], md5_hash[1], md5_hash[2], md5_hash[3], \
- md5_hash[4], md5_hash[5], md5_hash[6], md5_hash[7], \
- md5_hash[8], md5_hash[9], md5_hash[10], md5_hash[11],\
- md5_hash[12], md5_hash[13], md5_hash[14], md5_hash[15]
+#define CIFS_MF_SYMLINK_MD5_FORMAT "%16phN\n"
+#define CIFS_MF_SYMLINK_MD5_ARGS(md5_hash) md5_hash
static int
symlink_hash(unsigned int link_len, const char *link_str, u8 *md5_hash)
--
2.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] cifs: use %16phN for formatting md5 sum
2016-11-30 22:40 [PATCH] cifs: use %16phN for formatting md5 sum Rasmus Villemoes
@ 2016-12-14 19:46 ` Pavel Shilovsky
2016-12-15 6:37 ` Steve French
1 sibling, 0 replies; 3+ messages in thread
From: Pavel Shilovsky @ 2016-12-14 19:46 UTC (permalink / raw)
To: Rasmus Villemoes
Cc: Steve French, linux-cifs, samba-technical, Kernel Mailing List
2016-11-30 14:40 GMT-08:00 Rasmus Villemoes <linux@rasmusvillemoes.dk>:
> Passing a gazillion arguments takes a lot of code:
>
> add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-253 (-253)
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> fs/cifs/link.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/fs/cifs/link.c b/fs/cifs/link.c
> index d031af8d3d4d..c4d996f78e1c 100644
> --- a/fs/cifs/link.c
> +++ b/fs/cifs/link.c
> @@ -45,13 +45,8 @@
> (CIFS_MF_SYMLINK_LINK_OFFSET + CIFS_MF_SYMLINK_LINK_MAXLEN)
>
> #define CIFS_MF_SYMLINK_LEN_FORMAT "XSym\n%04u\n"
> -#define CIFS_MF_SYMLINK_MD5_FORMAT \
> - "%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x\n"
> -#define CIFS_MF_SYMLINK_MD5_ARGS(md5_hash) \
> - md5_hash[0], md5_hash[1], md5_hash[2], md5_hash[3], \
> - md5_hash[4], md5_hash[5], md5_hash[6], md5_hash[7], \
> - md5_hash[8], md5_hash[9], md5_hash[10], md5_hash[11],\
> - md5_hash[12], md5_hash[13], md5_hash[14], md5_hash[15]
> +#define CIFS_MF_SYMLINK_MD5_FORMAT "%16phN\n"
> +#define CIFS_MF_SYMLINK_MD5_ARGS(md5_hash) md5_hash
>
> static int
> symlink_hash(unsigned int link_len, const char *link_str, u8 *md5_hash)
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
--
Best regards,
Pavel Shilovsky
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] cifs: use %16phN for formatting md5 sum
2016-11-30 22:40 [PATCH] cifs: use %16phN for formatting md5 sum Rasmus Villemoes
2016-12-14 19:46 ` Pavel Shilovsky
@ 2016-12-15 6:37 ` Steve French
1 sibling, 0 replies; 3+ messages in thread
From: Steve French @ 2016-12-15 6:37 UTC (permalink / raw)
To: Rasmus Villemoes; +Cc: Steve French, linux-cifs, samba-technical, LKML
merged into cifs-2.6.git for-next
On Wed, Nov 30, 2016 at 4:40 PM, Rasmus Villemoes
<linux@rasmusvillemoes.dk> wrote:
> Passing a gazillion arguments takes a lot of code:
>
> add/remove: 0/0 grow/shrink: 0/2 up/down: 0/-253 (-253)
>
> Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
> ---
> fs/cifs/link.c | 9 ++-------
> 1 file changed, 2 insertions(+), 7 deletions(-)
>
> diff --git a/fs/cifs/link.c b/fs/cifs/link.c
> index d031af8d3d4d..c4d996f78e1c 100644
> --- a/fs/cifs/link.c
> +++ b/fs/cifs/link.c
> @@ -45,13 +45,8 @@
> (CIFS_MF_SYMLINK_LINK_OFFSET + CIFS_MF_SYMLINK_LINK_MAXLEN)
>
> #define CIFS_MF_SYMLINK_LEN_FORMAT "XSym\n%04u\n"
> -#define CIFS_MF_SYMLINK_MD5_FORMAT \
> - "%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x%02x\n"
> -#define CIFS_MF_SYMLINK_MD5_ARGS(md5_hash) \
> - md5_hash[0], md5_hash[1], md5_hash[2], md5_hash[3], \
> - md5_hash[4], md5_hash[5], md5_hash[6], md5_hash[7], \
> - md5_hash[8], md5_hash[9], md5_hash[10], md5_hash[11],\
> - md5_hash[12], md5_hash[13], md5_hash[14], md5_hash[15]
> +#define CIFS_MF_SYMLINK_MD5_FORMAT "%16phN\n"
> +#define CIFS_MF_SYMLINK_MD5_ARGS(md5_hash) md5_hash
>
> static int
> symlink_hash(unsigned int link_len, const char *link_str, u8 *md5_hash)
> --
> 2.1.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-cifs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Thanks,
Steve
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-12-15 6:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-11-30 22:40 [PATCH] cifs: use %16phN for formatting md5 sum Rasmus Villemoes
2016-12-14 19:46 ` Pavel Shilovsky
2016-12-15 6:37 ` Steve French
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).