From: Steve French <smfrench@gmail.com>
To: Long Li <longli@microsoft.com>
Cc: Steve French <sfrench@samba.org>,
CIFS <linux-cifs@vger.kernel.org>,
samba-technical <samba-technical@lists.samba.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] cifs: Don't match port on SMBDirect transport
Date: Wed, 15 May 2019 22:00:05 -0500 [thread overview]
Message-ID: <CAH2r5mvuRaEJDVv6hXwWuegckvXjtTfbpkLGLXE8kb2h1s-xUg@mail.gmail.com> (raw)
In-Reply-To: <1557954545-17831-1-git-send-email-longli@linuxonhyperv.com>
merged into cifs-2.6.git for-next
On Wed, May 15, 2019 at 4:09 PM <longli@linuxonhyperv.com> wrote:
>
> From: Long Li <longli@microsoft.com>
>
> SMBDirect manages its own ports in the transport layer, there is no need to
> check the port to find a connection.
>
> Signed-off-by: Long Li <longli@microsoft.com>
> ---
> fs/cifs/connect.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
> index 0b3ac8b76d18..8c4121da624e 100644
> --- a/fs/cifs/connect.c
> +++ b/fs/cifs/connect.c
> @@ -2446,6 +2446,10 @@ match_port(struct TCP_Server_Info *server, struct sockaddr *addr)
> {
> __be16 port, *sport;
>
> + /* SMBDirect manages its own ports, don't match it here */
> + if (server->rdma)
> + return true;
> +
> switch (addr->sa_family) {
> case AF_INET:
> sport = &((struct sockaddr_in *) &server->dstaddr)->sin_port;
> --
> 2.17.1
>
--
Thanks,
Steve
prev parent reply other threads:[~2019-05-16 3:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-15 21:09 [PATCH 1/2] cifs: Don't match port on SMBDirect transport longli
2019-05-15 21:09 ` [PATCH 2/2] cifs: Allocate memory for all iovs in smb2_ioctl longli
2019-05-15 22:26 ` Pavel Shilovsky
2019-05-15 23:11 ` ronnie sahlberg
2019-05-16 2:58 ` Steve French
2019-05-16 3:00 ` Steve French [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAH2r5mvuRaEJDVv6hXwWuegckvXjtTfbpkLGLXE8kb2h1s-xUg@mail.gmail.com \
--to=smfrench@gmail.com \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=longli@microsoft.com \
--cc=samba-technical@lists.samba.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).