From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751585AbbCJHrv (ORCPT ); Tue, 10 Mar 2015 03:47:51 -0400 Received: from mail-wg0-f44.google.com ([74.125.82.44]:36064 "EHLO mail-wg0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751116AbbCJHrr (ORCPT ); Tue, 10 Mar 2015 03:47:47 -0400 MIME-Version: 1.0 In-Reply-To: <20150309230250.GA13266@ld-irv-0074> References: <1425418844-25177-1-git-send-email-fransklaver@gmail.com> <1425418844-25177-2-git-send-email-fransklaver@gmail.com> <20150309230250.GA13266@ld-irv-0074> Date: Tue, 10 Mar 2015 08:47:46 +0100 Message-ID: Subject: Re: [PATCH 01/60] mtd: core: tone down suggestion that dev.parent should be set From: Frans Klaver To: Brian Norris Cc: David Woodhouse , "linux-kernel@vger.kernel.org" , linux-mtd@lists.infradead.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 10, 2015 at 12:14 AM, Brian Norris wrote: > On Tue, Mar 03, 2015 at 10:39:45PM +0100, Frans Klaver wrote: >> add_mtd_device() has a comment suggesting that the caller should have >> set dev.parent. This is required to have the device show up in sysfs, > > What do you mean "have the device show up in sysfs"? AFAICT, this only > has bearing on whether the *parent* device shows up as a sysfs symlink > within the MTD device directory. i.e.: > > /sys/class/mtd/mtd*/device > > For instance, this sort of symlink: > > /sys/class/mtd/mtd0/device -> ../../../f03e2800.nand > > It might be good to clarify this in the commit message, since you make > the problem sound worse than (I think) it is. I do? That was definitely not my intention. I'll look into it. Thanks, Frans