linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: BVG Rao <venubyravarasu@gmail.com>
To: balbi@ti.com
Cc: Venu Byravarasu <vbyravarasu@nvidia.com>,
	gregkh@linuxfoundation.org, stern@rowland.harvard.edu,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	swarren@wwwdotorg.org
Subject: Re: [PATCH v2] usb: host: tegra: make use of PHY pointer of HCD
Date: Thu, 24 Jan 2013 21:28:32 +0530	[thread overview]
Message-ID: <CAH7OJZsL2akgaU5qQo=gykVAcFkYyCbP4f1WuBDePd5o788o4A@mail.gmail.com> (raw)
In-Reply-To: <20130124140504.GA2609@arwen.pp.htv.fi>

On Thu, Jan 24, 2013 at 7:35 PM, Felipe Balbi <balbi@ti.com> wrote:
> Hi,
>
> On Thu, Jan 24, 2013 at 03:57:03PM +0530, Venu Byravarasu wrote:
>> As pointer to PHY structure can be stored in struct usb_hcd
>> making use of it, to call Tegra PHY APIs.
>>
>> Call to usb_phy_shutdown() is moved up in tegra_ehci_remove(),
>> so that to avoid dereferencing of hcd after its freed up.
>>
>> Signed-off-by: Venu Byravarasu <vbyravarasu@nvidia.com>
>> ---
>> First version of patch can be found at
>> http://marc.info/?l=linux-kernel&m=135581479020213&w=2. As it was not
>> yet applied, sending v2 of the patch.
>>
>> delta from v1:
>> Modified all Tegra PHY APIs to use standard 'structu usb_phy *' as
>> their parameter instead of proprietary parameter of type 'struct tegra_usb_phy *'.
>
> I would like to see those tegra-specific functions vanish from the
> driver. Can that be done for v3.10 merge window ?

Deleting these functions may not be possible because of the way,
Tegra20 USB PHY and controllers are designed.
Hence I'm trying to remove tegra specific structure pointers as
function parameter
and use generic USB PHY structure pointers instead.

>
> --
> balbi

  reply	other threads:[~2013-01-24 15:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-24 10:27 [PATCH v2] usb: host: tegra: make use of PHY pointer of HCD Venu Byravarasu
2013-01-24 14:05 ` Felipe Balbi
2013-01-24 15:58   ` BVG Rao [this message]
2013-01-24 16:00     ` Felipe Balbi
2013-01-24 16:57   ` Stephen Warren
2013-01-24 17:10     ` Felipe Balbi
2013-01-24 22:05     ` Greg KH
2013-01-24 16:28 ` Alan Stern
2013-01-28 18:49 ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAH7OJZsL2akgaU5qQo=gykVAcFkYyCbP4f1WuBDePd5o788o4A@mail.gmail.com' \
    --to=venubyravarasu@gmail.com \
    --cc=balbi@ti.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stern@rowland.harvard.edu \
    --cc=swarren@wwwdotorg.org \
    --cc=vbyravarasu@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).