From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754422Ab2DRXiJ (ORCPT <rfc822;w@1wt.eu>);
	Wed, 18 Apr 2012 19:38:09 -0400
Received: from mail-iy0-f174.google.com ([209.85.210.174]:54275 "EHLO
	mail-iy0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1754294Ab2DRXiH convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 18 Apr 2012 19:38:07 -0400
MIME-Version: 1.0
In-Reply-To: <20120418214703.GA31606@kroah.com>
References: <1332492784-10526-1-git-send-email-myungjoo.ham@samsung.com>
	<1332492784-10526-2-git-send-email-myungjoo.ham@samsung.com>
	<20120418214703.GA31606@kroah.com>
Date: Thu, 19 Apr 2012 08:38:06 +0900
X-Google-Sender-Auth: _CPazjHRgyXnHZ6fPhtBNR1kZNw
Message-ID: <CAH9JG2VRas6LWCZSF3BFEsJvOS+6AeYMe_BQh3H18kh_=8CNqg@mail.gmail.com>
Subject: Re: [PATCH v7 1/6] Extcon (external connector): import Android's
 switch class and modify.
From: Kyungmin Park <kyungmin.park@samsung.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>, Arnd Bergmann <arnd@arndb.de>,
        LKML <linux-kernel@vger.kernel.org>, NeilBrown <neilb@suse.de>,
        Randy Dunlap <rdunlap@xenotime.net>,
        Mike Lockwood <lockwood@android.com>,
        =?ISO-8859-1?Q?Arve_Hj=F8nnevag?= <arve@android.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Morten CHRISTIANSEN <morten.christiansen@stericsson.com>,
        Mark Brown <broonie@opensource.wolfsonmicro.com>,
        John Stultz <john.stultz@linaro.org>,
        Joerg Roedel <joerg.roedel@amd.com>, myungjoo.ham@gmail.com,
        cw00.choi@samsung.com
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8BIT
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Greg,

Can you check the latest extcon at here?

http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/extcon

If any problem with it, please tell me again.

Thank you,
Kyungmin Park

On 4/19/12, Greg KH <gregkh@linuxfoundation.org> wrote:
> On Fri, Mar 23, 2012 at 05:52:58PM +0900, MyungJoo Ham wrote:
>> External connector class (extcon) is based on and an extension of
>> Android kernel's switch class located at linux/drivers/switch/.
>
> <snip>
>
> This patch breaks the build:
> drivers/extcon/extcon_class.c:79:6: error: redefinition of
> ‘extcon_set_state’
> include/linux/extcon.h:80:20: note: previous definition of
> ‘extcon_set_state’ was here
> drivers/extcon/extcon_class.c:170:5: error: redefinition of
> ‘extcon_dev_register’
> include/linux/extcon.h:67:19: note: previous definition of
> ‘extcon_dev_register’ was here
> drivers/extcon/extcon_class.c:214:6: error: redefinition of
> ‘extcon_dev_unregister’
> include/linux/extcon.h:73:20: note: previous definition of
> ‘extcon_dev_unregister’ was here
>
> So it obviously can't be applied to the tree :(
>
> Did you test it?
>
> Care to redo this series and send it again?
>
> greg k-h
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>