From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755490Ab3BWJVP (ORCPT ); Sat, 23 Feb 2013 04:21:15 -0500 Received: from mail-qa0-f49.google.com ([209.85.216.49]:53729 "EHLO mail-qa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755073Ab3BWJVK (ORCPT ); Sat, 23 Feb 2013 04:21:10 -0500 MIME-Version: 1.0 In-Reply-To: References: <1360771110-9490-1-git-send-email-christian.gmeiner@gmail.com> From: Christian Gmeiner Date: Sat, 23 Feb 2013 10:20:48 +0100 Message-ID: Subject: Re: [PATCH] leds-ot200: Fix misbehavior caused by wrong bit masks To: Bryan Wu Cc: akpm , "linux-next@vger.kernel.org" , LKML , stable@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2013/2/15 Bryan Wu : > On Wed, Feb 13, 2013 at 7:58 AM, Christian Gmeiner > wrote: >> During the development of this driver an in-house register >> documentation was used. The last weeks some integration tests >> were done and this problem was found. It turned out that >> the released register documentation is wrong. >> >> The fix is very simple: shift all masks by one. >> >> Our customers can control LEDs from userspace via Java, >> C++ or what every. They have running/working applications where >> they want to control led_3 but led_2 get's used. >> I got a bug report in our in-house bug tracker so it would be >> great to fix this upstream. >> >> Signed-off-by: Christian Gmeiner > > Thanks, Christian. > > And Andrew, are you going to take care of this patch? Or I will merge this. > Whats the current state of the patch? Hope we can get it into 3.9 :) -- Christian Gmeiner, MSc