From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752181AbcGBN0X (ORCPT ); Sat, 2 Jul 2016 09:26:23 -0400 Received: from mail-lf0-f65.google.com ([209.85.215.65]:36260 "EHLO mail-lf0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751373AbcGBN0W (ORCPT ); Sat, 2 Jul 2016 09:26:22 -0400 MIME-Version: 1.0 In-Reply-To: <20160701150134.GR6247@sirena.org.uk> References: <20160621185100.GD28202@sirena.org.uk> <1467376378-21535-1-git-send-email-christian.gmeiner@gmail.com> <20160701150134.GR6247@sirena.org.uk> From: Christian Gmeiner Date: Sat, 2 Jul 2016 15:26:00 +0200 Message-ID: Subject: Re: [PATCH] spi: imx: wait_for_completion_timeout(..) for PIO transfers To: Mark Brown Cc: linux-spi@vger.kernel.org, LKML Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Mark, 2016-07-01 17:01 GMT+02:00 Mark Brown : > On Fri, Jul 01, 2016 at 02:32:58PM +0200, Christian Gmeiner wrote: >> In some rare cases I see the following 'task blocked' information. It >> looks like the PIO transfer has some problems and never succeeds. Make >> use of wait_for_completion_timeout(..) to detect this case and >> return -ETIMEDOUT. >> >> v2: remove backtrace from commit message > > Please do not submit new versions of already applied patches, please > submit incremental updates to the existing code. Modifying existing > commits creates problems for other users building on top of those > commits so it's best practice to only change pubished git commits if > absolutely essential. > I was not aware that the patch was applied already that is why I send out a v2. I normally do not follow any subsystem or linux-next tree to see if a patch of me got applied or not. Normally I get an Acked-by: or Signed-off-by: reply to know about the state of the patch. In case of this patch I got a separate main 'Applied "spi: imx: wait_for_completion_timeout(..) for PIO transfers" to the spi tree' which did not get any attention from me as it was hidden due some gmail filter-to-label rules. In the end I am happy that this patch got applied. Thanks for that and sorry that I have stolen to much time. > If you're including an inter-version changelog please keep it after the > --- as covered in SubmittingPatches. Will do the next time - sorry for that. greets -- Christian Gmeiner, MSc https://soundcloud.com/christian-gmeiner