From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756108Ab3ENHHQ (ORCPT ); Tue, 14 May 2013 03:07:16 -0400 Received: from mail-qa0-f51.google.com ([209.85.216.51]:41589 "EHLO mail-qa0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751034Ab3ENHHN (ORCPT ); Tue, 14 May 2013 03:07:13 -0400 MIME-Version: 1.0 In-Reply-To: References: <1360771110-9490-1-git-send-email-christian.gmeiner@gmail.com> From: Christian Gmeiner Date: Tue, 14 May 2013 09:06:52 +0200 Message-ID: Subject: Re: [PATCH] leds-ot200: Fix misbehavior caused by wrong bit masks To: Bryan Wu Cc: akpm , "linux-next@vger.kernel.org" , LKML , stable@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2013/5/12 Christian Gmeiner : > 2013/3/8 Christian Gmeiner : >> 2013/3/5 Bryan Wu : >>> On Sun, Mar 3, 2013 at 11:40 PM, Christian Gmeiner >>> wrote: >>>> ping >>>> -- >>>> Christian Gmeiner, MSc >>>> >>>> >>>> 2013/2/23 Christian Gmeiner : >>>>> 2013/2/15 Bryan Wu : >>>>>> On Wed, Feb 13, 2013 at 7:58 AM, Christian Gmeiner >>>>>> wrote: >>>>>>> During the development of this driver an in-house register >>>>>>> documentation was used. The last weeks some integration tests >>>>>>> were done and this problem was found. It turned out that >>>>>>> the released register documentation is wrong. >>>>>>> >>>>>>> The fix is very simple: shift all masks by one. >>>>>>> >>>>>>> Our customers can control LEDs from userspace via Java, >>>>>>> C++ or what every. They have running/working applications where >>>>>>> they want to control led_3 but led_2 get's used. >>>>>>> I got a bug report in our in-house bug tracker so it would be >>>>>>> great to fix this upstream. >>>>>>> >>>>>>> Signed-off-by: Christian Gmeiner >>>>>> >>>>>> Thanks, Christian. >>>>>> >>>>>> And Andrew, are you going to take care of this patch? Or I will merge this. >>>>>> >>>>> >>>>> Whats the current state of the patch? Hope we can get it into 3.9 :) >>>>> >>> >>> I think this patch is already in linux-next via Andrew's tree (commit >>> 023206171f235f93f26c314f76f5405a3077aaba). So it will be merged into >>> 3.10 I guess, but not 3.9. >>> >>> Or I can send out this patch to Linus as a fix and ask Andrew to drop >>> this from his tree. >>> >> >> I am fine with the current situation and 3.10 is fine too. >> > > 3.10-rc1 is out but my patch is missing. What happened? > > https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/log/?id=refs%2Ftags%2Fv3.10-rc1&qt=author&q=gmeiner > ping -- Christian Gmeiner, MSc