From: Bhupesh Sharma <bhupesh.sharma@linaro.org>
To: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, bhupesh.linux@gmail.com,
agross@kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-phy@lists.infradead.org,
robh+dt@kernel.org, Bjorn Andersson <bjorn.andersson@linaro.org>,
Vinod Koul <vkoul@kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: phy: qcom,qmp: Mark '#clock-cells' as a 'optional' property
Date: Fri, 25 Feb 2022 14:46:55 +0530 [thread overview]
Message-ID: <CAH=2NtxQBS=c0W0cpX5EdNi12PrqiKEuzyvEtF8WrVE6nsU_rg@mail.gmail.com> (raw)
In-Reply-To: <CAA8EJprRgsZRSXBQumveAn029j+w6xO8K2kZUO4rzZaefuYe7Q@mail.gmail.com>
Hi Dmitry,
Thanks for your review comments.
On Thu, 24 Feb 2022 at 20:22, Dmitry Baryshkov
<dmitry.baryshkov@linaro.org> wrote:
>
> On Thu, 24 Feb 2022 at 15:33, Bhupesh Sharma <bhupesh.sharma@linaro.org> wrote:
> >
> > Since '#clock-cells' is not a required property for several
> > QCoM boards supporting qmp-phy(s) (for e.g. sm8150, sm8250 or sm8350 SoC
> > based boards), mark it as an optional property instead.
>
> I believe the description is not correct. the clock-cells should not
> be used at all, so it should be removed from the root node.
Hmm.. 'clock-cells' is still used for describing qmp phy pcie nodes for certain
devices like 'msm8996.dtsi'. I am not sure if removing it would impact existing
dts files. But let me try cleaning them up in v2.
> Also we should describe phy@ properties.
Sure, I will add them in v2.
Regards,
Bhupesh
> >
> > This fixes the following '$ make dtbs_check' warning(s):
> >
> > sm8350-microsoft-surface-duo2.dt.yaml: phy@1d87000:
> > '#clock-cells' is a required property
> >
> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> > Cc: Vinod Koul <vkoul@kernel.org>
> > Cc: Rob Herring <robh+dt@kernel.org>
> > Signed-off-by: Bhupesh Sharma <bhupesh.sharma@linaro.org>
> > ---
> > Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> > index 9e0f60e682c4..746a929c63bb 100644
> > --- a/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> > +++ b/Documentation/devicetree/bindings/phy/qcom,qmp-phy.yaml
> > @@ -115,7 +115,6 @@ patternProperties:
> > required:
> > - compatible
> > - reg
> > - - "#clock-cells"
> > - "#address-cells"
> > - "#size-cells"
> > - ranges
> > --
> > 2.35.1
> >
>
>
> --
> With best wishes
> Dmitry
next prev parent reply other threads:[~2022-02-25 9:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-24 12:32 [PATCH 1/2] dt-bindings: phy: qcom,qmp: Mark '#clock-cells' as a 'optional' property Bhupesh Sharma
2022-02-24 12:32 ` [PATCH 2/2] dt-bindings: phy: qcom,qmp: Describe 'vdda-max-microamp' & 'vdda-pll-max-microamp' properties Bhupesh Sharma
2022-02-24 13:59 ` Rob Herring
2022-02-25 20:08 ` Rob Herring
2022-02-26 19:45 ` Bhupesh Sharma
2022-02-24 14:52 ` [PATCH 1/2] dt-bindings: phy: qcom,qmp: Mark '#clock-cells' as a 'optional' property Dmitry Baryshkov
2022-02-25 9:16 ` Bhupesh Sharma [this message]
2022-02-26 23:38 ` Dmitry Baryshkov
2022-02-27 4:19 ` Bhupesh Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAH=2NtxQBS=c0W0cpX5EdNi12PrqiKEuzyvEtF8WrVE6nsU_rg@mail.gmail.com' \
--to=bhupesh.sharma@linaro.org \
--cc=agross@kernel.org \
--cc=bhupesh.linux@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=robh+dt@kernel.org \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).