From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9E56AC48BE8 for ; Tue, 15 Jun 2021 04:47:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8611A6140B for ; Tue, 15 Jun 2021 04:47:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229979AbhFOEtZ (ORCPT ); Tue, 15 Jun 2021 00:49:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47678 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229918AbhFOEtX (ORCPT ); Tue, 15 Jun 2021 00:49:23 -0400 Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DD7EC061767 for ; Mon, 14 Jun 2021 21:47:19 -0700 (PDT) Received: by mail-ot1-x32f.google.com with SMTP id 66-20020a9d02c80000b02903615edf7c1aso13055284otl.13 for ; Mon, 14 Jun 2021 21:47:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nngriT+7I5tBGdgHEeOVhQ16xcR1u7wZ3t5HbdfW8Z4=; b=lp5W+n4oYwyvQD2qxXRtPuLq+miZglxCfYAqf9CAnQ4bMl9+R/43fgL94AgAHz205a f8rSSQIk0JKew14zfLonjTJBToVck8l7qJjXQCf44113WPA+d2VyMHJzz6mvB86dR51m P6i0gCX8Mez2PzLZdgvaSd0/I4uUbSTjqQ3wNuYra2dmuv4BV8f555lYp/z/vb/CyVgQ VyYNb271xmCVwqGLbGr4Y4fFh0/ninI+QpGtlNRjfyPxLTUzPYdcurCAKPMRuobAIpA5 gYm7sHfjJouxVWof6d+3lFxZixtbXyX81OywFOVIhoRJonE/M8ApxCpldZfRZ2um0cFO L6ug== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nngriT+7I5tBGdgHEeOVhQ16xcR1u7wZ3t5HbdfW8Z4=; b=S5yvI5bAIVUVHtKjjWKhG8bh6yB7spZyeyo2ry/o1sieSglubmMxpkJ5VLd1r4ba6Z R1105yAc8xrDIHuR4WbexrQ4zC7DchWRCHqTNU4wrobBky/xgZuvTlASR1lv0+St5ZUM bA1GY89GZvlJrgRmSr2U/R+cv+vDVi4bnQpPU5kU2peicRqNRZJu2H8dmY44Plq040K/ 1B9nP1nmtCLQKqmaNMhVBhCJ4LHla1EhrXMooSZTeD/Qh/Jt6gMvRomSld01gzNhJyn2 piYEusH86W3buP7pqJwt/bAebjBFbmGv/kUJ6h0AV5HWUiPFFtTSYIGMDDzmJhfyA5th POIg== X-Gm-Message-State: AOAM531KVE/zbERGa0T2OfDS6UalFg5hQonfmGmPU5yF9+ozYN+NTkIY /3zBguo646QcJUiya5kgzfhXKr2EYoCVdOgLfBflpw== X-Google-Smtp-Source: ABdhPJwIjnzDAGWEPWyfPs9YdC7k0RYUBiPJTLKDbEmeUW9F0RNyfETdyIC5ptMaQ0ffkA33XteJvJvxzo73fBMkNzg= X-Received: by 2002:a9d:74d4:: with SMTP id a20mr15893473otl.28.1623732438466; Mon, 14 Jun 2021 21:47:18 -0700 (PDT) MIME-Version: 1.0 References: <20210607113840.15435-1-bhupesh.sharma@linaro.org> <20210607113840.15435-5-bhupesh.sharma@linaro.org> In-Reply-To: From: Bhupesh Sharma Date: Tue, 15 Jun 2021 10:17:07 +0530 Message-ID: Subject: Re: [PATCH 4/8] regulator: qcom-rpmh: Add new regulator types found on SA8155p adp board To: Bjorn Andersson Cc: Andy Shevchenko , linux-arm-msm@vger.kernel.org, Linus Walleij , Liam Girdwood , Mark Brown , Vinod Koul , Rob Herring , Andy Gross , devicetree , Linux Kernel Mailing List , "open list:GPIO SUBSYSTEM" , bhupesh.linux@gmail.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 14 Jun 2021 at 21:47, Bjorn Andersson wrote: > > On Mon 07 Jun 07:30 CDT 2021, Bhupesh Sharma wrote: > > > On Mon, 7 Jun 2021 at 17:39, Andy Shevchenko wrote: > > > > > > On Mon, Jun 7, 2021 at 2:41 PM Bhupesh Sharma wrote: > > > > > > > > SA8155p-adp board has two new regulator types - pmm8155au_1 and > > > > pmm8155au_2. > > > > > > > > The output power management circuits in these regulators include: > > > > - FTS510 smps, > > > > - HFS510 smps, and > > > > - LDO510 linear regulators > > > > > > ... > > > > > > > Cc: Linus Walleij > > > > Cc: Liam Girdwood > > > > Cc: Mark Brown > > > > Cc: Bjorn Andersson > > > > Cc: Vinod Koul > > > > Cc: Rob Herring > > > > Cc: Andy Gross > > > > Cc: devicetree@vger.kernel.org > > > > Cc: linux-kernel@vger.kernel.org > > > > Cc: linux-gpio@vger.kernel.org > > > > Cc: bhupesh.linux@gmail.com > > > > > > Use --cc or similar option when run `git send-email`, no need to > > > pollute the commit message with these. > > > > It's just a matter of preference IMO. I prefer to use a Cc list > > here. > > > > The Cc list in the commit message will be committed to the git history > and there it carries the information that you specifically made sure > that these people saw the patch. So please limit the use to that > purpose. I understand, but different maintainers like different formats here. Infact, there are suggestions not to use --cc as some opens-source lists are known to drop folks from Cc list accidentally (mentioned via --cc) , so some folks prefer the git log to contain the Cc list instead. But I can trim the same for v2. > > > > +static const struct rpmh_vreg_init_data pmm8155au_1_vreg_data[] = { > > > > > > > > > > + {}, > > > > > > Comma is not needed in the terminator line. > > > > Hmm.. it's similar to the syntax already used at several places in this file. > > See ' struct rpmh_vreg_init_data pm8150l_vreg_data[] ' for example. > > > > Unless there is an obvious issue with it, let's use the same to keep > > things similar from a syntax p-o-v. > > > > Those other places shouldn't use the ',' either, so please help set a > better precedence. Sure, I will send that out as a separate clean-up patch. Regards, Bhupesh