From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751410AbaHORcx (ORCPT ); Fri, 15 Aug 2014 13:32:53 -0400 Received: from mail-lb0-f173.google.com ([209.85.217.173]:44144 "EHLO mail-lb0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751027AbaHORcw (ORCPT ); Fri, 15 Aug 2014 13:32:52 -0400 MIME-Version: 1.0 In-Reply-To: References: <20140723113314.GA7798@chaz.gmail.com> <53CFCD26.1020409@infradead.org> Date: Fri, 15 Aug 2014 10:32:50 -0700 Message-ID: Subject: Re: network interfaces called "all", "default" or "config" From: Cong Wang To: Stephane Chazelas Cc: Randy Dunlap , "linux-kernel@vger.kernel.org" , "netdev@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 15, 2014 at 1:33 AM, Stephane Chazelas wrote: > Yes, I know those are also used for the eth0:1 "aliases", but the bug > is, since it is allowed to do > > ip link add link eth0 eth0:123 type vlan id 123 > > Then the > > ip link del link eth0 eth0:123 > > should be allowed as well. Or probably better to avoid confusion > > ip link add link eth0 foo:bar type vlan id 123 > > should not be allowed. > Good point! I think the reason is that in the past we used ioctl() to add or remove network interface so kernel just checks that code path for name alias, so we probably need to check netlink path as well since it makes really little sense that we allow create names with a colon but disallow to delete them. Stephen should know better than me.