From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73B44C54EBE for ; Thu, 12 Jan 2023 18:47:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232290AbjALSr4 (ORCPT ); Thu, 12 Jan 2023 13:47:56 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52152 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233784AbjALSr1 (ORCPT ); Thu, 12 Jan 2023 13:47:27 -0500 Received: from mail-pg1-x532.google.com (mail-pg1-x532.google.com [IPv6:2607:f8b0:4864:20::532]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0671F820C1 for ; Thu, 12 Jan 2023 10:19:57 -0800 (PST) Received: by mail-pg1-x532.google.com with SMTP id e10so13332144pgc.9 for ; Thu, 12 Jan 2023 10:19:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20210112.gappssmtp.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=0XqZSkBjF0/NwCudxK7VyjrIpDSZ4UaVvor7D5Au+9I=; b=Nss6QjOj2gWAnAUZSZ/Om/bvUd0ReXJo7t3e+0oHUVC0Dcr0a+a15NlUkN1pPkdNjI xqJouLOLu6WulABRRjr2EE8ABIhfopSfsqApSd3bBpqeKqcWQknlDmtwAnudN+zJ7Y0O tCQIhs+JofA7eoEN2kcocsbiz/R/AazVdN0xuYpe8+2yWT7P78IqnNkOWsgwnC05suE+ Teec6JjBKNr3pGUiteMTH1/5Aprxv2ExecE4R5B/AThLZaTlT1/9bTMPaBNaJ1E47PbW SWrrj+6IYPGVrdXP9Mi9zdenICE6ibCfm4uO8gdqzKJo8G2C5yU2z34+JDcT3YVdMnoT USXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0XqZSkBjF0/NwCudxK7VyjrIpDSZ4UaVvor7D5Au+9I=; b=5XcdMKNFbFLgMEZ3DTjN0oBwX5IdCmMUAN3wbnoTU8RUb34b+yUkdmX1l8Ab8c65VP RBCy42gxYd/1Hons4mYaJ9xza+qP/oRf51y1Cm9UC8Y5skPLa2WpczovqUyOfOZ71vc9 yt+nHC3wiNIdjAy+oe+PnKx+lHU/v8sR01suqU+F/HfQvv37UrEeIuHjFwhzrDg3vOqr rxGAMajTXVI3hAPzYsMnK4HA7H4XnK2rUTdyp2Rljdg16J5pgJI06vZEw3aErx0+Cf7c Rka7fcVOMfShjNxoVkULcZfEqmJUU1xr3l59s18VHnJ+MQT3qB1rx957BLo3jSSsfjbL rseg== X-Gm-Message-State: AFqh2kq18iwMkvJcbVgTHHEEgw97NsJJerzGuBoo4cFXpXXTk5h0xcId DI3wFS7a+mn2SgEJup65ENP2dGVZ09DKHd/dkssXAA== X-Google-Smtp-Source: AMrXdXsMZYU+ot9pUjM6sBfBWlHRs5OKPeSzQPbNaLx2GTCzg8mr/58dc6ua+GqpoYiouuO1ycmVhn1xvGW01o0l2Ac= X-Received: by 2002:a63:d14a:0:b0:479:5a45:6d32 with SMTP id c10-20020a63d14a000000b004795a456d32mr3854918pgj.138.1673547597227; Thu, 12 Jan 2023 10:19:57 -0800 (PST) MIME-Version: 1.0 References: <20221215170046.2010255-1-atishp@rivosinc.com> <20221215170046.2010255-3-atishp@rivosinc.com> <20230112102141.chpcqzoko25s2cak@orel> In-Reply-To: <20230112102141.chpcqzoko25s2cak@orel> From: Atish Kumar Patra Date: Thu, 12 Jan 2023 10:19:46 -0800 Message-ID: Subject: Re: [PATCH v2 02/11] RISC-V: KVM: Define a probe function for SBI extension data structures To: Andrew Jones Cc: linux-kernel@vger.kernel.org, Anup Patel , Atish Patra , Guo Ren , kvm-riscv@lists.infradead.org, kvm@vger.kernel.org, linux-riscv@lists.infradead.org, Mark Rutland , Palmer Dabbelt , Paul Walmsley , Sergey Matyukevich , Eric Lin , Will Deacon Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 12, 2023 at 2:21 AM Andrew Jones wrote: > > On Thu, Dec 15, 2022 at 09:00:37AM -0800, Atish Patra wrote: > > Currently the probe function just checks if an SBI extension is > > registered or not. However, the extension may not want to advertise > > itself depending on some other condition. > > An additional extension specific probe function will allow > > extensions to decide if they want to be advertised to the caller or > > not. Any extension that does not require additional dependency checks > > can avoid implementing this function. > > > > Signed-off-by: Atish Patra > > --- > > arch/riscv/include/asm/kvm_vcpu_sbi.h | 3 +++ > > arch/riscv/kvm/vcpu_sbi_base.c | 13 +++++++++++-- > > 2 files changed, 14 insertions(+), 2 deletions(-) > > > > diff --git a/arch/riscv/include/asm/kvm_vcpu_sbi.h b/arch/riscv/include/asm/kvm_vcpu_sbi.h > > index f79478a..61dac1b 100644 > > --- a/arch/riscv/include/asm/kvm_vcpu_sbi.h > > +++ b/arch/riscv/include/asm/kvm_vcpu_sbi.h > > @@ -29,6 +29,9 @@ struct kvm_vcpu_sbi_extension { > > int (*handler)(struct kvm_vcpu *vcpu, struct kvm_run *run, > > unsigned long *out_val, struct kvm_cpu_trap *utrap, > > bool *exit); > > + > > + /* Extension specific probe function */ > > + unsigned long (*probe)(struct kvm_vcpu *vcpu, unsigned long extid); > > It doesn't seem like the extid parameter should be necessary since the > probe function is specific to the extension, but it doesn't hurt either. > Yeah. You are correct. I will drop it. Thanks. > > }; > > > > void kvm_riscv_vcpu_sbi_forward(struct kvm_vcpu *vcpu, struct kvm_run *run); > > diff --git a/arch/riscv/kvm/vcpu_sbi_base.c b/arch/riscv/kvm/vcpu_sbi_base.c > > index 5d65c63..89e2415 100644 > > --- a/arch/riscv/kvm/vcpu_sbi_base.c > > +++ b/arch/riscv/kvm/vcpu_sbi_base.c > > @@ -19,6 +19,7 @@ static int kvm_sbi_ext_base_handler(struct kvm_vcpu *vcpu, struct kvm_run *run, > > { > > int ret = 0; > > struct kvm_cpu_context *cp = &vcpu->arch.guest_context; > > + const struct kvm_vcpu_sbi_extension *sbi_ext; > > > > switch (cp->a6) { > > case SBI_EXT_BASE_GET_SPEC_VERSION: > > @@ -43,8 +44,16 @@ static int kvm_sbi_ext_base_handler(struct kvm_vcpu *vcpu, struct kvm_run *run, > > */ > > kvm_riscv_vcpu_sbi_forward(vcpu, run); > > *exit = true; > > - } else > > - *out_val = kvm_vcpu_sbi_find_ext(cp->a0) ? 1 : 0; > > + } else { > > + sbi_ext = kvm_vcpu_sbi_find_ext(cp->a0); > > + if (sbi_ext) { > > + if (sbi_ext->probe) > > + *out_val = sbi_ext->probe(vcpu, cp->a0); > > + else > > + *out_val = 1; > > + } else > > + *out_val = 0; > > + } > > break; > > case SBI_EXT_BASE_GET_MVENDORID: > > *out_val = vcpu->arch.mvendorid; > > -- > > 2.25.1 > > > > Reviewed-by: Andrew Jones