* [PATCH v1] Bluetooth: Add a new MGMT error code for 0x3E HCI error
@ 2021-04-29 17:38 Yu Liu
2021-05-05 16:07 ` Yu Liu
0 siblings, 1 reply; 2+ messages in thread
From: Yu Liu @ 2021-04-29 17:38 UTC (permalink / raw)
To: linux-bluetooth, marcel, chromeos-bluetooth-upstreaming
Cc: Yu Liu, Abhishek Pandit-Subedi, David S. Miller, Jakub Kicinski,
Johan Hedberg, Luiz Augusto von Dentz, linux-kernel, netdev
This is to enable us to retry the pairing in the user space if this
failure is encountered
Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
Signed-off-by: Yu Liu <yudiliu@google.com>
---
Changes in v1:
- Initial change
include/net/bluetooth/mgmt.h | 1 +
net/bluetooth/mgmt.c | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
index a03c62b1dc2f..78b94577a7d8 100644
--- a/include/net/bluetooth/mgmt.h
+++ b/include/net/bluetooth/mgmt.h
@@ -45,6 +45,7 @@
#define MGMT_STATUS_RFKILLED 0x12
#define MGMT_STATUS_ALREADY_PAIRED 0x13
#define MGMT_STATUS_PERMISSION_DENIED 0x14
+#define MGMT_STATUS_CONNECT_NOT_ESTD 0x15
struct mgmt_hdr {
__le16 opcode;
diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index b44e19c69c44..9e44c04d4212 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -271,7 +271,7 @@ static const u8 mgmt_status_table[] = {
MGMT_STATUS_INVALID_PARAMS, /* Unsuitable Connection Interval */
MGMT_STATUS_TIMEOUT, /* Directed Advertising Timeout */
MGMT_STATUS_AUTH_FAILED, /* Terminated Due to MIC Failure */
- MGMT_STATUS_CONNECT_FAILED, /* Connection Establishment Failed */
+ MGMT_STATUS_CONNECT_NOT_ESTD, /* Connection Establishment Failed */
MGMT_STATUS_CONNECT_FAILED, /* MAC Connection Failed */
};
--
2.31.1.527.g47e6f16901-goog
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v1] Bluetooth: Add a new MGMT error code for 0x3E HCI error
2021-04-29 17:38 [PATCH v1] Bluetooth: Add a new MGMT error code for 0x3E HCI error Yu Liu
@ 2021-05-05 16:07 ` Yu Liu
0 siblings, 0 replies; 2+ messages in thread
From: Yu Liu @ 2021-05-05 16:07 UTC (permalink / raw)
To: linux-bluetooth, Marcel Holtmann; +Cc: Luiz Augusto von Dentz, linux-kernel
ping for attention.
On Thu, Apr 29, 2021 at 10:38 AM Yu Liu <yudiliu@google.com> wrote:
>
> This is to enable us to retry the pairing in the user space if this
> failure is encountered
>
> Reviewed-by: Abhishek Pandit-Subedi <abhishekpandit@chromium.org>
>
> Signed-off-by: Yu Liu <yudiliu@google.com>
> ---
>
> Changes in v1:
> - Initial change
>
> include/net/bluetooth/mgmt.h | 1 +
> net/bluetooth/mgmt.c | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/include/net/bluetooth/mgmt.h b/include/net/bluetooth/mgmt.h
> index a03c62b1dc2f..78b94577a7d8 100644
> --- a/include/net/bluetooth/mgmt.h
> +++ b/include/net/bluetooth/mgmt.h
> @@ -45,6 +45,7 @@
> #define MGMT_STATUS_RFKILLED 0x12
> #define MGMT_STATUS_ALREADY_PAIRED 0x13
> #define MGMT_STATUS_PERMISSION_DENIED 0x14
> +#define MGMT_STATUS_CONNECT_NOT_ESTD 0x15
>
> struct mgmt_hdr {
> __le16 opcode;
> diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> index b44e19c69c44..9e44c04d4212 100644
> --- a/net/bluetooth/mgmt.c
> +++ b/net/bluetooth/mgmt.c
> @@ -271,7 +271,7 @@ static const u8 mgmt_status_table[] = {
> MGMT_STATUS_INVALID_PARAMS, /* Unsuitable Connection Interval */
> MGMT_STATUS_TIMEOUT, /* Directed Advertising Timeout */
> MGMT_STATUS_AUTH_FAILED, /* Terminated Due to MIC Failure */
> - MGMT_STATUS_CONNECT_FAILED, /* Connection Establishment Failed */
> + MGMT_STATUS_CONNECT_NOT_ESTD, /* Connection Establishment Failed */
> MGMT_STATUS_CONNECT_FAILED, /* MAC Connection Failed */
> };
>
> --
> 2.31.1.527.g47e6f16901-goog
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-05-05 16:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-29 17:38 [PATCH v1] Bluetooth: Add a new MGMT error code for 0x3E HCI error Yu Liu
2021-05-05 16:07 ` Yu Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).