From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933374AbbDIUr5 (ORCPT ); Thu, 9 Apr 2015 16:47:57 -0400 Received: from mail-ob0-f177.google.com ([209.85.214.177]:35982 "EHLO mail-ob0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754298AbbDIUrz convert rfc822-to-8bit (ORCPT ); Thu, 9 Apr 2015 16:47:55 -0400 MIME-Version: 1.0 X-Originating-IP: [101.171.127.247] In-Reply-To: <55267A2F.5050609@6wind.com> References: <1428511002-22329-1-git-send-email-nicolas.dichtel@6wind.com> <1428511002-22329-3-git-send-email-nicolas.dichtel@6wind.com> <55267A2F.5050609@6wind.com> Date: Thu, 9 Apr 2015 16:47:54 -0400 Message-ID: Subject: Re: [PATCH net-next 2/5] selinux/nlmsg: add RTM_GETNSID From: Paul Moore To: nicolas.dichtel@6wind.com Cc: davem@davemloft.net, netdev@vger.kernel.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 9, 2015 at 9:10 AM, Nicolas Dichtel wrote: > Le 09/04/2015 13:10, Paul Moore a écrit : > [snip] >>> >>> --- a/security/selinux/nlmsgtab.c >>> +++ b/security/selinux/nlmsgtab.c >>> @@ -74,6 +74,7 @@ static struct nlmsg_perm nlmsg_route_perms[] = >>> { RTM_DELMDB, NETLINK_ROUTE_SOCKET__NLMSG_WRITE }, >>> { RTM_GETMDB, NETLINK_ROUTE_SOCKET__NLMSG_READ }, >>> { RTM_NEWNSID, NETLINK_ROUTE_SOCKET__NLMSG_WRITE }, >>> + { RTM_DELNSID, NETLINK_ROUTE_SOCKET__NLMSG_READ }, >>> { RTM_GETNSID, NETLINK_ROUTE_SOCKET__NLMSG_READ }, >>> }; >> >> >> Can you elaborate a bit on the RTM_DELNSID type? Based only on the >> name I wonder if it should be treated as a "write" and not a "read" >> operation. > > The user is not allowed to delete a nsid (no method is implemented). This > RTM_DELNSID is only used for notifications. Okay, thanks for clearing that up. -- paul moore www.paul-moore.com