From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1756715AbdIHRge (ORCPT <rfc822;w@1wt.eu>);
        Fri, 8 Sep 2017 13:36:34 -0400
Received: from mail-lf0-f68.google.com ([209.85.215.68]:36401 "EHLO
        mail-lf0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1756210AbdIHRgb (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 8 Sep 2017 13:36:31 -0400
X-Google-Smtp-Source: AOwi7QAg1zA+diy8Eq6hhbGHiG0JhdqfgHKpqN+Dan+wIBc6JmDQdReMA9LX6oTdbHnjBybKaNavhceaI49+Joq5ARs=
MIME-Version: 1.0
X-Originating-IP: [108.49.102.27]
In-Reply-To: <CA+55aFwMgUJSMQ96XdKnTbn8UsxzHTb8tZQdH40nxDeF7fWObw@mail.gmail.com>
References: <alpine.LRH.2.21.1709041959220.27950@namei.org>
 <CA+55aFw8wgA+jhBOhnY-TSdbPgiYcrFiipCV=rsS1=GQEN+JgQ@mail.gmail.com>
 <alpine.LRH.2.21.1709081448090.7880@namei.org> <20170908070943.GA26549@infradead.org>
 <CA+55aFwMgUJSMQ96XdKnTbn8UsxzHTb8tZQdH40nxDeF7fWObw@mail.gmail.com>
From: Paul Moore <paul@paul-moore.com>
Date: Fri, 8 Sep 2017 13:36:29 -0400
Message-ID: <CAHC9VhR2c1rC4--1Br0cx+3eALLdB8Oishw7wwcGwb1_3qN8+w@mail.gmail.com>
Subject: Re: [GIT PULL] Security subsystem updates for 4.14
To: Linus Torvalds <torvalds@linux-foundation.org>,
        James Morris <jmorris@namei.org>,
        LSM List <linux-security-module@vger.kernel.org>
Cc: Christoph Hellwig <hch@infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Mimi Zohar <zohar@linux.vnet.ibm.com>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Sep 8, 2017 at 1:25 PM, Linus Torvalds
<torvalds@linux-foundation.org> wrote:
> On Fri, Sep 8, 2017 at 12:09 AM, Christoph Hellwig <hch@infradead.org> wrote:
>>
>> But yes, for the init-time integrity_read_file this is incorrect.
>> It never tripped up, and I explicitly added the lockdep annotations
>> so that anything would show up, and it's been half a year since
>> I sent that first RFC patch..
>
> I don't think anybody actually tests linux-next kernels in any big
> way, and the automated tests that do get run probably don't run with
> any integrity checking enabled.
>
> Which is why I actually look at the code when merging unexpected stuff.
>
> This is also why I tend to prefer getting multiple branches for
> independent things.
>
> Now the whole security pull will be ignored because of this thing. I
> refuse to pull garbage where I notice major fundamental problems in
> code that has obviously never ever been tested.

Is it time to start sending pull request for each LSM and thing under
security/ directly?  I'm not sure I have a strong preference either
way, I just don't want to see the SELinux changes ignored during the
merge window.

-- 
paul moore
www.paul-moore.com