From: Paul Moore <paul@paul-moore.com>
To: tiny.windzz@gmail.com
Cc: Eric Paris <eparis@redhat.com>,
linux-audit@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fsnotify: remove some duplicated includes
Date: Mon, 26 Nov 2018 18:37:43 -0500 [thread overview]
Message-ID: <CAHC9VhRX8vs42AYaQRAwqs1VonJWai75fcsHogn17FxDT431_g@mail.gmail.com> (raw)
In-Reply-To: <20181126145434.31705-1-tiny.windzz@gmail.com>
On Mon, Nov 26, 2018 at 9:54 AM Yangtao Li <tiny.windzz@gmail.com> wrote:
> audit.h and fs.h are included twice.It's unnecessary.
> hence just remove them.
>
> Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
> ---
> kernel/audit_fsnotify.c | 2 --
> 1 file changed, 2 deletions(-)
I currently prefer to keep things as-is, see my response to your previous patch.
> diff --git a/kernel/audit_fsnotify.c b/kernel/audit_fsnotify.c
> index fba78047fb37..5b54386a9edf 100644
> --- a/kernel/audit_fsnotify.c
> +++ b/kernel/audit_fsnotify.c
> @@ -16,10 +16,8 @@
> */
>
> #include <linux/kernel.h>
> -#include <linux/audit.h>
> #include <linux/kthread.h>
> #include <linux/mutex.h>
> -#include <linux/fs.h>
> #include <linux/fsnotify_backend.h>
> #include <linux/namei.h>
> #include <linux/netlink.h>
> --
> 2.17.0
>
--
paul moore
www.paul-moore.com
prev parent reply other threads:[~2018-11-26 23:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-26 14:54 [PATCH] fsnotify: remove some duplicated includes Yangtao Li
2018-11-26 23:37 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHC9VhRX8vs42AYaQRAwqs1VonJWai75fcsHogn17FxDT431_g@mail.gmail.com \
--to=paul@paul-moore.com \
--cc=eparis@redhat.com \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiny.windzz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).