From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF69BC433EF for ; Mon, 16 May 2022 23:06:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347942AbiEPXGy (ORCPT ); Mon, 16 May 2022 19:06:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1350514AbiEPXGk (ORCPT ); Mon, 16 May 2022 19:06:40 -0400 Received: from mail-wr1-x432.google.com (mail-wr1-x432.google.com [IPv6:2a00:1450:4864:20::432]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C83133E98 for ; Mon, 16 May 2022 16:06:38 -0700 (PDT) Received: by mail-wr1-x432.google.com with SMTP id d21so6467915wra.10 for ; Mon, 16 May 2022 16:06:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GWbhKr4uIgUJdqioayLfv0a/97vu9JuV374NJIuj07k=; b=srCDnu0GFgxUWJi+fbEi5+IRCNr5P8YyBqD/ANuYnVBRNhOZlxyc1Kq7tP5Ujjbef8 GD6tlfL7VBbP+GzV3JA7qP4xgQJb3w+9iU82QMe3jKpf8n203zwYotjwe+bylMxPtAkh B6Qd+jBHp39THWYfGS8RQbMOBPNCKvhsqdkbhmfKAf8JpN0MSZ3on0uj413fBDi7rekB 3w7C51qoVD9+iYGB8NdvyksbJsGVPX4wePRpRuYeQSko03SZP7uyt2UE2xoGli6DwoYJ yEwideiPF+2R6hD8GsSU3lM7MuE40Q2peGFuEbND5FTsIiCZaKIkhvtLhNFK4VcYkVgb YWBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GWbhKr4uIgUJdqioayLfv0a/97vu9JuV374NJIuj07k=; b=6oRzhpcfiUMTt712pyPD4xefYNjvgvJ2CuoBA6Gmu0/+kwf67uUpQTIt4084V3RC4h 27AJ0m8O47ViaPKu4dLdt7MZr7wZVj+rGt8krQ3KqzU8fhYYyfWdShkhb8RqQy10nrkA hcqp8f38QRuA3fbRpdvM085/92mFD6EetuJXT2A/JGLua3hPjdogkKnL8PoZiP4gDqm8 WDcwSMd87rm53NOiTdG49HYaIQvF/QXOPSyhmBD94QT2c08om9q5O4yWmveSBhUXSp/x o3X4iirmRQE1OXu+1QrdeBrC2fFJHm+tvgVgN01hsyccVrxdutaCLNTNIO01suLrQKvD KwWw== X-Gm-Message-State: AOAM533snscP/rghiOAHHhLLcTVtalMxLcrsir2Fj64B+Nvwr+ObvJb8 T+oY7WcZ8YnR+NrFNmegIovdm3pyJX0OTqkJ5UQG X-Google-Smtp-Source: ABdhPJzMOUlYHtDAXxonPowZHZVLJu4wBPBpRYjA/BeHhRo120bLMO/D+T6lSRrgQH7hQWbqtYdTp3CU8xpDNFGiNn0= X-Received: by 2002:a5d:4806:0:b0:20a:da03:711b with SMTP id l6-20020a5d4806000000b0020ada03711bmr15470768wrq.395.1652742396890; Mon, 16 May 2022 16:06:36 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Paul Moore Date: Mon, 16 May 2022 19:06:26 -0400 Message-ID: Subject: Re: [PATCH v3 1/3] fanotify: Ensure consistent variable type for response To: Richard Guy Briggs Cc: Linux-Audit Mailing List , LKML , linux-fsdevel@vger.kernel.org, Eric Paris , Steve Grubb , Jan Kara , Amir Goldstein Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 16, 2022 at 4:22 PM Richard Guy Briggs wrote: > > The user space API for the response variable is __u32. This patch makes > sure that the whole path through the kernel uses u32 so that there is > no sign extension or truncation of the user space response. > > Suggested-by: Steve Grubb > Link: https://lore.kernel.org/r/12617626.uLZWGnKmhe@x2 > Signed-off-by: Richard Guy Briggs > --- > fs/notify/fanotify/fanotify.h | 2 +- > fs/notify/fanotify/fanotify_user.c | 6 +++--- > include/linux/audit.h | 6 +++--- > kernel/auditsc.c | 2 +- > 4 files changed, 8 insertions(+), 8 deletions(-) We're at -rc7, so this should wait until after the upcoming merge window, but it looks okay to me. Acked-by: Paul Moore -- paul-moore.com