From: Paul Moore <paul@paul-moore.com>
To: Shailendra Verma <shailendra.v@samsung.com>
Cc: Stephen Smalley <sds@tycho.nsa.gov>,
Eric Paris <eparis@parisplace.org>,
James Morris <james.l.morris@oracle.com>,
"Serge E. Hallyn" <serge@hallyn.com>,
selinux@tycho.nsa.gov, linux-security-module@vger.kernel.org,
linux-kernel@vger.kernel.org,
Shailendra Verma <shailendra.capricorn@gmail.com>,
vidushi.koul@samsung.com
Subject: Re: [PATCH] Security: selinux - Improvement in code readability when
Date: Fri, 11 Nov 2016 21:29:21 -0500 [thread overview]
Message-ID: <CAHC9VhRsDdFohpmDkD2JGCnz5v3Tg7NHQDF7g8gCOj7_6D6jfg@mail.gmail.com> (raw)
In-Reply-To: <1478854120-25311-1-git-send-email-shailendra.v@samsung.com>
On Fri, Nov 11, 2016 at 3:48 AM, Shailendra Verma
<shailendra.v@samsung.com> wrote:
> From: "Shailendra Verma" <shailendra.v@samsung.com>
>
> There is no need to call kfree() if memdup_user() fails, as no memory
> was allocated and the error in the error-valued pointer should be returned.
>
> Signed-off-by: Shailendra Verma <shailendra.v@samsung.com>
> ---
> security/selinux/selinuxfs.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Hello Shailendra,
Thank you for your patch, but I prefer the readability of the code as
it currently stands.
--
paul moore
www.paul-moore.com
prev parent reply other threads:[~2016-11-12 2:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 8:48 [PATCH] Security: selinux - Improvement in code readability when Shailendra Verma
2016-11-12 2:29 ` Paul Moore [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHC9VhRsDdFohpmDkD2JGCnz5v3Tg7NHQDF7g8gCOj7_6D6jfg@mail.gmail.com \
--to=paul@paul-moore.com \
--cc=eparis@parisplace.org \
--cc=james.l.morris@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=serge@hallyn.com \
--cc=shailendra.capricorn@gmail.com \
--cc=shailendra.v@samsung.com \
--cc=vidushi.koul@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).