From: Paul Moore <paul@paul-moore.com>
To: Ondrej Mosnacek <omosnace@redhat.com>
Cc: linux-audit@redhat.com, Richard Guy Briggs <rgb@redhat.com>,
Steve Grubb <sgrubb@redhat.com>,
Miroslav Lichvar <mlichvar@redhat.com>,
John Stultz <john.stultz@linaro.org>,
Thomas Gleixner <tglx@linutronix.de>,
Stephen Boyd <sboyd@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH ghak10 v8 1/2] timekeeping: Audit clock adjustments
Date: Mon, 15 Apr 2019 18:28:09 -0400 [thread overview]
Message-ID: <CAHC9VhSMiMnBK=N97LgD=mCS1BNVDjoHToPYm3DPBcw+trsr6g@mail.gmail.com> (raw)
In-Reply-To: <20190410091420.23987-2-omosnace@redhat.com>
On Wed, Apr 10, 2019 at 5:14 AM Ondrej Mosnacek <omosnace@redhat.com> wrote:
>
> Emit an audit record whenever the system clock is changed (i.e. shifted
> by a non-zero offset) by a syscall from userspace. The syscalls than can
> (at the time of writing) trigger such record are:
> - settimeofday(2), stime(2), clock_settime(2) -- via
> do_settimeofday64()
> - adjtimex(2), clock_adjtime(2) -- via do_adjtimex()
>
> The new records have type AUDIT_TIME_INJOFFSET and contain the following
> fields:
> - sec -- the 'seconds' part of the offset
> - nsec -- the 'nanoseconds' part of the offset
>
> Example record (time was shifted backwards by ~15.875 seconds):
>
> type=TIME_INJOFFSET msg=audit(1530616049.652:13): sec=-16 nsec=124887145
>
> The records of this type will be associated with the corresponding
> syscall records.
>
> Signed-off-by: Ondrej Mosnacek <omosnace@redhat.com>
> Reviewed-by: Richard Guy Briggs <rgb@redhat.com>
> Reviewed-by: Thomas Gleixner <tglx@linutronix.de>
> ---
> include/linux/audit.h | 14 ++++++++++++++
> include/uapi/linux/audit.h | 1 +
> kernel/auditsc.c | 6 ++++++
> kernel/time/timekeeping.c | 6 ++++++
> 4 files changed, 27 insertions(+)
Merged into audit/next, thanks everyone.
Ondrej, please watch your line lengths, I had to break up another line
greater than 80 chars.
--
paul moore
www.paul-moore.com
next prev parent reply other threads:[~2019-04-15 22:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-10 9:14 [PATCH ghak10 v8 0/2] audit: Log changes that can affect the system clock Ondrej Mosnacek
2019-04-10 9:14 ` [PATCH ghak10 v8 1/2] timekeeping: Audit clock adjustments Ondrej Mosnacek
2019-04-15 22:28 ` Paul Moore [this message]
2019-04-10 9:14 ` [PATCH ghak10 v8 2/2] ntp: Audit NTP parameters adjustment Ondrej Mosnacek
2019-04-15 22:28 ` Paul Moore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHC9VhSMiMnBK=N97LgD=mCS1BNVDjoHToPYm3DPBcw+trsr6g@mail.gmail.com' \
--to=paul@paul-moore.com \
--cc=john.stultz@linaro.org \
--cc=linux-audit@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mlichvar@redhat.com \
--cc=omosnace@redhat.com \
--cc=rgb@redhat.com \
--cc=sboyd@kernel.org \
--cc=sgrubb@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).