From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CACB9C433E1 for ; Fri, 21 Aug 2020 02:22:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A8B3620732 for ; Fri, 21 Aug 2020 02:22:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore-com.20150623.gappssmtp.com header.i=@paul-moore-com.20150623.gappssmtp.com header.b="rkZem/xP" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727903AbgHUCWt (ORCPT ); Thu, 20 Aug 2020 22:22:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44422 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727106AbgHUCWo (ORCPT ); Thu, 20 Aug 2020 22:22:44 -0400 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9E55C061386 for ; Thu, 20 Aug 2020 19:22:43 -0700 (PDT) Received: by mail-ej1-x641.google.com with SMTP id f24so560661ejx.6 for ; Thu, 20 Aug 2020 19:22:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=b1QCc14GPT5F3fBeMa9aJ6/+QjqukYcGYpP98XcieAM=; b=rkZem/xP//Yw5RcfZCb8d0EXj6/DVgghiIYX4ouKUYXL4ERL6uT3z9/PYcwXrBpuLc eWLEEvEkCH2oNtkT+d6wgthUF8PW9ENjWXnmCj01NAX5IdAF6ZBYl4JEMcjb0dXAHve8 +E4+9H1EXNQLcmcuqoHYIUvx+Z1pxM8IM7Ugrw7HMSd3fjEhW6UWVQzb0a3ye4G/QoBR ncjW0WD4h1qyLnCNayIlH6/adY3RT1mR9iGVUiFyPjsx/TZSavmNgZol65w8ZJxjcK8y fd7t3uiZBtGH0ySTH6qg5DBbQqCxHTpBJ/x5WUsf3tdcBh+u7NUGh+RQLkIoemQotdyX Yvbw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b1QCc14GPT5F3fBeMa9aJ6/+QjqukYcGYpP98XcieAM=; b=UJCgzveW8uixmhth37KmQBDHOA1GVLJSflmyHlR/x0C7QGjG+2rZ+1fZNgRya2v4u0 J+fp8jLwy+KbsHfbOHkjLpsEOIDARr6RDbfevmexbywVBUWyecdMKqwdMwbxHlKjuupx pX/RywoRqMmmM4KITxQRpXhc5onMz+t6fKZb84RLfDCJCuiqZ8uzMhVg0ly0MDrb7EL/ OVVU4eB/fdilwSraG6xB9vxI5DQxcs9DT1pbCt2uTtoEQhNplKSb7NJ9/UVw0Exn7fPi jTAVAuE5U36o+ZWSMP898dK35JuOYoPexElMYAk9IARCj68ik3WKwhacVkz4c0CvkUms nEVw== X-Gm-Message-State: AOAM533ksG73t7rXzYBBtYwocZNORbE1F8DkFM4CQX6qXe9tcD8a2MJV v+Cm6rxTHl0wsBwki2ok6mYlq57RKeFetb6ZHuwd X-Google-Smtp-Source: ABdhPJxDoNqUGswwKhuSmyyuHeuGX8npxTUSizhNwYUXP9URQ7CAZQPQ5Go9M0OJ/H6WfRFApNa0sCSv9uFlANluKwY= X-Received: by 2002:a17:906:1911:: with SMTP id a17mr623897eje.431.1597976562364; Thu, 20 Aug 2020 19:22:42 -0700 (PDT) MIME-Version: 1.0 References: <20200817170729.2605279-1-tweek@google.com> <20200817170729.2605279-4-tweek@google.com> <6730ec4a-d11b-5c05-b64f-380104a86dab@sony.com> In-Reply-To: From: Paul Moore Date: Thu, 20 Aug 2020 22:22:30 -0400 Message-ID: Subject: Re: [PATCH v3 3/3] selinux: add permission names to trace event To: Stephen Smalley Cc: peter enderborg , =?UTF-8?Q?Thi=C3=A9baud_Weksteen?= , Nick Kralevich , Steven Rostedt , Eric Paris , Ingo Molnar , Mauro Carvalho Chehab , "David S. Miller" , Rob Herring , linux-kernel , SElinux list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 18, 2020 at 8:14 AM Stephen Smalley wrote: > On Tue, Aug 18, 2020 at 4:11 AM peter enderborg wrote: ... > > Is there any other things we need to fix? A part 1&2 now OK? > > They looked ok to me, but Paul should review them. Patches 1 and 2 look fine to me with the small nits that Stephen pointed out corrected. I'm glad to see the information in string form now, I think that will be a big help for people making use of this. Unfortunately, I'm a little concerned about patch 3 for the reason Stephen already mentioned. While changes to the class mapping are infrequent, they do happen, and I'm not very excited about adding it to the userspace kAPI via a header. Considering that the tracing tools are going to be running on the same system that is being inspected, perhaps the tracing tools could inspect /sys/fs/selinux/class at runtime to query the permission mappings? Stephen, is there a libselinux API which does this already? -- paul moore www.paul-moore.com