Re: [PATCHv2 0/2] introduce get_task_exe_file and use it to fix audit_exe_compare

From: Paul Moore <paul@paul-moore.com>
To: Mateusz Guzik <mguzik@redhat.com>, linux-kernel@vger.kernel.org
Cc: Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
	Richard Guy Briggs <rgb@redhat.com>,
	oleg@redhat.com, luto@amacapital.net, linux-audit@redhat.com,
	ebiederm@xmission.com, Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCHv2 0/2] introduce get_task_exe_file and use it to fix audit_exe_compare
Date: Mon, 29 Aug 2016 18:50:32 -0400	[thread overview]
Message-ID: <CAHC9VhTBfqYH1m-eKjSXtiyvLSjjdoVHbNVZquJHv55jx04WAQ@mail.gmail.com> (raw)
In-Reply-To: <1471962039-14940-1-git-send-email-mguzik@redhat.com>

On Tue, Aug 23, 2016 at 10:20 AM, Mateusz Guzik <mguzik@redhat.com> wrote:
> audit_exe_compare directly accesses mm->exe_file without making sure the
> object is stable. Fixing it using current primitives results in
> partially duplicating what proc_exe_link is doing.
>
> As such, introduce a trivial helper which can be used in both places and
> fix the func.
>
> Changes since v1:
> * removed an unused 'out' label which crept in
>
> Mateusz Guzik (2):
>   mm: introduce get_task_exe_file
>   audit: fix exe_file access in audit_exe_compare
>
>  fs/proc/base.c       |  7 +------
>  include/linux/mm.h   |  1 +
>  kernel/audit_watch.c |  8 +++++---
>  kernel/fork.c        | 23 +++++++++++++++++++++++
>  4 files changed, 30 insertions(+), 9 deletions(-)

Thanks for doing this.

Both patches look fine to me, does anyone in the mm area have any
objections?  If not, I'll merge these into the audit tree and mark
them for stable.

-- 
paul moore
www.paul-moore.com