From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755816AbbBACWH (ORCPT ); Sat, 31 Jan 2015 21:22:07 -0500 Received: from mail-wi0-f170.google.com ([209.85.212.170]:58222 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755423AbbBACWD (ORCPT ); Sat, 31 Jan 2015 21:22:03 -0500 MIME-Version: 1.0 X-Originating-IP: [76.119.162.148] In-Reply-To: <54CD4AF0.7070102@users.sourceforge.net> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <54CD45B6.6010703@users.sourceforge.net> <54CD4AF0.7070102@users.sourceforge.net> Date: Sat, 31 Jan 2015 21:22:02 -0500 Message-ID: Subject: Re: [PATCH 2/3] netlabel: Deletion of an unnecessary check before the function call "cipso_v4_doi_free" From: Paul Moore To: SF Markus Elfring Cc: "David S. Miller" , netdev@vger.kernel.org, LKML , kernel-janitors@vger.kernel.org, Julia Lawall Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 31, 2015 at 4:36 PM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 31 Jan 2015 19:35:59 +0100 > > The cipso_v4_doi_free() function tests whether its argument is NULL and then > returns immediately. Thus the test around the call is not needed. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring > --- > net/netlabel/netlabel_cipso_v4.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) Acked-by: Paul Moore > diff --git a/net/netlabel/netlabel_cipso_v4.c b/net/netlabel/netlabel_cipso_v4.c > index 1796253..7fd1104 100644 > --- a/net/netlabel/netlabel_cipso_v4.c > +++ b/net/netlabel/netlabel_cipso_v4.c > @@ -324,8 +324,7 @@ static int netlbl_cipsov4_add_std(struct genl_info *info, > return 0; > > add_std_failure: > - if (doi_def) > - cipso_v4_doi_free(doi_def); > + cipso_v4_doi_free(doi_def); > return ret_val; > } > > -- > 2.2.2 > -- paul moore www.paul-moore.com