From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2551BC433FE for ; Fri, 28 Jan 2022 01:53:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345188AbiA1Bxy (ORCPT ); Thu, 27 Jan 2022 20:53:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345178AbiA1Bxw (ORCPT ); Thu, 27 Jan 2022 20:53:52 -0500 Received: from mail-ed1-x52a.google.com (mail-ed1-x52a.google.com [IPv6:2a00:1450:4864:20::52a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8DF94C06173B for ; Thu, 27 Jan 2022 17:53:52 -0800 (PST) Received: by mail-ed1-x52a.google.com with SMTP id w25so5817563edt.7 for ; Thu, 27 Jan 2022 17:53:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0BksNA5S+udLGQFWNRur5mtnPIKBdIcol8nSGG5bpXY=; b=esFdDFaph7U2Rhf8i8w3+GyDTK6bATgu1eQZApvy6tgZyeZBVZ7S4iK+i2giHzgGhO C7PUaMmiPxLx67rOjRLEeZldRdYhwyyvoGxWfvcH6f1RiTJgwR6t5mAdS8sD5BVB4EpV E20LFd2HnHzKT/ImQj64oOerKbFxOkV3btqw5VbEuGjk7MsOZIk4npq9GVROJzQcifbP eon219Ij8PPL4e1a3eus6YcSuUS0gs8FeO5Gfacwn857JqMcgwxwH8J2S0IXI+l2YREs J4xPMeiqMkTJo9tipGj1cVHTG4HuQ7xL5gmDYDXd0Qgz9DGF6mGrQnuiK6S/M9SXJNa/ 5Plw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0BksNA5S+udLGQFWNRur5mtnPIKBdIcol8nSGG5bpXY=; b=BCs9WeaozTEpO6W4qW0xw6IHdf+8EtF0P6/Rbua4pelLsfwAXByahZDUOZaUm/BH21 gaQ+aV9TVzDJCnwWcWrfEBqW1XUrjYRQJDn6eUZNvNL2yC6acRAiJs2oURCGNov5TF0O hSa5JnSM7+QCeNS2jVKB7vWp6+cSrw2db+NBmorp1F4itd347cvpxrsnkr4HQpIQ9+j/ xSZN1mqw1vVHVj2nMYDpA21geZwc/rInXP74Af44kNg+89UGgOhUqx5VQOz2NMqhVhJH neIDOMwRQW/LK7J+ciDvIhtVulIqEp7HReHtIvvN2vGY0pV2bBKylPtn2+lD1Tm80r4U B2FQ== X-Gm-Message-State: AOAM532+Y9lKaqjhibu/g2Nv1OdmjnhA8vtakJ7dVOvB6IrN5+fqxKcf 8rwsUgc1RqiOJ5py15DLAwOjuaDt9DJNjAdG7lIB X-Google-Smtp-Source: ABdhPJzS/fNYvMDz6oqEtIhz9NPgu0S5jmTalBOZ2xNAdzuLu5p/7iYGcqIQC9Hrn+co7coW1V3/d/BiY9Cpa3vTwNA= X-Received: by 2002:a05:6402:4390:: with SMTP id o16mr5915559edc.343.1643334831162; Thu, 27 Jan 2022 17:53:51 -0800 (PST) MIME-Version: 1.0 References: <20220120214948.3637895-1-smayhew@redhat.com> <20220120214948.3637895-2-smayhew@redhat.com> In-Reply-To: From: Paul Moore Date: Thu, 27 Jan 2022 20:53:40 -0500 Message-ID: Subject: Re: [PATCH RFC v2 1/2] selinux: Fix selinux_sb_mnt_opts_compat() To: Scott Mayhew Cc: selinux@vger.kernel.org, linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 26, 2022 at 3:42 PM Scott Mayhew wrote: > On Tue, 25 Jan 2022, Paul Moore wrote: > > On Tue, Jan 25, 2022 at 1:51 PM Scott Mayhew wrote: > > > On Tue, 25 Jan 2022, Paul Moore wrote: > > > > On Tue, Jan 25, 2022 at 12:31 PM Scott Mayhew wrote: > > > > > On Mon, 24 Jan 2022, Paul Moore wrote: > > > > > > On Thu, Jan 20, 2022 at 4:50 PM Scott Mayhew wrote: ... > Sorry for being unclear. The parts where the sids are (potentially) > being parsed are inside an "if (opts) { ... }" block... but later in the > function those sids are used in various tests/assignments. So if we > wanted to eliminate the four local context_sid variables (using the > variables in opts instead), then there would need to be additional > checks to avoid dereferencing opts when it's NULL. Okay, gotcha. I think keeping the local variables is the right thing to do. My apologies for not noticing that earlier. -- paul-moore.com