From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BB2A0C2D0EB for ; Sun, 29 Mar 2020 03:11:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 91D9920717 for ; Sun, 29 Mar 2020 03:11:57 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=paul-moore-com.20150623.gappssmtp.com header.i=@paul-moore-com.20150623.gappssmtp.com header.b="m1tGNjwy" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727335AbgC2DLz (ORCPT ); Sat, 28 Mar 2020 23:11:55 -0400 Received: from mail-ed1-f68.google.com ([209.85.208.68]:36415 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727048AbgC2DLz (ORCPT ); Sat, 28 Mar 2020 23:11:55 -0400 Received: by mail-ed1-f68.google.com with SMTP id i7so11743522edq.3 for ; Sat, 28 Mar 2020 20:11:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=paul-moore-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=QCNJAUmnzDN9FZcZL525t31JITbaUoqdlbI+Ngrcb2Q=; b=m1tGNjwy+SOvZqLF6fO17u3ClF2d67j8aXHoHY1dw1Akc1hbsGxDZMYPC2VBMObQfV ova0wmjBzwcmQkBSnqv1BIYenDPMnjgFm5l+U579QF6Ziw8gRaW1IHMK5R1Rkqof/jk0 k02MdWhDxlczwjxkzuy/MjRfDqDVz1w8DE1pf8DCkRBRStH3S/Cj8rVhzHPa6zewSMbN 41OZmsDyXigpVVvfjIF7+bCqUWin8T2D0rE08sf8lEvHTDizePb4Hxf11vCqV7lbLwlN nyaZ+aCdVU80g51lvj3HKJl/l7o6U5YZsi89i6/CssH3Nr+hTKMar4D17vXJEeLcmBTm ScOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=QCNJAUmnzDN9FZcZL525t31JITbaUoqdlbI+Ngrcb2Q=; b=KWsNTgiqlaemJyt/e0okZYR4viLMvCPwXUjF3EKlUq9L8aKZfCHi0WBUS+S7WXUm2X H6FZwv5huu3FRDFpJAZSMg1zQynsr/0bbpKE+LUryMSigWcuqD7laAlzaYz3mrfvF28y gAPIVB9hg7bteJhAkdPPk7rh3L90cip7xKKEbHt9hmfSdcVI2IgcYimRrbrttgshu3fT s19VJGoeV6aiPNlJtWoRTvlGEAXSqrgsDSG2GqWkWG95xn/8K+UwL5ndxA9wWQkvHQBZ FyuWdSkvwv/j4TSky/di6o3mSK6qyIlPccMah1knLqsYGXQha1GNAjV4E5WeckZwT8Mz 3JeA== X-Gm-Message-State: ANhLgQ0E6bxvWCPMFD0jdl48zntjdlB/kj1LnnPvDUEEG8jQfFG7bHP9 b1jPBhqkzG7XvwnBpZwBDV7sC9GfBBbpdgpzG2qy X-Google-Smtp-Source: ADFU+vsO3z8fR85BdzrdW8wO5Ic5j66UK7NtBXWnojiKMj/pMltL8hW55ibXGgej7CzgWStIAOOuND+xZVVbglX1ybU= X-Received: by 2002:a17:906:1993:: with SMTP id g19mr5774145ejd.70.1585451512568; Sat, 28 Mar 2020 20:11:52 -0700 (PDT) MIME-Version: 1.0 References: <20200312193037.2tb5f53yeisfq4ta@madcap2.tricolour.ca> <20200313185900.y44yvrfm4zxa5lfk@madcap2.tricolour.ca> <20200318212630.mw2geg4ykhnbtr3k@madcap2.tricolour.ca> <20200318215550.es4stkjwnefrfen2@madcap2.tricolour.ca> <20200319220249.jyr6xmwvflya5mks@madcap2.tricolour.ca> <20200324210152.5uydf3zqi3dwshfu@madcap2.tricolour.ca> In-Reply-To: <20200324210152.5uydf3zqi3dwshfu@madcap2.tricolour.ca> From: Paul Moore Date: Sat, 28 Mar 2020 23:11:41 -0400 Message-ID: Subject: Re: [PATCH ghak90 V8 07/16] audit: add contid support for signalling the audit daemon To: Richard Guy Briggs Cc: nhorman@tuxdriver.com, linux-api@vger.kernel.org, containers@lists.linux-foundation.org, LKML , dhowells@redhat.com, linux-audit@redhat.com, netfilter-devel@vger.kernel.org, ebiederm@xmission.com, simo@redhat.com, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, Eric Paris , mpatel@redhat.com, Serge Hallyn Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 24, 2020 at 5:02 PM Richard Guy Briggs wrote: > On 2020-03-23 20:16, Paul Moore wrote: > > On Thu, Mar 19, 2020 at 6:03 PM Richard Guy Briggs wrote: > > > On 2020-03-18 18:06, Paul Moore wrote: > > > > ... > > > > > > I hope we can do better than string manipulations in the kernel. I'd > > > > much rather defer generating the ACID list (if possible), than > > > > generating a list only to keep copying and editing it as the record is > > > > sent. > > > > > > At the moment we are stuck with a string-only format. > > > > Yes, we are. That is another topic, and another set of changes I've > > been deferring so as to not disrupt the audit container ID work. > > > > I was thinking of what we do inside the kernel between when the record > > triggering event happens and when we actually emit the record to > > userspace. Perhaps we collect the ACID information while the event is > > occurring, but we defer generating the record until later when we have > > a better understanding of what should be included in the ACID list. > > It is somewhat similar (but obviously different) to what we do for > > PATH records (we collect the pathname info when the path is being > > resolved). > > Ok, now I understand your concern. > > In the case of NETFILTER_PKT records, the CONTAINER_ID record is the > only other possible record and they are generated at the same time with > a local context. > > In the case of any event involving a syscall, that CONTAINER_ID record > is generated at the time of the rest of the event record generation at > syscall exit. > > The others are only generated when needed, such as the sig2 reply. > > We generally just store the contobj pointer until we actually generate > the CONTAINER_ID (or CONTAINER_OP) record. Perhaps I'm remembering your latest spin of these patches incorrectly, but there is still a big gap between when the record is generated and when it is sent up to the audit daemon. Most importantly in that gap is the whole big queue/multicast/unicast mess. You don't need to show me code, but I would like to see some sort of plan for dealing with multiple nested audit daemons. Basically I just want to make sure we aren't painting ourselves into a corner with this approach; and if for some horrible reason we are, I at least want us to be aware of what we are getting ourselves into. -- paul moore www.paul-moore.com