From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756381AbcHaUWl (ORCPT ); Wed, 31 Aug 2016 16:22:41 -0400 Received: from mail-oi0-f68.google.com ([209.85.218.68]:35442 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753202AbcHaUWi (ORCPT ); Wed, 31 Aug 2016 16:22:38 -0400 MIME-Version: 1.0 X-Originating-IP: [108.49.39.189] In-Reply-To: References: <1471962039-14940-1-git-send-email-mguzik@redhat.com> From: Paul Moore Date: Wed, 31 Aug 2016 16:22:23 -0400 Message-ID: Subject: Re: [PATCHv2 0/2] introduce get_task_exe_file and use it to fix audit_exe_compare To: Mateusz Guzik , linux-kernel@vger.kernel.org Cc: Konstantin Khlebnikov , Richard Guy Briggs , oleg@redhat.com, luto@amacapital.net, linux-audit@redhat.com, ebiederm@xmission.com, Al Viro Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Aug 29, 2016 at 6:50 PM, Paul Moore wrote: > On Tue, Aug 23, 2016 at 10:20 AM, Mateusz Guzik wrote: >> audit_exe_compare directly accesses mm->exe_file without making sure the >> object is stable. Fixing it using current primitives results in >> partially duplicating what proc_exe_link is doing. >> >> As such, introduce a trivial helper which can be used in both places and >> fix the func. >> >> Changes since v1: >> * removed an unused 'out' label which crept in >> >> Mateusz Guzik (2): >> mm: introduce get_task_exe_file >> audit: fix exe_file access in audit_exe_compare >> >> fs/proc/base.c | 7 +------ >> include/linux/mm.h | 1 + >> kernel/audit_watch.c | 8 +++++--- >> kernel/fork.c | 23 +++++++++++++++++++++++ >> 4 files changed, 30 insertions(+), 9 deletions(-) > > Thanks for doing this. > > Both patches look fine to me, does anyone in the mm area have any > objections? If not, I'll merge these into the audit tree and mark > them for stable. I just merged these patches into audit#stable-4.8 and have a kernel building now, as soon as it finishes I'll do some quick sanity tests and send them off to Linus. -- paul moore www.paul-moore.com