From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752571AbdC2OwH (ORCPT ); Wed, 29 Mar 2017 10:52:07 -0400 Received: from mail-vk0-f67.google.com ([209.85.213.67]:33527 "EHLO mail-vk0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752473AbdC2OwF (ORCPT ); Wed, 29 Mar 2017 10:52:05 -0400 MIME-Version: 1.0 X-Originating-IP: [108.49.102.27] In-Reply-To: <6aec69ea-27e6-da3f-8a54-e1f12c78cc2e@users.sourceforge.net> References: <6aec69ea-27e6-da3f-8a54-e1f12c78cc2e@users.sourceforge.net> From: Paul Moore Date: Wed, 29 Mar 2017 10:52:03 -0400 Message-ID: Subject: Re: [PATCH 26/46] selinux: Improve another size determination in sens_read() To: SF Markus Elfring Cc: linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, Eric Paris , James Morris , "Serge E. Hallyn" , Stephen Smalley , William Roberts , LKML , kernel-janitors@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 15, 2017 at 10:26 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 21:52:55 +0100 > > Replace the specification of a data type by a pointer dereference > as the parameter for the operator "sizeof" to make the corresponding size > determination a bit safer according to the Linux coding style convention. > > Signed-off-by: Markus Elfring > --- > security/selinux/ss/policydb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Merged, thanks. > diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c > index 5caa1fa5ea80..edfcfd3bbc60 100644 > --- a/security/selinux/ss/policydb.c > +++ b/security/selinux/ss/policydb.c > @@ -1609,7 +1609,7 @@ static int sens_read(struct policydb *p, struct hashtab *h, void *fp) > goto bad; > > rc = -ENOMEM; > - levdatum->level = kmalloc(sizeof(struct mls_level), GFP_ATOMIC); > + levdatum->level = kmalloc(sizeof(*levdatum->level), GFP_ATOMIC); > if (!levdatum->level) > goto bad; > > -- > 2.11.0 > -- paul moore www.paul-moore.com