From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933963AbdCWVd5 (ORCPT ); Thu, 23 Mar 2017 17:33:57 -0400 Received: from mail-vk0-f65.google.com ([209.85.213.65]:34291 "EHLO mail-vk0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756818AbdCWVdy (ORCPT ); Thu, 23 Mar 2017 17:33:54 -0400 MIME-Version: 1.0 X-Originating-IP: [108.49.102.27] In-Reply-To: References: From: Paul Moore Date: Thu, 23 Mar 2017 17:33:52 -0400 Message-ID: Subject: Re: [PATCH 09/46] selinux: Delete an error message for a failed memory allocation in policydb_read() To: SF Markus Elfring Cc: linux-security-module@vger.kernel.org, selinux@tycho.nsa.gov, Eric Paris , James Morris , "Serge E. Hallyn" , Stephen Smalley , William Roberts , LKML , kernel-janitors@vger.kernel.org, Wolfram Sang Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 15, 2017 at 10:07 AM, SF Markus Elfring wrote: > From: Markus Elfring > Date: Sat, 14 Jan 2017 14:20:41 +0100 > > Omit an extra message for a memory allocation failure in this function. > > Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf > Signed-off-by: Markus Elfring > --- > security/selinux/ss/policydb.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) I'm not going to remove an error message without some better reasoning in the patch description. Providing a link to slides is fine, but your commit message needs to convey the important information and I don't think that is the case here (what happens when that URL dies?). > diff --git a/security/selinux/ss/policydb.c b/security/selinux/ss/policydb.c > index fe8992382a71..53e6d06e772a 100644 > --- a/security/selinux/ss/policydb.c > +++ b/security/selinux/ss/policydb.c > @@ -2269,11 +2269,8 @@ int policydb_read(struct policydb *p, void *fp) > > rc = -ENOMEM; > policydb_str = kmalloc(len + 1, GFP_KERNEL); > - if (!policydb_str) { > - printk(KERN_ERR "SELinux: unable to allocate memory for policydb " > - "string of length %d\n", len); > + if (!policydb_str) > goto bad; > - } > > rc = next_entry(policydb_str, fp, len); > if (rc) { > -- > 2.11.0 > -- paul moore www.paul-moore.com