From: Greentime Hu <greentime.hu@sifive.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
hes@sifive.com, Erik Danie <erik.danie@sifive.com>,
Zong Li <zong.li@sifive.com>, Bjorn Helgaas <bhelgaas@google.com>,
robh+dt@kernel.org, Albert Ou <aou@eecs.berkeley.edu>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>,
alex.dewar90@gmail.com, khilman@baylibre.com,
hayashi.kunihiko@socionext.com, vidyas@nvidia.com,
jh80.chung@samsung.com, linux-pci@vger.kernel.org,
devicetree@vger.kernel.org,
linux-riscv <linux-riscv@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-clk@vger.kernel.org
Subject: Re: [PATCH v5 0/6] Add SiFive FU740 PCIe host controller driver support
Date: Tue, 4 May 2021 18:58:48 +0800 [thread overview]
Message-ID: <CAHCEehJsUFxs71MuY5f4VbDT-NroCzJ=mnbbYYa4VwT-QWcQNw@mail.gmail.com> (raw)
In-Reply-To: <20210504101201.GA20729@lpieralisi>
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> 於 2021年5月4日 週二 下午6:12寫道:
>
> On Tue, May 04, 2021 at 03:20:00PM +0800, Greentime Hu wrote:
> > Bjorn Helgaas <helgaas@kernel.org> 於 2021年5月4日 週二 上午12:40寫道:
> > >
> > > On Tue, Apr 06, 2021 at 05:26:28PM +0800, Greentime Hu wrote:
> > > > This patchset includes SiFive FU740 PCIe host controller driver. We also
> > > > add pcie_aux clock and pcie_power_on_reset controller to prci driver for
> > > > PCIe driver to use it.
> > >
> > > I dropped this series because of the build problem I mentioned [1].
> > > It will not be included in v5.13 unless the build problem is fixed
> > > ASAP.
> > >
> > > [1] https://lore.kernel.org/r/20210428194713.GA314975@bjorn-Precision-5520
> > >
> >
> > Hi all,
> >
> > This build failed in x86_64 is because CONFIG_GPIOLIB is disabled in
> > the testing config.
> >
> > diff --git a/drivers/pci/controller/dwc/Kconfig
> > b/drivers/pci/controller/dwc/Kconfig
> > index 0a37d21ed64e..56b66e1fed53 100644
> > --- a/drivers/pci/controller/dwc/Kconfig
> > +++ b/drivers/pci/controller/dwc/Kconfig
> > @@ -323,6 +323,7 @@ config PCIE_FU740
> > depends on PCI_MSI_IRQ_DOMAIN
> > depends on SOC_SIFIVE || COMPILE_TEST
> > select PCIE_DW_HOST
> > + select GPIOLIB
>
> I think that an include:
>
> #include <linux/gpio/consumer.h>
>
> in the driver would do. Still, I believe we should also add a
> "depends on" in the Kconfig entry rather than a "select".
>
> Please let me know as soon as possible.
>
Hi Lorenzo,
Thank you for suggesting this.
I'll add the include and use "depends on" rather than a "select" and
send the v6 patch.
> Lorenzo
>
> > help
> > Say Y here if you want PCIe controller support for the SiFive
> > FU740.
> >
> > After applying this change, it can build pass.
> >
> > > > This is tested with e1000e: Intel(R) PRO/1000 Network Card, AMD Radeon R5
> > > > 230 graphics card and SP M.2 PCIe Gen 3 SSD in SiFive Unmatched based on
> > > > v5.11 Linux kernel.
> > > >
> > > > Changes in v5:
> > > > - Fix typo in comments
> > > > - Keep comments style consistent
> > > > - Refine some error handling codes
> > > > - Remove unneeded header file including
> > > > - Merge fu740_pcie_ltssm_enable implementation to fu740_pcie_start_link
> > > >
> > > > Changes in v4:
> > > > - Fix Wunused-but-set-variable warning in prci driver
> > > >
> > > > Changes in v3:
> > > > - Remove items that has been defined
> > > > - Refine format of sifive,fu740-pcie.yaml
> > > > - Replace perstn-gpios with the common one
> > > > - Change DBI mapping space to 2GB from 4GB
> > > > - Refine drivers/reset/Kconfig
> > > >
> > > > Changes in v2:
> > > > - Refine codes based on reviewers' feedback
> > > > - Remove define and use the common one
> > > > - Replace __raw_writel with writel_relaxed
> > > > - Split fu740_phyregreadwrite to write function
> > > > - Use readl_poll_timeout in stead of while loop checking
> > > > - Use dwc common codes
> > > > - Use gpio descriptors and the gpiod_* api.
> > > > - Replace devm_ioremap_resource with devm_platform_ioremap_resource_byname
> > > > - Replace devm_reset_control_get with devm_reset_control_get_exclusive
> > > > - Add more comments for delay and sleep
> > > > - Remove "phy ? x : y" expressions
> > > > - Refine code logic to remove possible infinite loop
> > > > - Replace magic number with meaningful define
> > > > - Remove fu740_pcie_pm_ops
> > > > - Use builtin_platform_driver
> > > >
> > > > Greentime Hu (5):
> > > > clk: sifive: Add pcie_aux clock in prci driver for PCIe driver
> > > > clk: sifive: Use reset-simple in prci driver for PCIe driver
> > > > MAINTAINERS: Add maintainers for SiFive FU740 PCIe driver
> > > > dt-bindings: PCI: Add SiFive FU740 PCIe host controller
> > > > riscv: dts: Add PCIe support for the SiFive FU740-C000 SoC
> > > >
> > > > Paul Walmsley (1):
> > > > PCI: fu740: Add SiFive FU740 PCIe host controller driver
> > > >
> > > > .../bindings/pci/sifive,fu740-pcie.yaml | 113 +++++++
> > > > MAINTAINERS | 8 +
> > > > arch/riscv/boot/dts/sifive/fu740-c000.dtsi | 33 ++
> > > > drivers/clk/sifive/Kconfig | 2 +
> > > > drivers/clk/sifive/fu740-prci.c | 11 +
> > > > drivers/clk/sifive/fu740-prci.h | 2 +-
> > > > drivers/clk/sifive/sifive-prci.c | 54 +++
> > > > drivers/clk/sifive/sifive-prci.h | 13 +
> > > > drivers/pci/controller/dwc/Kconfig | 9 +
> > > > drivers/pci/controller/dwc/Makefile | 1 +
> > > > drivers/pci/controller/dwc/pcie-fu740.c | 308 ++++++++++++++++++
> > > > drivers/reset/Kconfig | 1 +
> > > > include/dt-bindings/clock/sifive-fu740-prci.h | 1 +
> > > > 13 files changed, 555 insertions(+), 1 deletion(-)
> > > > create mode 100644 Documentation/devicetree/bindings/pci/sifive,fu740-pcie.yaml
> > > > create mode 100644 drivers/pci/controller/dwc/pcie-fu740.c
> > > >
> > > > --
> > > > 2.30.2
> > > >
prev parent reply other threads:[~2021-05-04 10:59 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 9:26 [PATCH v5 0/6] Add SiFive FU740 PCIe host controller driver support Greentime Hu
2021-04-06 9:26 ` [PATCH v5 1/6] clk: sifive: Add pcie_aux clock in prci driver for PCIe driver Greentime Hu
2021-04-06 9:26 ` [PATCH v5 2/6] clk: sifive: Use reset-simple " Greentime Hu
2021-04-06 9:26 ` [PATCH v5 3/6] MAINTAINERS: Add maintainers for SiFive FU740 " Greentime Hu
2021-04-06 9:26 ` [PATCH v5 4/6] dt-bindings: PCI: Add SiFive FU740 PCIe host controller Greentime Hu
2021-04-08 15:58 ` Rob Herring
2021-04-06 9:26 ` [PATCH v5 5/6] PCI: fu740: Add SiFive FU740 PCIe host controller driver Greentime Hu
2021-04-08 15:27 ` Rob Herring
2021-04-28 19:47 ` Bjorn Helgaas
2021-04-29 14:59 ` Lorenzo Pieralisi
2021-04-29 15:15 ` Bjorn Helgaas
2021-04-29 16:40 ` Lorenzo Pieralisi
2021-04-29 20:18 ` Bjorn Helgaas
2021-04-06 9:26 ` [PATCH v5 6/6] riscv: dts: Add PCIe support for the SiFive FU740-C000 SoC Greentime Hu
2021-04-08 16:25 ` [PATCH v5 0/6] Add SiFive FU740 PCIe host controller driver support Lorenzo Pieralisi
2021-04-09 2:23 ` Greentime Hu
2021-04-09 8:54 ` Lorenzo Pieralisi
2021-04-12 2:37 ` Greentime Hu
2021-04-23 4:43 ` Palmer Dabbelt
2021-04-23 5:10 ` Palmer Dabbelt
2021-04-23 6:00 ` Greentime Hu
2021-04-23 9:39 ` Lorenzo Pieralisi
2021-05-03 16:40 ` Bjorn Helgaas
2021-05-04 7:20 ` Greentime Hu
2021-05-04 10:12 ` Lorenzo Pieralisi
2021-05-04 10:58 ` Greentime Hu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHCEehJsUFxs71MuY5f4VbDT-NroCzJ=mnbbYYa4VwT-QWcQNw@mail.gmail.com' \
--to=greentime.hu@sifive.com \
--cc=alex.dewar90@gmail.com \
--cc=aou@eecs.berkeley.edu \
--cc=bhelgaas@google.com \
--cc=devicetree@vger.kernel.org \
--cc=erik.danie@sifive.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=helgaas@kernel.org \
--cc=hes@sifive.com \
--cc=jh80.chung@samsung.com \
--cc=khilman@baylibre.com \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=mturquette@baylibre.com \
--cc=p.zabel@pengutronix.de \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=vidyas@nvidia.com \
--cc=zong.li@sifive.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).