From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C30A5C2BA83 for ; Wed, 12 Feb 2020 13:09:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 931492073C for ; Wed, 12 Feb 2020 13:09:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="uwP0fhVr" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727946AbgBLNJD (ORCPT ); Wed, 12 Feb 2020 08:09:03 -0500 Received: from mail-il1-f193.google.com ([209.85.166.193]:42777 "EHLO mail-il1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727439AbgBLNJC (ORCPT ); Wed, 12 Feb 2020 08:09:02 -0500 Received: by mail-il1-f193.google.com with SMTP id x2so1651020ila.9; Wed, 12 Feb 2020 05:09:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lwgzXOkICXCQfXrNHWXrCftoLfH9Scd8moCWKuZ8A7c=; b=uwP0fhVrX+cKaPrA9gZuzCsKp0yddAX94jEyXD+oxpoLTWMMqVteKVFhQIfbax7itw LTgnQhEBPH1h/TZFReuXAGeaSeQs3IeZGCBz9HlL5RRSoErDbx/VHPZz1N9s6W4tavzm tRI7PsSWpP61qEZOKSCUIjyPXdiR1pfk5omo4L+DP4BGIMk76I6FO9jnbIsamlo43As1 vE6g7V0GDiRYWnLArr4NKRwoaRkGq92lsMI7sj8ISNP5sQit0d+XhUhDDSwyBqtr8A82 nPjSpLQlG48uHNHO8yaTHauwI0bT2iFl7Ih0ObcSXH56oeHLWsj+0PBQvlsD3p8ywO9E l4Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lwgzXOkICXCQfXrNHWXrCftoLfH9Scd8moCWKuZ8A7c=; b=gMSxSAJlcotjlHnEVv4knvm6hBWseH2/ENnizaX0ZtI8nl/eWsHUcAz/OgU9o6igbs BNnsb75X6D0XVW/8ZgCSuNvj0ioGf9tZ9Mek7jVaUsJlUIhT76Fb81YYK8YcRnia7xHl ZS73qHt4U9lJDOZZM5Cvk7pa64DWSkvGmumRaPlyk5UpDtrWZeJE7CC7Q2d4dgtU6EwM XETdltm9CTVNNV6i7WZUIw4d2c+qKNeG0QVCTMG6W2xO7oC9qPm338XfHkpI3Zhr5D68 9l0XleyQWrwnzGs8I0GA/GXOfvF3LfEo0IcWLGS9gHp0Tar62FoQHwxnW5Wg0XOA8fZ9 H2+w== X-Gm-Message-State: APjAAAUr15ZKzOWB+AiyYZpD5asE3nME4W2qHbhruuBef3EBBDkRngd5 IshdkEympbD/3S1v1VKaf+E+fK+y1ZGgwkf6gnM= X-Google-Smtp-Source: APXvYqzwGZCfLCucPj5npcA6pFh/Daw5mAO0fUTiKusa4iACLpoLiJs+a3YdEul7VJ0Sa7qkhI7BVMm1OAQ3UfESN3g= X-Received: by 2002:a92:350d:: with SMTP id c13mr11345711ila.205.1581512940477; Wed, 12 Feb 2020 05:09:00 -0800 (PST) MIME-Version: 1.0 References: <20200202125950.1825013-1-aford173@gmail.com> <20200202125950.1825013-2-aford173@gmail.com> <20200212120753.GF4028@sirena.org.uk> In-Reply-To: <20200212120753.GF4028@sirena.org.uk> From: Adam Ford Date: Wed, 12 Feb 2020 07:08:49 -0600 Message-ID: Subject: Re: [PATCH V2 2/5] spi: fspi: dynamically alloc AHB memory To: Mark Brown Cc: Fabio Estevam , linux-spi , Han Xu , Yogesh Gaur , Ashish Kumar , Rob Herring , Mark Rutland , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , NXP Linux Team , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-kernel , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Feb 12, 2020 at 6:07 AM Mark Brown wrote: > > On Mon, Feb 03, 2020 at 04:53:34AM -0600, Adam Ford wrote: > > > My motivation is to get the flexspi on the i.MX8MM to work, and I did > > a list of the patches applied on the NXP branch to see what was > > applied on top of their 4.19 kernel and this patch series generated > > from that list. Most of the NXP commits are one-line commits, and I > > don't know the motivation for what's happening. NXP did it, and I > > know it works on the Flexspi driver. > > Adding new compatibles and so on seems fine but the patches making > random changes without explanation like the one for octal mode I just > replied to are more worrying, do they work with older versions of the IP > or in all use cases for example? I'd suggest cutting the initial patch > series down to the bare minimum needed to get things working and then > building on top of that if that's not already been done. The original author was copied on the initial commit. I literally generated the patch from NXP's branch, added my notes, and pushed them to the mailing lists after testing them on the the Linux master branch. I am a bit disappointed that NXP's author hasn't responded to any of the comments or feedback. NXP knows their hardware and better understands the details as to what is happening and why. In any case, I'll try to scale the patch series back to just enough to get it working on the i.MX8M Mini. I'll expand a bit on the commit message based on what I've learned about the various in-implemented quirks and send a V2 series. adam