From: Adam Ford <aford173@gmail.com>
To: Shawn Guo <shawnguo@kernel.org>
Cc: arm-soc <linux-arm-kernel@lists.infradead.org>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
devicetree <devicetree@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/3] ARM: DTS: imx6q-logicpd: Reduce inrush current on start
Date: Wed, 20 Mar 2019 08:41:27 -0500 [thread overview]
Message-ID: <CAHCN7x+DKh8bR17C90o-zKKnFqWe_Yz5EM68xEiSY0W6ufNARA@mail.gmail.com> (raw)
In-Reply-To: <20190320124446.GO4980@dragon>
On Wed, Mar 20, 2019 at 7:45 AM Shawn Guo <shawnguo@kernel.org> wrote:
>
> On Wed, Mar 06, 2019 at 08:04:00AM -0600, Adam Ford wrote:
> > The main 3.3V regulator sources a series of additional regulators.
> > This patch adds a small delay, so when the 3.3V regulator comes
> > on it delays a bit before the subsequent regulators can come on.
> > This reduces the inrush current a bit on the external DC power
> > supply.
> >
> > Fixes: 1c207f911fe9 ("ARM: dts: imx: Add support for Logic PD
> > i.MX6QD EVM")
>
> Same comment as patch #1.
The sourcing regulator occasionally cuts out because the inrush is so
high. I would argue that preventing a hardware issue like that would
be a 'fix' and if it helps, I could add that to the description.
>
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
>
> To match the convention, the 'DTS' in subject prefix should be
> lowercase.
I will fix in V2.
>
> Shawn
adam
>
> >
> > diff --git a/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi b/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
> > index fb01fa6e4224..e31b6923cb72 100644
> > --- a/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
> > +++ b/arch/arm/boot/dts/imx6-logicpd-baseboard.dtsi
> > @@ -99,6 +99,7 @@
> > regulator-min-microvolt = <3300000>;
> > regulator-max-microvolt = <3300000>;
> > gpio = <&gpio1 26 GPIO_ACTIVE_HIGH>;
> > + startup-delay-us = <70000>;
> > enable-active-high;
> > regulator-always-on;
> > };
> > --
> > 2.17.1
> >
next prev parent reply other threads:[~2019-03-20 13:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-06 14:03 [PATCH 1/3] ARM: dts: imx6q-logicpd: Shutdown LCD regulator during suspend Adam Ford
2019-03-06 14:04 ` [PATCH 2/3] ARM: DTS: imx6q-logicpd: Reduce inrush current on start Adam Ford
2019-03-20 12:44 ` Shawn Guo
2019-03-20 13:41 ` Adam Ford [this message]
2019-03-20 14:57 ` Shawn Guo
2019-03-06 14:04 ` [PATCH 3/3] ARM: DTS: imx6q-logicpd: Fix Analog audio capture Adam Ford
2019-03-20 12:46 ` Shawn Guo
2019-03-20 12:42 ` [PATCH 1/3] ARM: dts: imx6q-logicpd: Shutdown LCD regulator during suspend Shawn Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHCN7x+DKh8bR17C90o-zKKnFqWe_Yz5EM68xEiSY0W6ufNARA@mail.gmail.com \
--to=aford173@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=festevam@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).