From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C0BDC433B4 for ; Tue, 20 Apr 2021 03:33:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4B142611EE for ; Tue, 20 Apr 2021 03:33:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230045AbhDTDdt (ORCPT ); Mon, 19 Apr 2021 23:33:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229508AbhDTDdr (ORCPT ); Mon, 19 Apr 2021 23:33:47 -0400 Received: from mail-ed1-x52d.google.com (mail-ed1-x52d.google.com [IPv6:2a00:1450:4864:20::52d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 66580C06174A; Mon, 19 Apr 2021 20:33:16 -0700 (PDT) Received: by mail-ed1-x52d.google.com with SMTP id k17so3756004edr.7; Mon, 19 Apr 2021 20:33:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lfSWPoNQHoy2n1intU3LcdvNNV3gtVsZpBy2B8GfaFk=; b=aZUbYjCAjxOn2sQ1zudu3xjH2eve7n4UhLosKL3z5XtkdP9W6MtXSK5QpRnxIQidBo VqJcudb4C9ipBzJ7djiokHvrZPuCucgfndCx5HurEqyLgmhWY0zjqifgrpEzE85NMQCG 7f2eV9qjWgqat+1+6mfc3xMni/cIPvENQTbsJCQbSHigRyvgnoTa5rOj5VZHkPBVFkpB fFPrBFdA4ku77RGUk+c45omhWi+NfcXdA49L+1uGm229KdZWa7hXpxeQBcJyqRQOi+WP 2NUmk6fYIWqGVGSs9D9OAwFt0kNmPDV+R/BOHmh87ZYKRG4Q1T4+jCWofJTRtPayeZe8 1rYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lfSWPoNQHoy2n1intU3LcdvNNV3gtVsZpBy2B8GfaFk=; b=ppGTdfnizllBKjtC5VGpglmdgVD9ALydAM1wl2u0Lv5sUPXwkaYRGNFDqYyjfoS/kF e7VP574s3od6z50t3pzaVJmvilkyS2vLXPNVjiilQxZX1mWN93Fzswd5Gca27ZrqKguv DqhTcszT9feJvTNBhsH+GHF8yML5MbKCbeTWbpUP0y5Isc/1Nzvrb0p6OD28QF8RlZr0 orArvKkRjz8o0CM/jO2yQKTTpJYpr4aae96HfnpkOCkVBPn9WNrOiOFAs67AARTrenAw QY5YDUzp5pH4o3WM9TLrbg7O+XJACifcjcs2RT091YD12+BzYXLe7m1B9puRKsJU4JDY /Q1Q== X-Gm-Message-State: AOAM532InPuRRHE+U8/Ib2VddlAng8mSueZtDynB+UyaUOBfgZQFS8eS OTDo0cB4ixWfWKkNUSZl9+0gVGCPX/nVwDaE5gg= X-Google-Smtp-Source: ABdhPJzAzpucWx4ETz4/sy2d0XTjM8gyFLIRFAHt/G9Pw9nZgXyCsdewIbOaT+9q9+VwvrhA7uws6Ut8jEG29a5pazk= X-Received: by 2002:aa7:cc98:: with SMTP id p24mr29372685edt.187.1618889593171; Mon, 19 Apr 2021 20:33:13 -0700 (PDT) MIME-Version: 1.0 References: <20210417132329.6886-1-aford173@gmail.com> <20210419.154545.1437529237095871426.davem@davemloft.net> In-Reply-To: <20210419.154545.1437529237095871426.davem@davemloft.net> From: Adam Ford Date: Mon, 19 Apr 2021 22:33:00 -0500 Message-ID: Subject: Re: [PATCH] net: ethernet: ravb: Fix release of refclk To: David Miller Cc: netdev , Adam Ford-BE , Geert Uytterhoeven , Sergei Shtylyov , Jakub Kicinski , Andrew Lunn , Linux-Renesas , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Apr 19, 2021 at 5:45 PM David Miller wrote: > > From: Adam Ford > Date: Sat, 17 Apr 2021 08:23:29 -0500 > > > The call to clk_disable_unprepare() can happen before priv is > > initialized. This means moving clk_disable_unprepare out of > > out_release into a new label. > > > > Fixes: 8ef7adc6beb2("net: ethernet: ravb: Enable optional refclk") > > Signed-off-by: Adam Ford > Thjis does not apply cleanly, please rebbase and resubmit. Which branch should I use as the rebase? I used net-next because that's where the bug is, but I know it changes frequently. > > Please fix the formatting of your Fixes tag while you are at it, thank you. no problem. Sorry about that adam