From: Adam Ford <aford173@gmail.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Linux-OMAP <linux-omap@vger.kernel.org>,
"Adam Ford-BE" <aford@beaconembedded.com>,
"Benoît Cousson" <bcousson@baylibre.com>,
"Rob Herring" <robh+dt@kernel.org>,
"Paul Walmsley" <paul@pwsan.com>,
"Russell King" <linux@armlinux.org.uk>,
devicetree <devicetree@vger.kernel.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
arm-soc <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] ARM: dts: omap3: Migrate AES from hwmods to sysc-omap2
Date: Tue, 5 May 2020 16:17:19 -0500 [thread overview]
Message-ID: <CAHCN7xJxg+uO4h2RcapyjormTMzXFwoMUOi7rh2hUsScJtK56Q@mail.gmail.com> (raw)
In-Reply-To: <20200505184223.GR37466@atomide.com>
On Tue, May 5, 2020 at 1:42 PM Tony Lindgren <tony@atomide.com> wrote:
>
> * Adam Ford <aford173@gmail.com> [200504 16:02]:
> > Various OMAP3 boards have two AES blocks, but only one is currently
> > available, because the hwmods are only configured for one.
> >
> > This patch migrates the hwmods for the AES engine to sysc-omap2
> > which allows the second AES crypto engine to become available.
> >
> > omap-aes 480a6000.aes1: OMAP AES hw accel rev: 2.6
> > omap-aes 480a6000.aes1: will run requests pump with realtime priority
> > omap-aes 480c5000.aes2: OMAP AES hw accel rev: 2.6
> > omap-aes 480c5000.aes2: will run requests pump with realtime priority
>
> Great :) Looks like I'm getting the following though:
>
> DTC arch/arm/boot/dts/am3517-craneboard.dtb
> arch/arm/boot/dts/omap3.dtsi:160.39-184.5: ERROR (phandle_references):
> /ocp@68000000/target-module@480a6000:
> Reference to non-existent node or label "aes1_ick"
>
> Is this patch maybe missing a change for am3717 for the aes1_ick?
I am guessing it's the same issue that plagues the am3517 with a note
in the hwmods that stated noone seems to know which am3517's support
it and which don't. The RNG was disabled on the 3517, so I am
guessing I'll do the same for AES.
I should have posted it as an RFC, because I don't have the proper IRQ
setup for the newly supported AES engine. The interrupts that are
used for the original AES are listed as 'Resereved' in the AM3517 TRM.
I assume the second engine uses different interrupts. I don't suppose
anyone know what it should be?
adam
>
> Regards,
>
> Tony
next prev parent reply other threads:[~2020-05-05 21:17 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-04 23:01 [PATCH] ARM: dts: omap3: Migrate AES from hwmods to sysc-omap2 Adam Ford
2020-05-05 18:42 ` Tony Lindgren
2020-05-05 21:17 ` Adam Ford [this message]
2020-05-05 23:34 ` Tony Lindgren
2020-06-13 11:10 ` Adam Ford
2020-06-13 15:50 ` Tony Lindgren
2020-06-17 10:58 Adam Ford
2020-06-17 17:26 ` kernel test robot
2020-06-29 18:12 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHCN7xJxg+uO4h2RcapyjormTMzXFwoMUOi7rh2hUsScJtK56Q@mail.gmail.com \
--to=aford173@gmail.com \
--cc=aford@beaconembedded.com \
--cc=bcousson@baylibre.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=paul@pwsan.com \
--cc=robh+dt@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).