From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9C40C5ACAE for ; Wed, 11 Sep 2019 15:56:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 76DAA20872 for ; Wed, 11 Sep 2019 15:56:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="p3acxjl1" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728863AbfIKP4X (ORCPT ); Wed, 11 Sep 2019 11:56:23 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:37715 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727839AbfIKP4X (ORCPT ); Wed, 11 Sep 2019 11:56:23 -0400 Received: by mail-io1-f67.google.com with SMTP id r4so46972661iop.4; Wed, 11 Sep 2019 08:56:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=mzTiwpJgDw1EATMRIrpLBFsul5Dt2y/EocbWcXzqDUM=; b=p3acxjl1SUpYGk4WZpSQ5CYEdDy0jwrmceX1Dvu62YVs/ugom+Z37BMY/CLbo+pxIm fJw4t7nHUrbxiyc+ZTa0myoSgxD0eo21B2x8snthbA0KmtYKugZxjirLRYVHOL2iHVL8 tbNof/c70lpxHEnmqrf+rucXWFZIRRPjNFF5x8d4DR4hy+vSjtkFB3hBVB+2z3mASwxQ SIyB/ITsw188Ylh4hWQy1vCABgPsqSDk9ZEX3dnzCngiww+mG0FjKQu4BfV0oBYtUcy2 49gITuuMkF8TrTQcsZazlcTWK8pfD5RUpyGOfhuHWsRBdbMmFCTaOIY4cl3hmLWnaRQ1 J4hw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=mzTiwpJgDw1EATMRIrpLBFsul5Dt2y/EocbWcXzqDUM=; b=aSLsRAaITaCmZt77ruSvow2Hk0UComKdLC5ksmYm32Uq3T7u9+bHic9X7ntxjDcdc7 SHTDhxO+DxoqDm3Y2Hg3Zi9qAiqqPvCCpfrZHsxxzqIYbI+67shZpecmChwH/y7vk4MA VeLSBLEJlpp7Bu3lgwKQFtjKAuiTyk+X6Wz2ku7fsuiWiYys/js+1c2vdYwyPIOOEjZ1 yqNwtA3mhwIFK6+e/42JU/2PeGQqZpVhRWrYNRjHrFtIddekhufS6AAIuBg5UsF+Syjh AKuQqsOHY+uuKcGN37PWtn3IluZBTLDuKIQRS/8agBWKDN8vQ3APa7zURz+SB1GNYi4l du9w== X-Gm-Message-State: APjAAAWPYwzPUHSIZfHV0uUlUnWHB1+I2cWBqxHxi48Q0rRRG5FiV7F6 aEXnsxZTYQKOH1pzXMyf1WXho81seYd2wS55KJQ= X-Google-Smtp-Source: APXvYqzQ9onGKMmPm/d8IIryqyE4ifCfZ2jZZCYtYiAh2ArfhJOawrRH+g9queC7rLFvpIf61xhYSeZGnAzjZ6O37iw= X-Received: by 2002:a5e:dc47:: with SMTP id s7mr1717770iop.228.1568217381892; Wed, 11 Sep 2019 08:56:21 -0700 (PDT) MIME-Version: 1.0 References: <0C1EF64E-B33C-4BFA-A7D3-471DD1B9EE86@goldelico.com> <515048DE-138D-4400-8168-F2B7D61F1005@goldelico.com> <7B3D1D77-3E8C-444F-90B9-6DF2641178B8@goldelico.com> <87420DBD-770F-4C32-9499-A3AEA5876E8A@goldelico.com> <20190909163236.GP52127@atomide.com> <3663B13C-1AAB-4BE3-8CAD-F821B70393FA@goldelico.com> <56482888-DBD3-4658-8DB9-FB57653B5AA8@goldelico.com> <285FED38-2B2B-4813-9FD2-396C53E9B1B2@goldelico.com> <65A23326-70B4-46E3-992D-74256B056900@goldelico.com> In-Reply-To: <65A23326-70B4-46E3-992D-74256B056900@goldelico.com> From: Adam Ford Date: Wed, 11 Sep 2019 10:56:10 -0500 Message-ID: Subject: Re: [Letux-kernel] [RFC PATCH 0/3] Enable 1GHz support on omap36xx To: "H. Nikolaus Schaller" Cc: Nishanth Menon , Linux-OMAP , Tony Lindgren , Linux Kernel Mailing List , =?UTF-8?Q?Andr=C3=A9_Roth?= , Discussions about the Letux Kernel , Andreas Kemnade Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 11, 2019 at 10:46 AM H. Nikolaus Schaller wrote: > > Hi, > > > Am 11.09.2019 um 14:43 schrieb Adam Ford : > > > >> > >> I can also see that there are transitions on the voltages (reg.8 is vdd and reg.3 is abb). > > > > I concur. I have good results with the added ti,omap-opp-supply entry. > > Great! > > There are some subtleties for testing. > > * I have added turbo-mode; to OPP6 / OPP1G > * which means they are available but not used by the ondemand govenor > * to enable them one has to echo 1 >/sys/devices/system/cpu/cpufreq/boost Will that be documented somewhere? If not, can we put a comment in the device tree so people know how to enable it? > > Testing is also easily done through cpufreq-set -f 800m or-f 1g > > Then I can see the microvolts change and also registers > PRM_LDO_ABB_CTRL 0x483072F4 bit 3:0 1=bypass 5=FBB > PRM_LDO_ABB_SETUP 0x483072F0 0x00=bypass 0x11=FBB > > I have added both of this as descriptive notes to the commit messages. > > What I have to check is if it behaves as expected on a dm3730 without > 1GHz rating. I already tested it. From what I can see, it's behaving normally. > > > I noticed the FIXME note on the omap36xx.dtsi file where you added the > > vdd-supply reference. For what its worth, I searched for a list of > > all files that reference omap3630, then built a bunch of dtb's > > > > make `cat dtb-list` ARCH=arm CROSS_COMPILE="ccache arm-linux-" -j8 > > DTC arch/arm/boot/dts/omap3-beagle-xm.dtb > > DTC arch/arm/boot/dts/omap3-cm-t3730.dtb > > DTC arch/arm/boot/dts/omap3-evm-37xx.dtb > > DTC arch/arm/boot/dts/omap3-igep0020.dtb > > DTC arch/arm/boot/dts/omap3-igep0020-rev-f.dtb > > DTC arch/arm/boot/dts/omap3-igep0030.dtb > > DTC arch/arm/boot/dts/omap3-igep0030-rev-g.dtb > > DTC arch/arm/boot/dts/omap3-lilly-dbb056.dtb > > DTC arch/arm/boot/dts/omap3-n950.dtb > > DTC arch/arm/boot/dts/omap3-n9.dtb > > DTC arch/arm/boot/dts/omap3-overo-storm-alto35.dtb > > DTC arch/arm/boot/dts/omap3-overo-storm-chestnut43.dtb > > DTC arch/arm/boot/dts/omap3-overo-storm-gallop43.dtb > > DTC arch/arm/boot/dts/omap3-overo-storm-palo35.dtb > > DTC arch/arm/boot/dts/omap3-overo-storm-palo43.dtb > > DTC arch/arm/boot/dts/omap3-overo-storm-summit.dtb > > DTC arch/arm/boot/dts/omap3-overo-storm-tobi.dtb > > DTC arch/arm/boot/dts/omap3-overo-storm-tobiduo.dtb > > DTC arch/arm/boot/dts/omap3-pandora-1ghz.dtb > > DTC arch/arm/boot/dts/omap3-sbc-t3730.dtb > > DTC arch/arm/boot/dts/omap3-sniper.dtb > > DTC arch/arm/boot/dts/omap3-zoom3.dtb > > DTC arch/arm/boot/dts/omap3-gta04a5.dtb > > DTC arch/arm/boot/dts/omap3-gta04a5one.dtb > > DTC arch/arm/boot/dts/omap3-gta04a3.dtb > > DTC arch/arm/boot/dts/omap3-gta04a4.dtb > > Quite a lot... > > > I think it's probably safe to leave the vcc-supply there, but you may > > want to add a note that users who do not use twl4030 should add > > something to their device tree to specify the vcc-supply. > > > > At this point, I doubt anyone will do new designs on omap3 SoC's. > > Well, I am not sure if there are out-of-tree boards with omap3 > where we could break everything. I know of at least one such > board. > > Therefore I have looked where the cpu0-supply vs. vdd-supply > is decoded. It turns out to be also the ti-cpufreq driver > which we already tweak for omap3 support. > > So I just have to modify ca. 10 LOC to add this "cpu0" to the > SoC description tables and process it once during probe time. > > Then, it works with unmodified board.dtb > defining cpu0-supply = <&vcc> or whatever regulator. > > The only question that comes up is if this change is am3517 > compatible. I.e. can we still use the omap36xx_soc_data for > it as well which now expects two regulators... So you > might now see an error message that cpu0-supply and vbb-supply > are missing or not the right number of regulators is given. > > We may have to add an am3517_soc_data table, but that would > be straightforward now. I will run some tests on the 3517 using the 3430 table instead of the 3630. I didn't look into great detail as to what the tables do, but it might be sufficient. Otherwise, I can copy-paste the 3630 table and change the multi-regulator off and test it that way if you'd prefer. Let me know your preference, and I can do it. > > > > >> so that you can inspect/compare/test/check before I tidy up and add > >> the patches for our OPP-v2 patch set. > > > > I think it looks good. Maybe Tony and or TI people have some > > comments, but it appears to set both regulators now. > > > > Nice job! > > With your kind help! > I am glad to help. > Now it's time to wrap up and post a new PATCH set version for > review. > > Best regards, > Nikolaus >