linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Adam Ford <aford173@gmail.com>
To: Sekhar Nori <nsekhar@ti.com>
Cc: David Lechner <david@lechnology.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: davinci_all_defconfig: set CONFIG_DAVINCI_WATCHDOG=y
Date: Tue, 16 Jan 2018 06:17:14 -0600	[thread overview]
Message-ID: <CAHCN7xLwpLJPOe27sfKKbsSq3C75ZVtV9B0hpp3KDtAnxpc1mA@mail.gmail.com> (raw)
In-Reply-To: <800a4c95-ca8d-6235-288a-222a38c04cf9@ti.com>

On Mon, Jan 15, 2018 at 11:59 PM, Sekhar Nori <nsekhar@ti.com> wrote:
> On Monday 15 January 2018 10:59 PM, David Lechner wrote:
>> This changes CONFIG_DAVINCI_WATCHDOG from a module to a compiled-in
>> option. Since the reset function has been moved out of the mach code in
>> commit 0808d3260456 ("ARM: davinci: remove watchdog reset") and into the
>> watchdog driver, devices cannot reboot unless the watchdog driver is
>> loaded, so make it a compiled-in option so that we can always reboot, even
>> when modules are not loaded.
>>
>> Cc: Sekhar Nori <nsekhar@ti.com>
>> Suggested-by: Adam Ford <aford173@gmail.com>
>> Signed-off-by: David Lechner <david@lechnology.com>
>
> Hmm, we already depend on modules to load correctly for a lot of
> functionality. Why should reboot be an exception? In general, unless the
> driver is needed for loading rootfile system, I would keep it as a module.

I would argue that his patch corrects a regression introduced by the
patch series.  Before the series, 'reboot' worked properly without the
watchdog being loaded as a module.  With this patch series 'reboot'
stops functioning which I would argue is a regression.  Making the
watchdog part of the kernel fixes the broken reboot regression.  I
would request it be accepted.

>
> Thanks,
> Sekhar

adam

  reply	other threads:[~2018-01-16 12:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-01-15 17:29 [PATCH] ARM: davinci_all_defconfig: set CONFIG_DAVINCI_WATCHDOG=y David Lechner
2018-01-16  5:59 ` Sekhar Nori
2018-01-16 12:17   ` Adam Ford [this message]
2018-01-16 14:02     ` Sekhar Nori
2018-02-26  6:13 ` Sekhar Nori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHCN7xLwpLJPOe27sfKKbsSq3C75ZVtV9B0hpp3KDtAnxpc1mA@mail.gmail.com \
    --to=aford173@gmail.com \
    --cc=david@lechnology.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nsekhar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).