From: Joseph Hwang <josephsih@google.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-bluetooth <linux-bluetooth@vger.kernel.org>,
"Luiz Augusto von Dentz" <luiz.dentz@gmail.com>,
pali@kernel.org, chromeos-bluetooth-upstreaming@chromium.org,
"Miao-chen Chou" <mcchou@chromium.org>,
"Johan Hedberg" <johan.hedberg@gmail.com>,
linux-kernel@vger.kernel.org,
"Mark-YW Chen (陳揚文)" <Mark-YW.Chen@mediatek.com>
Subject: Re: [PATCH v6 3/3] Bluetooth: btusb: enable Mediatek to support AOSP extension
Date: Fri, 29 Oct 2021 22:12:48 +0800 [thread overview]
Message-ID: <CAHFy419JNEh6DZ68+JBLFOyp_jJgWv9nSy1ejvD1hECsDgbT6A@mail.gmail.com> (raw)
In-Reply-To: <92566E17-4D3A-4FB5-83B2-E2B9D4BBE2EF@holtmann.org>
Hi Marcel:
I see your point. Thank you for letting us know the right way to go.
I will discuss with Mediatek and request them to implement their
specific setup() for the purpose. And then they will submit a new
patch to enable AOSP extensions for their hardware.
Thanks and regards,
Joseph
On Fri, Oct 29, 2021 at 4:21 PM Marcel Holtmann <marcel@holtmann.org> wrote:
>
> Hi Joseph,
>
> > Some of Mediatek's controllers/firmwares do NOT support AOSP extensions.
> >
> > Please refer to this Gerrit patch review link for chrome os
> > (https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/3054233/8/drivers/bluetooth/btusb.c)
> > which was reviewed by Mark-YW Chen, Mediatek's engineer.
> >
> > As an example, MediaTek MT7615E does not support the AOSP extensions.
> >
> > That was why I used a new BTUSB_QUALITY_REPORT flag in the changes v4
> > and earlier ones.
> >
> > Please let me know how you would like to proceed with this patch.
>
> I want that inside the Mediatek specific hdev->setup() procedure, they decide if AOSP extensions are supported or not. The BTUSB flag business is getting out of hand. I really don’t want that in btusb.c anymore. I moved Intel over to do that in btintel.c and also Realtek is doing it in btrtl.c for their hardware with the MSFT extensions.
>
> We are not doing try-and-error of HCI commands. Just keep that in mind since I said that multiple times now.
>
> Regards
>
> Marcel
>
--
Joseph Shyh-In Hwang
Email: josephsih@google.com
next prev parent reply other threads:[~2021-10-29 14:13 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 15:04 [PATCH v6 1/3] Bluetooth: Add struct of reading AOSP vendor capabilities Joseph Hwang
2021-10-21 15:04 ` [PATCH v6 2/3] Bluetooth: aosp: Support AOSP Bluetooth Quality Report Joseph Hwang
2021-10-25 13:24 ` Marcel Holtmann
2021-10-21 15:04 ` [PATCH v6 3/3] Bluetooth: btusb: enable Mediatek to support AOSP extension Joseph Hwang
2021-10-25 13:26 ` Marcel Holtmann
2021-10-29 8:08 ` Joseph Hwang
2021-10-29 8:21 ` Marcel Holtmann
2021-10-29 14:12 ` Joseph Hwang [this message]
2021-10-25 13:18 ` [PATCH v6 1/3] Bluetooth: Add struct of reading AOSP vendor capabilities Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHFy419JNEh6DZ68+JBLFOyp_jJgWv9nSy1ejvD1hECsDgbT6A@mail.gmail.com \
--to=josephsih@google.com \
--cc=Mark-YW.Chen@mediatek.com \
--cc=chromeos-bluetooth-upstreaming@chromium.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcel@holtmann.org \
--cc=mcchou@chromium.org \
--cc=pali@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).