linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Amit Kucheria <amit.kucheria@verdurent.com>
To: Thara Gopinath <thara.gopinath@linaro.org>
Cc: Ingo Molnar <mingo@redhat.com>,
	Peter Zijlstra <peterz@infradead.org>,
	ionela.voinescu@arm.com,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Zhang Rui <rui.zhang@intel.com>,
	qperret@google.com, Daniel Lezcano <daniel.lezcano@linaro.org>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	Steven Rostedt <rostedt@goodmis.org>,
	Will Deacon <will@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Juri Lelli <juri.lelli@redhat.com>,
	corbet@lwn.net, LKML <linux-kernel@vger.kernel.org>,
	Amit Daniel Kachhap <amit.kachhap@gmail.com>,
	Javi Merino <javi.merino@kernel.org>
Subject: Re: [Patch v9 1/8] sched/pelt: Add support to track thermal pressure
Date: Thu, 13 Feb 2020 20:11:19 +0530	[thread overview]
Message-ID: <CAHLCerM_c8GTd2pqxtThaE7npR=SCk3cktt583LfDRVYUN1Aaw@mail.gmail.com> (raw)
In-Reply-To: <5E455919.5090506@linaro.org>

On Thu, Feb 13, 2020 at 7:41 PM Thara Gopinath
<thara.gopinath@linaro.org> wrote:
>
> On 02/13/2020 07:29 AM, Amit Kucheria wrote:
> > On Wed, Jan 29, 2020 at 4:06 AM Thara Gopinath
> > <thara.gopinath@linaro.org> wrote:
> >>

<snip>

> >> + * Unlike rt/dl utilization tracking that track time spent by a cpu
> >> + * running a rt/dl task through util_avg, the average thermal pressure is
> >> + * tracked through load_avg. This is because thermal pressure signal is
> >> + * weighted "delta" capacity and is not binary(util_avg is binary). "delta
> >
> > May I suggest a slight rewording here and in the commit description,
> >
> >    This is because the thermal pressure signal is weighted "delta"
> > capacity unlike util_avg which is binary.
>
> Sure! Will fix it.
>
> >
> > It would also help, if you expanded on what you mean by binary in the
> > commit description and how the delta capacity is weighted.
>
> I don't understand this. Binary means  0 or 1.

So the value returned by util_avg is literally 0 or 1? In which case
ignore my comment. I'll read the math again later.

> delta capacity is time
> weighted, i will update this.

Thanks.

  reply	other threads:[~2020-02-13 14:41 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-28 22:35 [Patch v9 0/8] Introduce Thermal Pressure Thara Gopinath
2020-01-28 22:36 ` [Patch v9 1/8] sched/pelt: Add support to track thermal pressure Thara Gopinath
2020-02-13 12:29   ` Amit Kucheria
2020-02-13 14:11     ` Thara Gopinath
2020-02-13 14:41       ` Amit Kucheria [this message]
2020-01-28 22:36 ` [Patch v9 2/8] sched/topology: Add hook to read per cpu " Thara Gopinath
2020-01-28 22:36 ` [Patch v9 3/8] arm,arm64,drivers:Add infrastructure to store and update instantaneous " Thara Gopinath
2020-02-13 12:25   ` Amit Kucheria
2020-02-13 14:05     ` Thara Gopinath
2020-02-13 14:38       ` Amit Kucheria
2020-02-14 15:01         ` Thara Gopinath
2020-01-28 22:36 ` [Patch v9 4/8] sched/fair: Enable periodic update of average " Thara Gopinath
2020-01-28 22:36 ` [Patch v9 5/8] sched/fair: update cpu_capacity to reflect " Thara Gopinath
2020-02-13 12:47   ` Amit Kucheria
2020-02-13 14:12     ` Thara Gopinath
2020-02-13 13:39   ` Amit Kucheria
2020-02-14 14:52     ` Thara Gopinath
2020-01-28 22:36 ` [Patch v9 6/8] thermal/cpu-cooling: Update thermal pressure in case of a maximum frequency capping Thara Gopinath
2020-01-28 22:36 ` [Patch v9 7/8] sched/fair: Enable tuning of decay period Thara Gopinath
2020-01-28 23:56   ` Randy Dunlap
2020-02-03 12:07     ` Thara Gopinath
2020-02-03 15:55       ` Peter Zijlstra
2020-02-04  8:39         ` Dietmar Eggemann
2020-02-07 22:42           ` Thara Gopinath
2020-02-10 11:59             ` Dietmar Eggemann
2020-02-13 13:54               ` Thara Gopinath
2020-02-14 10:26                 ` Dietmar Eggemann
2020-02-18 14:57                   ` Thara Gopinath
2020-02-19  9:14                     ` Dietmar Eggemann
2020-01-28 22:36 ` [Patch v9 8/8] arm64: Enable averaging of thermal pressure for arm64 based SoCs Thara Gopinath
2020-02-03  8:59   ` Dietmar Eggemann
2020-02-10 12:07 ` [Patch v9 0/8] Introduce Thermal Pressure Dietmar Eggemann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHLCerM_c8GTd2pqxtThaE7npR=SCk3cktt583LfDRVYUN1Aaw@mail.gmail.com' \
    --to=amit.kucheria@verdurent.com \
    --cc=amit.kachhap@gmail.com \
    --cc=catalin.marinas@arm.com \
    --cc=corbet@lwn.net \
    --cc=daniel.lezcano@linaro.org \
    --cc=dietmar.eggemann@arm.com \
    --cc=ionela.voinescu@arm.com \
    --cc=javi.merino@kernel.org \
    --cc=juri.lelli@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=peterz@infradead.org \
    --cc=qperret@google.com \
    --cc=rostedt@goodmis.org \
    --cc=rui.zhang@intel.com \
    --cc=sudeep.holla@arm.com \
    --cc=thara.gopinath@linaro.org \
    --cc=vincent.guittot@linaro.org \
    --cc=viresh.kumar@linaro.org \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).