From: Amit Kucheria <amit.kucheria@linaro.org>
To: Stephen Boyd <swboyd@chromium.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Eduardo Valentin <edubezval@gmail.com>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
sivaa@codeaurora.org, Daniel Lezcano <daniel.lezcano@linaro.org>,
Linux PM list <linux-pm@vger.kernel.org>
Subject: Re: [PATCH 2/3] drivers: thermal: tsens: Add watchdog support
Date: Fri, 29 Nov 2019 00:46:26 +0530 [thread overview]
Message-ID: <CAHLCerN1n7c76MicKWCWE8aSpxrwrMEuN1mAtPwXykFWi2vEuQ@mail.gmail.com> (raw)
In-Reply-To: <5dcdd754.1c69fb81.27caf.7022@mx.google.com>
On Fri, Nov 15, 2019 at 4:08 AM Stephen Boyd <swboyd@chromium.org> wrote:
>
> Quoting Amit Kucheria (2019-11-11 11:21:28)
> > TSENS IP v2.3 onwards adds support for a watchdog to detect if the TSENS
> > HW FSM is frozen. Add support to detect and restart the FSM in the
>
> Maybe 'frozen' is an ambiguous term? Maybe 'stuck' or 'has stopped
> making progress'?
Alright, let's keep Disney out of this. Will use 'stuck'.
> > driver. The watchdog is configured by the bootloader, we just enable the
> > feature in the kernel.
>
> Does it work to enable it if we don't configure it in the bootloader?
TBH, I don't know. Getting modified firmware to test this will be a
bit of a challenge.
> >
> > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
> > ---
> > drivers/thermal/qcom/tsens-common.c | 41 +++++++++++++++++++++++++++++
> > drivers/thermal/qcom/tsens-v2.c | 10 +++++++
> > drivers/thermal/qcom/tsens.h | 12 +++++++++
> > 3 files changed, 63 insertions(+)
> >
> > diff --git a/drivers/thermal/qcom/tsens-common.c b/drivers/thermal/qcom/tsens-common.c
> > index 2989cb952cdb..9432518502a7 100644
> > --- a/drivers/thermal/qcom/tsens-common.c
> > +++ b/drivers/thermal/qcom/tsens-common.c
> > @@ -794,6 +820,21 @@ int __init init_common(struct tsens_priv *priv)
> > }
> > }
> >
> > + if (tsens_version(priv) > VER_1_X && ver_minor > 2) {
> > + /* Watchdog is present only on v2.3+ */
> > + for (i = 0, j = WDOG_BARK_STATUS; j <= CC_MON_MASK; i++, j++) {
>
> The variable 'i' is not actually used in this loop. What's going on?
Sorry, left over from a botched copy-paste job from the loop above
this. Will fix.
>
> > + priv->rf[j] = devm_regmap_field_alloc(dev, priv->tm_map,
> > + priv->fields[j]);
> > + if (IS_ERR(priv->rf[j])) {
> > + ret = PTR_ERR(priv->rf[j]);
> > + goto err_put_device;
> > + }
> > + }
> > + /* Enable WDOG and disable cycle completion monitoring */
> > + regmap_field_write(priv->rf[WDOG_BARK_MASK], 0);
> > + regmap_field_write(priv->rf[CC_MON_MASK], 1);
> > + }
next prev parent reply other threads:[~2019-11-28 19:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 19:21 [PATCH 0/3] thermal: tsens: Handle critical interrupts Amit Kucheria
2019-11-11 19:21 ` [PATCH 1/3] drivers: thermal: tsens: Add critical interrupt support Amit Kucheria
2019-11-12 19:38 ` Bjorn Andersson
2019-11-28 18:46 ` Amit Kucheria
2019-11-28 21:43 ` Bjorn Andersson
2019-12-03 5:02 ` Amit Kucheria
2019-11-14 22:50 ` Stephen Boyd
2019-12-03 4:57 ` Amit Kucheria
2019-11-11 19:21 ` [PATCH 2/3] drivers: thermal: tsens: Add watchdog support Amit Kucheria
2019-11-12 19:22 ` Bjorn Andersson
2019-11-28 19:18 ` Amit Kucheria
2019-11-14 22:38 ` Stephen Boyd
2019-11-28 19:16 ` Amit Kucheria [this message]
2019-11-11 19:21 ` [PATCH 3/3] arm64: dts: sdm845: thermal: Add critical interrupt support Amit Kucheria
2019-11-12 19:43 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHLCerN1n7c76MicKWCWE8aSpxrwrMEuN1mAtPwXykFWi2vEuQ@mail.gmail.com \
--to=amit.kucheria@linaro.org \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=edubezval@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=sivaa@codeaurora.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).