From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04FE9C3F68F for ; Wed, 1 Jan 2020 21:08:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id CE6542080A for ; Wed, 1 Jan 2020 21:08:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="gx2UBQVA" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727359AbgAAVIh (ORCPT ); Wed, 1 Jan 2020 16:08:37 -0500 Received: from mail-vs1-f67.google.com ([209.85.217.67]:35078 "EHLO mail-vs1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727196AbgAAVIh (ORCPT ); Wed, 1 Jan 2020 16:08:37 -0500 Received: by mail-vs1-f67.google.com with SMTP id x123so24375423vsc.2 for ; Wed, 01 Jan 2020 13:08:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aky0/K6ipzZUQtU1J8iwS16GYzW4RxCCQJcReDQ16e4=; b=gx2UBQVAHcOXdrGTmaE7Z7UDehfiE1XzFcVmlpCWHmrseOYxtIi6dTejHGOfwXsgJo 9u0voMJ32vaQ8W6rybZP5c7HyOM5Jekf5UWkvFZt+NEuD+ajbQyWov64mf8MijCyBW3a VB79h0LDv+MiTbsNnmsDfI0zbvaQvsBupNZnWD2JcyipcE34o6WBFrTHEJqZBXbvIJZv t2s/gkraZKZ2np2Zc1ZY6HNAqMpJv+EAuUA9g91BrfbiGhyB0DiEAyVmot5B50CZ2qmO Q9LAuecYhjSY9rEn72W6okNn+wfpOyJfm/jAG+YEFGF6BjkQY3zSxmAylhLCkRJ1d+D3 oLBg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aky0/K6ipzZUQtU1J8iwS16GYzW4RxCCQJcReDQ16e4=; b=MEWuALLU+mmgD4Rd6v+L57GfKmTQC4RWi0wJsG6oDCfkqw8rRJ72X2Tf9IQEFgv9uY D2TrMPutCtJc3CQEYzD14VCVOng+jpbsvcWYlzDtv/SHcZra9JpbPvpIAn9kEIaBmTOS 3gQ/Gipz23uZC4Xidr4WsBmgWg7e/aY4i6wiMpvZeAJoWyQqK+YvnGGp2qeJ065YrQX5 Riohtrqz1EDVRWJpbMFqNrjizDxLIpnbFj6vnPEJs9dgF0Hxn8/y3W43DsnHFQ3Agumk 9p8AXEj/FTEJy8pX3B8BN6V7lZk8u/AP302/7x9tAFkA7S6BFtddkQcAVNuuaVFgzCLx NgHQ== X-Gm-Message-State: APjAAAVoWN6Vu1kN3m5rCBq9rOsMNN5Dml0Da5WQBJafDHZtbv082QNR k44C63fOCokcduoT6hTAj8sVbSW54C+KbUCcMo+J0w== X-Google-Smtp-Source: APXvYqxKINiKDhC6XhOJOfqlHXl3pNjzXtm5zBUf4t1DLw/wCQDeZPxxg4OVLsoCk6lycDFoFsWqLcEQfPWDGEe7Ryk= X-Received: by 2002:a05:6102:d4:: with SMTP id u20mr32339102vsp.27.1577912915852; Wed, 01 Jan 2020 13:08:35 -0800 (PST) MIME-Version: 1.0 References: <1577106871-19863-1-git-send-email-rkambl@codeaurora.org> <1577106871-19863-2-git-send-email-rkambl@codeaurora.org> In-Reply-To: <1577106871-19863-2-git-send-email-rkambl@codeaurora.org> From: Amit Kucheria Date: Thu, 2 Jan 2020 02:38:24 +0530 Message-ID: Subject: Re: [PATCH 1/2] arm64: dts: qcom: sc7180: Add critical interrupt and cooling maps for TSENS in SC7180. To: Rajeshwari Cc: Andy Gross , Rob Herring , Mark Rutland , Bjorn Andersson , Zhang Rui , Daniel Lezcano , linux-arm-msm , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux PM list , LKML , sanm@codeaurora.org, sivaa@codeaurora.org, manafm@codeaurora.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Dec 23, 2019 at 6:46 PM Rajeshwari wrote: > > Signed-off-by: Rajeshwari > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 289 +++++++++++++++++++++++++++++------ > 1 file changed, 239 insertions(+), 50 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc7180.dtsi b/arch/arm64/boot/dts/qcom/sc7180.dtsi > index 3676bfd..e419ca0 100644 > --- a/arch/arm64/boot/dts/qcom/sc7180.dtsi > +++ b/arch/arm64/boot/dts/qcom/sc7180.dtsi > @@ -10,6 +10,7 @@ > #include > #include > #include > +#include > - cpu1-thermal { > + cpu_0_1-thermal { Is this renaming to include the cluster number really improving anything considering that the cpus section defines them as CPU0..CPU7? Leave them as-is. > polling-delay-passive = <250>; > polling-delay = <1000>; > > thermal-sensors = <&tsens0 2>; > > trips { > - cpu1_alert0: trip-point0 { > + cpu_0_1_alert0: trip-point0 { cpu_0_1_alert0 is unnecessarily too long, IMO. Leave it as-is. Same for all the renames below. > temperature = <90000>; > hysteresis = <2000>; > type = "passive"; > }; > > - cpu1_alert1: trip-point1 { > + cpu_0_1_alert1: trip-point1 { > temperature = <95000>; > hysteresis = <2000>; > type = "passive"; > }; > > - cpu1_crit: cpu_crit { > + cpu_0_1_crit: cpu_crit { > temperature = <110000>; > hysteresis = <1000>; > type = "critical"; > }; > };