From: Amit Kucheria <amitk@kernel.org>
To: Ansuel Smith <ansuelsmth@gmail.com>
Cc: Amit Kucheria <amit.kucheria@linaro.org>,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Zhang Rui <rui.zhang@intel.com>,
Daniel Lezcano <daniel.lezcano@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Linux PM list <linux-pm@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH v6 2/8] drivers: thermal: tsens: Add VER_0 tsens version
Date: Sun, 29 Nov 2020 18:28:01 +0530 [thread overview]
Message-ID: <CAHLCerNTNpEGiGT6Veroeh1b8pOCiYYFhpnj5YqZcFZxAXGB-A@mail.gmail.com> (raw)
In-Reply-To: <20201125122228.GB23592@ansuel-xps20.localdomain>
On Thu, Nov 26, 2020 at 2:16 AM Ansuel Smith <ansuelsmth@gmail.com> wrote:
> > > };
> > > @@ -441,6 +442,10 @@ enum regfield_ids {
> > > CRIT_THRESH_14,
> > > CRIT_THRESH_15,
> > >
> > > + /* VER_0 MIN MAX THRESH */
> > > + MIN_THRESH_0,
> > > + MAX_THRESH_0,
> > > +
> >
> > Consider reusing LOW_THRESH_0 and UP_THRESH_0 for these?
> >
>
> As we already have defined LOW_THRESH and UP how can we reuse that
> regfield to define MIN and MAX?
>
We are using MIN and MAX THRESH on the apq8064 to mean LOW and UP
THRESOLD, isn't it? IIUC, It was just named differently earlier.
When the driver is loaded on the apq8064, only that one field will be
use since v0 has a single threshold for all sensors. When the driver
is loaded on new IPs, all fields will be used.
next prev parent reply other threads:[~2020-11-29 12:59 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-14 13:41 [RFC PATCH v6 0/8] Add support for ipq8064 tsens Ansuel Smith
2020-08-14 13:41 ` [RFC PATCH v6 1/8] drivers: thermal: tsens: use get_temp for tsens_valid Ansuel Smith
2020-11-22 19:35 ` Amit Kucheria
2020-08-14 13:41 ` [RFC PATCH v6 2/8] drivers: thermal: tsens: Add VER_0 tsens version Ansuel Smith
2020-11-22 20:05 ` Amit Kucheria
2020-11-25 12:22 ` Ansuel Smith
2020-11-29 12:58 ` Amit Kucheria [this message]
2020-11-29 16:28 ` Ansuel Smith
2020-08-14 13:41 ` [RFC PATCH v6 3/8] drivers: thermal: tsens: Convert msm8960 to reg_field Ansuel Smith
2020-08-14 13:41 ` [RFC PATCH v6 4/8] drivers: thermal: tsens: Use init_common for msm8960 Ansuel Smith
2020-08-14 13:41 ` [RFC PATCH v6 5/8] drivers: thermal: tsens: Fix wrong get_temp " Ansuel Smith
2020-08-14 13:41 ` [RFC PATCH v6 6/8] drivers: thermal: tsens: Change calib_backup name " Ansuel Smith
2020-08-14 13:41 ` [RFC PATCH v6 7/8] drivers: thermal: tsens: Add support for ipq8064-tsens Ansuel Smith
2020-08-14 13:41 ` [RFC PATCH v6 8/8] dt-bindings: thermal: tsens: Document ipq8064 bindings Ansuel Smith
2020-09-28 11:32 ` [RFC PATCH v6 0/8] Add support for ipq8064 tsens Amit Kucheria
2020-09-28 11:35 ` ansuelsmth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHLCerNTNpEGiGT6Veroeh1b8pOCiYYFhpnj5YqZcFZxAXGB-A@mail.gmail.com \
--to=amitk@kernel.org \
--cc=agross@kernel.org \
--cc=amit.kucheria@linaro.org \
--cc=ansuelsmth@gmail.com \
--cc=bjorn.andersson@linaro.org \
--cc=daniel.lezcano@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).