From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C38CECA9ED3 for ; Mon, 4 Nov 2019 06:21:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 99DEA205C9 for ; Mon, 4 Nov 2019 06:21:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=verdurent-com.20150623.gappssmtp.com header.i=@verdurent-com.20150623.gappssmtp.com header.b="tChmpZXn" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728262AbfKDGVq (ORCPT ); Mon, 4 Nov 2019 01:21:46 -0500 Received: from mail-vs1-f67.google.com ([209.85.217.67]:43713 "EHLO mail-vs1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726018AbfKDGVq (ORCPT ); Mon, 4 Nov 2019 01:21:46 -0500 Received: by mail-vs1-f67.google.com with SMTP id b16so4125455vso.10 for ; Sun, 03 Nov 2019 22:21:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=verdurent-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7XR8aB5FAq9qkqAbv6gsdSxRJnXfyOytqENlU/Ne5DU=; b=tChmpZXnDE+NZfUpbyo9vgercVEz57+g+KJ6PCCgO4+F9c9kwGAkmddksvV48bLCF9 p/FUK8tFwUmLyBblcmvupC7rnr4BmNQJUdkyZGCr8gfMZ80Ac3rXLTeUK68zqtgS6drH jNuJGYGJ3zQr+A5C4Q/0QiOjNmAcQjr7myleAIRBlYesLUIlQQ7gpLfYLyaZ9ANUI7OF ddCeyNTYE5/ciITcrSmpHyuDKyQQR/RQtsCIcPHuwbU9P6A2Hurlc6/1EHfji9GfaaNp 626+TXtHgKfR47I+1e+nOuRYIPol1W7fNOW0Trgc9eT4QvJt58zkzsV9XaNKhv79evHV LUSg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7XR8aB5FAq9qkqAbv6gsdSxRJnXfyOytqENlU/Ne5DU=; b=CDWn1LSj3lwpyYur8KIwnA1/cDPLPUpA+PSO/M+4DvQMkQ9Ei0ty6y/zhuS6LhdJuu QFntdlDmB7Wr3VlQ4tBLpXuq+qSShgsgdTIGfi+LkcldyJkYENpb7JPgYeslaatY3m18 OmRJ9sfcgpbA46w4PGBn3K8HX+UOooTcNKPlnn1DAQp38E/ObqvPvEwGQ7/htA1BSox0 F5iqZLaDyw/FT++ywfF7SSblh40rcYK8+SJYfSqgSm5TBuL5ughD09LtVv7b4L4XPSdH Lr3S64HdB+U+ekTaleHBplLnarp+/osD/axvFezr79+RNF0xuI4jjlFjq4vaKtzmZjpA WapQ== X-Gm-Message-State: APjAAAWCDIuoQqYJPaEFuODCigWMgm8YO4lca+dYtYupLQKyxF71lofR Wbl/QuIJpeKj26pqcsH2jMk0ap3snn7Alw2U8vP92Q== X-Google-Smtp-Source: APXvYqyWHViqGHAgMlTc9BBuG9Nxtj3v53mAItQ8daEFU0o9x+TOGhJ1eiReK7K71hBJG16iXSGIYEcT6HWTxYKKOmA= X-Received: by 2002:a67:df0d:: with SMTP id s13mr10831700vsk.95.1572848504953; Sun, 03 Nov 2019 22:21:44 -0800 (PST) MIME-Version: 1.0 References: <20191030091038.678-1-daniel.lezcano@linaro.org> <20191030091038.678-2-daniel.lezcano@linaro.org> In-Reply-To: <20191030091038.678-2-daniel.lezcano@linaro.org> From: Amit Kucheria Date: Mon, 4 Nov 2019 11:51:33 +0530 Message-ID: Subject: Re: [PATCH 2/2] thermal: cpu_cooling: Reorder the header file To: Daniel Lezcano Cc: Amit Daniel Kachhap , Viresh Kumar , Javi Merino , Zhang Rui , Eduardo Valentin , "open list:THERMAL/CPU_COOLING" , open list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Oct 30, 2019 at 2:41 PM Daniel Lezcano wrote: > > As the conditions are simplified and unified, it is useless to have > different blocks of definitions under the same compiler condition, > let's merge the blocks. > > There is no functional change. > > Signed-off-by: Daniel Lezcano Reviewed-by: Amit Kucheria > --- > include/linux/cpu_cooling.h | 16 +++++++--------- > 1 file changed, 7 insertions(+), 9 deletions(-) > > diff --git a/include/linux/cpu_cooling.h b/include/linux/cpu_cooling.h > index 72d1c9c5e538..b74732535e4b 100644 > --- a/include/linux/cpu_cooling.h > +++ b/include/linux/cpu_cooling.h > @@ -33,6 +33,13 @@ cpufreq_cooling_register(struct cpufreq_policy *policy); > */ > void cpufreq_cooling_unregister(struct thermal_cooling_device *cdev); > > +/** > + * of_cpufreq_cooling_register - create cpufreq cooling device based on DT. > + * @policy: cpufreq policy. > + */ > +struct thermal_cooling_device * > +of_cpufreq_cooling_register(struct cpufreq_policy *policy); > + > #else /* !CONFIG_CPU_THERMAL */ > static inline struct thermal_cooling_device * > cpufreq_cooling_register(struct cpufreq_policy *policy) > @@ -45,16 +52,7 @@ void cpufreq_cooling_unregister(struct thermal_cooling_device *cdev) > { > return; > } > -#endif /* CONFIG_CPU_THERMAL */ > > -#ifdef CONFIG_CPU_THERMAL > -/** > - * of_cpufreq_cooling_register - create cpufreq cooling device based on DT. > - * @policy: cpufreq policy. > - */ > -struct thermal_cooling_device * > -of_cpufreq_cooling_register(struct cpufreq_policy *policy); > -#else > static inline struct thermal_cooling_device * > of_cpufreq_cooling_register(struct cpufreq_policy *policy) > { > -- > 2.17.1 >