From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 150F9C2BA1A for ; Sat, 4 Apr 2020 07:31:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id DC0A6206B8 for ; Sat, 4 Apr 2020 07:31:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=verdurent-com.20150623.gappssmtp.com header.i=@verdurent-com.20150623.gappssmtp.com header.b="K9YbTwii" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726380AbgDDHb3 (ORCPT ); Sat, 4 Apr 2020 03:31:29 -0400 Received: from mail-ua1-f65.google.com ([209.85.222.65]:45514 "EHLO mail-ua1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725837AbgDDHb2 (ORCPT ); Sat, 4 Apr 2020 03:31:28 -0400 Received: by mail-ua1-f65.google.com with SMTP id 9so3607210uav.12 for ; Sat, 04 Apr 2020 00:31:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=verdurent-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dXNBeLfM6R3R19w3bxqedjhSw7Yhw0sbY/Bu8wxHhNM=; b=K9YbTwiiwL/a4VLDnpu5F3Hq8KeS8sp2Bogf3BWS8wg6wCIlaDysaRLwg2ST82QLUR nUQpTR/v1zRda+156B0X8ftbXO2WUt6H26B8+4YfKy43SMkveIuOnbwDuihA4edy+PzM WW2xHUZjnYmwUS4RJwf7/q8cV3nzbsfFQi+xqKtsIDuKJl2qsk3YdmCkxBoe96HfyzVa hOha+K3Crr31w3B/0eXDmTQwhbr5xXgEP+GwVrdbJsaTPImW/qnL6DZUfMwMnUOvDNR/ LkImfM5LUM0Vzas4XekGUg8OljE0XwgWF4krPz/WrqRzhqyYCJwwfVpRBIaC81uGjvgf k1Ig== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dXNBeLfM6R3R19w3bxqedjhSw7Yhw0sbY/Bu8wxHhNM=; b=QI/hEdDodPKu7oSV4IQQJ9XTOgzONMhH4RofivibJ3Vy1g/2iubpU94hPIcoXJYPeb OZwG8KFRPRcazVUtKgWv7GDqGQBo8tgpgsDx9xjJCiFFfLd2nfk9236678TQzX7jxxiE DL2at6pSWR+jrl2fE3Wt/Bi8Adq5PEOH/9sE6HLrn+I0rSCHfp7BSmSj1hhwtnE27hfY oVboMOY1gCWpptISveL8dkb7cUtntA2QtBJu/vnUl4sH+8uKLbMB4M7XxN65C1ejo04x Dg+qJqGT91Fx08tAYtbmPtrFFA3s6S+aObecQ3hbZYkAY2o0IYUpbVc1Nl97AZlRmwBJ S5eQ== X-Gm-Message-State: AGi0Pubn/uFpFVzg8KxvArrUnWo/BpQTCfEcqK841zxZnfFBmzlIpQfI rNzEDb8PZaTiT1ZOu/02fX0aFy2UCSCCCSBsVz9i4A== X-Google-Smtp-Source: APiQypIq2cyCGz5JZIv/r8tGEb/BpinV5GrEfcNrT3/vbI5ddO5WB/a7RzCBv4uPhl0soQO+cllbNeAjHq87RdpoFB0= X-Received: by 2002:ab0:70d9:: with SMTP id r25mr9801332ual.67.1585985486878; Sat, 04 Apr 2020 00:31:26 -0700 (PDT) MIME-Version: 1.0 References: <20200402142747.8307-1-daniel.lezcano@linaro.org> In-Reply-To: <20200402142747.8307-1-daniel.lezcano@linaro.org> From: Amit Kucheria Date: Sat, 4 Apr 2020 13:00:00 +0530 Message-ID: Subject: Re: [PATCH V2 1/9] thermal: Move default governor config option to the internal header To: Daniel Lezcano Cc: Zhang Rui , "open list:THERMAL" , open list Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 2, 2020 at 7:58 PM Daniel Lezcano wrote: > > The default governor set at compilation time is a thermal internal > business, no need to export to the global thermal header. > > Move the config options to the internal header. > > Signed-off-by: Daniel Lezcano Reviewed-by: Amit Kucheria > --- > drivers/thermal/thermal_core.h | 11 +++++++++++ > include/linux/thermal.h | 11 ----------- > 2 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h > index 37cd4e2bead2..828305508556 100644 > --- a/drivers/thermal/thermal_core.h > +++ b/drivers/thermal/thermal_core.h > @@ -12,6 +12,17 @@ > #include > #include > > +/* Default Thermal Governor */ > +#if defined(CONFIG_THERMAL_DEFAULT_GOV_STEP_WISE) > +#define DEFAULT_THERMAL_GOVERNOR "step_wise" > +#elif defined(CONFIG_THERMAL_DEFAULT_GOV_FAIR_SHARE) > +#define DEFAULT_THERMAL_GOVERNOR "fair_share" > +#elif defined(CONFIG_THERMAL_DEFAULT_GOV_USER_SPACE) > +#define DEFAULT_THERMAL_GOVERNOR "user_space" > +#elif defined(CONFIG_THERMAL_DEFAULT_GOV_POWER_ALLOCATOR) > +#define DEFAULT_THERMAL_GOVERNOR "power_allocator" > +#endif > + > /* Initial state of a cooling device during binding */ > #define THERMAL_NO_TARGET -1UL > > diff --git a/include/linux/thermal.h b/include/linux/thermal.h > index 448841ab0dca..71cff87dcb46 100644 > --- a/include/linux/thermal.h > +++ b/include/linux/thermal.h > @@ -32,17 +32,6 @@ > /* use value, which < 0K, to indicate an invalid/uninitialized temperature */ > #define THERMAL_TEMP_INVALID -274000 > > -/* Default Thermal Governor */ > -#if defined(CONFIG_THERMAL_DEFAULT_GOV_STEP_WISE) > -#define DEFAULT_THERMAL_GOVERNOR "step_wise" > -#elif defined(CONFIG_THERMAL_DEFAULT_GOV_FAIR_SHARE) > -#define DEFAULT_THERMAL_GOVERNOR "fair_share" > -#elif defined(CONFIG_THERMAL_DEFAULT_GOV_USER_SPACE) > -#define DEFAULT_THERMAL_GOVERNOR "user_space" > -#elif defined(CONFIG_THERMAL_DEFAULT_GOV_POWER_ALLOCATOR) > -#define DEFAULT_THERMAL_GOVERNOR "power_allocator" > -#endif > - > struct thermal_zone_device; > struct thermal_cooling_device; > struct thermal_instance; > -- > 2.17.1 >