From: Amit Kucheria <amit.kucheria@linaro.org>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-arm-msm <linux-arm-msm@vger.kernel.org>,
Viresh Kumar <viresh.kumar@linaro.org>,
Eduardo Valentin <edubezval@gmail.com>,
Stephen Boyd <swboyd@chromium.org>,
Douglas Anderson <dianders@chromium.org>,
Matthias Kaehlcke <mka@chromium.org>,
Linux PM list <linux-pm@vger.kernel.org>
Subject: Re: [PATCH v1 03/10] cpufreq: Replace open-coded << with BIT()
Date: Mon, 21 Jan 2019 14:18:59 +0530 [thread overview]
Message-ID: <CAHLCerP0SieD_4X_ZOxogxOsdFZSRO-B_2cDnR8fpJYFdEUTvw@mail.gmail.com> (raw)
In-Reply-To: <2392396.AI7Hxg4e4v@aspire.rjw.lan>
On Thu, Jan 17, 2019 at 4:26 AM Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
>
> On Monday, January 14, 2019 5:34:55 PM CET Amit Kucheria wrote:
> > Minor clean-up to use BIT() and keep checkpatch happy. Clean up the
> > comment formatting while we're at it to make it easier to read.
> >
> > Signed-off-by: Amit Kucheria <amit.kucheria@linaro.org>
>
> Can you please do this cleanup as the first patch in the series, so it
> doesn't depend on the other patches in it, which isn't necessary IMO?
I've sent it out separately now, unconnected to the series.
Thanks.
Regards,
Amit
> > ---
> > include/linux/cpufreq.h | 27 ++++++++++++++-------------
> > 1 file changed, 14 insertions(+), 13 deletions(-)
> >
> > diff --git a/include/linux/cpufreq.h b/include/linux/cpufreq.h
> > index 70ad02088825..ea303dfd5f05 100644
> > --- a/include/linux/cpufreq.h
> > +++ b/include/linux/cpufreq.h
> > @@ -351,14 +351,15 @@ struct cpufreq_driver {
> > };
> >
> > /* flags */
> > -#define CPUFREQ_STICKY (1 << 0) /* driver isn't removed even if
> > - all ->init() calls failed */
> > -#define CPUFREQ_CONST_LOOPS (1 << 1) /* loops_per_jiffy or other
> > - kernel "constants" aren't
> > - affected by frequency
> > - transitions */
> > -#define CPUFREQ_PM_NO_WARN (1 << 2) /* don't warn on suspend/resume
> > - speed mismatches */
> > +
> > +/* driver isn't removed even if all ->init() calls failed */
> > +#define CPUFREQ_STICKY BIT(0)
> > +
> > +/* loops_per_jiffy or other kernel "constants" aren't affected by frequency transitions */
> > +#define CPUFREQ_CONST_LOOPS BIT(1)
> > +
> > +/* don't warn on suspend/resume speed mismatches */
> > +#define CPUFREQ_PM_NO_WARN BIT(2)
> >
> > /*
> > * This should be set by platforms having multiple clock-domains, i.e.
> > @@ -366,14 +367,14 @@ struct cpufreq_driver {
> > * be created in cpu/cpu<num>/cpufreq/ directory and so they can use the same
> > * governor with different tunables for different clusters.
> > */
> > -#define CPUFREQ_HAVE_GOVERNOR_PER_POLICY (1 << 3)
> > +#define CPUFREQ_HAVE_GOVERNOR_PER_POLICY BIT(3)
> >
> > /*
> > * Driver will do POSTCHANGE notifications from outside of their ->target()
> > * routine and so must set cpufreq_driver->flags with this flag, so that core
> > * can handle them specially.
> > */
> > -#define CPUFREQ_ASYNC_NOTIFICATION (1 << 4)
> > +#define CPUFREQ_ASYNC_NOTIFICATION BIT(4)
> >
> > /*
> > * Set by drivers which want cpufreq core to check if CPU is running at a
> > @@ -382,19 +383,19 @@ struct cpufreq_driver {
> > * from the table. And if that fails, we will stop further boot process by
> > * issuing a BUG_ON().
> > */
> > -#define CPUFREQ_NEED_INITIAL_FREQ_CHECK (1 << 5)
> > +#define CPUFREQ_NEED_INITIAL_FREQ_CHECK BIT(5)
> >
> > /*
> > * Set by drivers to disallow use of governors with "dynamic_switching" flag
> > * set.
> > */
> > -#define CPUFREQ_NO_AUTO_DYNAMIC_SWITCHING (1 << 6)
> > +#define CPUFREQ_NO_AUTO_DYNAMIC_SWITCHING BIT(6)
> >
> > /*
> > * Set by drivers that want the core to automatically register the cpufreq
> > * driver as a thermal cooling device
> > */
> > -#define CPUFREQ_AUTO_REGISTER_COOLING_DEV (1 << 7)
> > +#define CPUFREQ_AUTO_REGISTER_COOLING_DEV BIT(7)
> >
> > int cpufreq_register_driver(struct cpufreq_driver *driver_data);
> > int cpufreq_unregister_driver(struct cpufreq_driver *driver_data);
> >
>
>
next prev parent reply other threads:[~2019-01-21 8:49 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-14 16:34 [PATCH v1 00/10] cpufreq: Add flag to auto-register as cooling device Amit Kucheria
2019-01-14 16:34 ` [PATCH v1 01/10] cpufreq: Add thermal_cooling_device pointer to struct cpufreq_policy Amit Kucheria
2019-01-16 22:56 ` Rafael J. Wysocki
2019-01-21 15:35 ` Amit Kucheria
2019-01-14 16:34 ` [PATCH v1 02/10] cpufreq: Add a flag to auto-register a cooling device Amit Kucheria
2019-01-14 20:51 ` Matthias Kaehlcke
2019-01-16 23:03 ` Rafael J. Wysocki
2019-01-17 4:42 ` Viresh Kumar
2019-01-21 14:23 ` Amit Kucheria
2019-01-14 16:34 ` [PATCH v1 03/10] cpufreq: Replace open-coded << with BIT() Amit Kucheria
2019-01-15 19:05 ` Stephen Boyd
2019-01-16 22:55 ` Rafael J. Wysocki
2019-01-21 8:48 ` Amit Kucheria [this message]
2019-01-14 16:34 ` [PATCH v1 04/10] cpufreq: qcom-hw: Register as a cpufreq cooling device Amit Kucheria
2019-01-14 20:54 ` Matthias Kaehlcke
2019-01-14 16:34 ` [PATCH v1 05/10] cpufreq: imx6q: Use auto-registration of thermal " Amit Kucheria
2019-01-17 4:49 ` Viresh Kumar
2019-01-14 16:34 ` [PATCH v1 06/10] cpufreq: cpufreq-dt: " Amit Kucheria
2019-01-14 16:34 ` [PATCH v1 07/10] cpufreq: mediatek: " Amit Kucheria
2019-01-14 16:35 ` [PATCH v1 08/10] cpufreq: qoriq: " Amit Kucheria
2019-01-14 16:35 ` [PATCH v1 09/10] cpufreq: scmi: " Amit Kucheria
2019-01-15 10:37 ` Sudeep Holla
2019-01-14 16:35 ` [PATCH v1 10/10] cpufreq: scpi: " Amit Kucheria
2019-01-17 5:49 ` [PATCH v1 00/10] cpufreq: Add flag to auto-register as " Viresh Kumar
2019-01-17 10:08 ` Rafael J. Wysocki
2019-01-17 10:14 ` Rafael J. Wysocki
2019-01-17 10:28 ` Viresh Kumar
2019-01-17 10:31 ` Rafael J. Wysocki
2019-01-17 10:21 ` Viresh Kumar
2019-01-17 10:29 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHLCerP0SieD_4X_ZOxogxOsdFZSRO-B_2cDnR8fpJYFdEUTvw@mail.gmail.com \
--to=amit.kucheria@linaro.org \
--cc=dianders@chromium.org \
--cc=edubezval@gmail.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mka@chromium.org \
--cc=rjw@rjwysocki.net \
--cc=swboyd@chromium.org \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).